Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9058

deleteSnapshot() call may be skipped in TestFlushSnapshotFromClient tests

    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None
    • Reviewed

    Description

      At the end of each test, we have this call:

      admin.deleteSnapshot(snapshotName);

      However it is not placed in finally block. When assertion in earlier part of the test fails (See [1]), snapshot cleanup would be skipped, leading to SnapshotTestingUtils.assertNoSnapshots() failing for subsequent tests.

      [1]: https://builds.apache.org/job/hbase-0.95-on-hadoop2/197/testReport/org.apache.hadoop.hbase.snapshot/TestFlushSnapshotFromClient/testFlushCreateListDestroy/

      Attachments

        1. 9058.patch
          3 kB
          Ted Yu
        2. 9058.patch
          3 kB
          Ted Yu
        3. 9058-v2.patch
          3 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: