HBase
  1. HBase
  2. HBASE-9058

deleteSnapshot() call may be skipped in TestFlushSnapshotFromClient tests

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      At the end of each test, we have this call:

      admin.deleteSnapshot(snapshotName);

      However it is not placed in finally block. When assertion in earlier part of the test fails (See [1]), snapshot cleanup would be skipped, leading to SnapshotTestingUtils.assertNoSnapshots() failing for subsequent tests.

      [1]: https://builds.apache.org/job/hbase-0.95-on-hadoop2/197/testReport/org.apache.hadoop.hbase.snapshot/TestFlushSnapshotFromClient/testFlushCreateListDestroy/

      1. 9058.patch
        3 kB
        Ted Yu
      2. 9058.patch
        3 kB
        Ted Yu
      3. 9058-v2.patch
        3 kB
        Ted Yu

        Activity

        Ted Yu created issue -
        Ted Yu made changes -
        Field Original Value New Value
        Assignee Ted Yu [ yuzhihong@gmail.com ]
        Ted Yu made changes -
        Attachment 9055-v2.txt [ 12594539 ]
        Ted Yu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ted Yu made changes -
        Attachment 9055-v2.txt [ 12594539 ]
        Ted Yu made changes -
        Attachment 9058.patch [ 12594540 ]
        Ted Yu made changes -
        Attachment 9058.patch [ 12594541 ]
        Ted Yu made changes -
        Attachment 9058-v2.patch [ 12594557 ]
        Ted Yu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Ted Yu
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development