Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9054

HBaseAdmin#isTableDisabled() should check table existence before checking zk state.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 0.94.10
    • Fix Version/s: None
    • Component/s: Admin
    • Labels:
      None

      Description

      To avoid compatibility issues with older versions HBaseAdmin#isTableDisabled and HBaseAdmin#isTableEnabled()(The HBASE-8538 fix isTableEnabled.) returning true even if the table state is null. Its also returning true even a table is not present. We should confirm table existence from .META. before checking in zk. If table not present or deleted, then It will throw TableNotFoundException.

        Activity

        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Patch that covers both isTableDisabled() and isTableEnabled() is attached to HBASE-9462

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Patch that covers both isTableDisabled() and isTableEnabled() is attached to HBASE-9462
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Pushing to next month

        Show
        lhofhansl Lars Hofhansl added a comment - Pushing to next month
        Hide
        rajesh23 rajeshbabu added a comment -

        For trunk, can we check for table state znode is present or not, if not present we can throw TableNotFoundException?

        Show
        rajesh23 rajeshbabu added a comment - For trunk, can we check for table state znode is present or not, if not present we can throw TableNotFoundException?
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Looks good to me. Does the same we do in isTableEnabled(...).
        I don't quite remember whether there was a specific reason for this. If nobody speak up, I guess this is good.

        Could you submit a trunk patch?

        Show
        lhofhansl Lars Hofhansl added a comment - Looks good to me. Does the same we do in isTableEnabled(...). I don't quite remember whether there was a specific reason for this. If nobody speak up, I guess this is good. Could you submit a trunk patch?
        Hide
        beneguo Bene Guo added a comment -

        HBASE-9054-94.patch: Patch for 94.

        Will submit trunk patch later.

        Show
        beneguo Bene Guo added a comment - HBASE-9054 -94.patch: Patch for 94. Will submit trunk patch later.
        Hide
        beneguo Bene Guo added a comment -

        Lars HofhanslI will submit a patch today.

        Show
        beneguo Bene Guo added a comment - Lars Hofhansl I will submit a patch today.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Make a patch Bene Guo?

        Show
        lhofhansl Lars Hofhansl added a comment - Make a patch Bene Guo ?

          People

          • Assignee:
            Unassigned
            Reporter:
            beneguo Bene Guo
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development