HBase
  1. HBase
  2. HBASE-9054

HBaseAdmin#isTableDisabled() should check table existence before checking zk state.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 0.94.10
    • Fix Version/s: None
    • Component/s: Admin
    • Labels:
      None

      Description

      To avoid compatibility issues with older versions HBaseAdmin#isTableDisabled and HBaseAdmin#isTableEnabled()(The HBASE-8538 fix isTableEnabled.) returning true even if the table state is null. Its also returning true even a table is not present. We should confirm table existence from .META. before checking in zk. If table not present or deleted, then It will throw TableNotFoundException.

        Activity

        Bene Guo created issue -
        Hide
        Lars Hofhansl added a comment -

        Make a patch Bene Guo?

        Show
        Lars Hofhansl added a comment - Make a patch Bene Guo ?
        Lars Hofhansl made changes -
        Field Original Value New Value
        Fix Version/s 0.94.12 [ 12324790 ]
        Fix Version/s 0.94.11 [ 12324741 ]
        Hide
        Bene Guo added a comment -

        Lars HofhanslI will submit a patch today.

        Show
        Bene Guo added a comment - Lars Hofhansl I will submit a patch today.
        Hide
        Bene Guo added a comment -

        HBASE-9054-94.patch: Patch for 94.

        Will submit trunk patch later.

        Show
        Bene Guo added a comment - HBASE-9054 -94.patch: Patch for 94. Will submit trunk patch later.
        Bene Guo made changes -
        Attachment HBASE-9054-94.patch [ 12596275 ]
        Hide
        Lars Hofhansl added a comment -

        Looks good to me. Does the same we do in isTableEnabled(...).
        I don't quite remember whether there was a specific reason for this. If nobody speak up, I guess this is good.

        Could you submit a trunk patch?

        Show
        Lars Hofhansl added a comment - Looks good to me. Does the same we do in isTableEnabled(...). I don't quite remember whether there was a specific reason for this. If nobody speak up, I guess this is good. Could you submit a trunk patch?
        Hide
        rajeshbabu added a comment -

        For trunk, can we check for table state znode is present or not, if not present we can throw TableNotFoundException?

        Show
        rajeshbabu added a comment - For trunk, can we check for table state znode is present or not, if not present we can throw TableNotFoundException?
        Hide
        Lars Hofhansl added a comment -

        Pushing to next month

        Show
        Lars Hofhansl added a comment - Pushing to next month
        Lars Hofhansl made changes -
        Fix Version/s 0.94.13 [ 12324885 ]
        Fix Version/s 0.94.12 [ 12324790 ]
        Hide
        Ted Yu added a comment -

        Patch that covers both isTableDisabled() and isTableEnabled() is attached to HBASE-9462

        Show
        Ted Yu added a comment - Patch that covers both isTableDisabled() and isTableEnabled() is attached to HBASE-9462
        Ted Yu made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Duplicate [ 3 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.13 [ 12324885 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        46d 15h 33m 1 Ted Yu 11/Sep/13 17:11

          People

          • Assignee:
            Unassigned
            Reporter:
            Bene Guo
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development