HBase
  1. HBase
  2. HBASE-8812

Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.8
    • Fix Version/s: 0.98.0, 0.95.2
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      add a line break for every four zookeeper quorums on the HMaster webUI.

      I don't think this need a test case. just manual testing is enough. I've tested on my testing cluster. everything works well.

      1. screeshot.PNG
        44 kB
        Fengdong Yu
      2. HBASE-8812.patch
        2 kB
        Fengdong Yu

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12589828/HBASE-8812.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.security.access.TestAccessController

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12589828/HBASE-8812.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.access.TestAccessController Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6153//console This message is automatically generated.
        Hide
        Jean-Daniel Cryans added a comment -

        Fixing the title, HBase has only one ensemble (quorum was a misnomer) and an ensemble is made of many ZK servers.

        Show
        Jean-Daniel Cryans added a comment - Fixing the title, HBase has only one ensemble (quorum was a misnomer) and an ensemble is made of many ZK servers.
        Hide
        Ted Yu added a comment -

        Mind attaching screen shot of the new UI showing more than 4 ZK servers ?

        Thanks

        Show
        Ted Yu added a comment - Mind attaching screen shot of the new UI showing more than 4 ZK servers ? Thanks
        Hide
        Fengdong Yu added a comment -

        Mind attaching screen shot of the new UI showing more than 4 ZK servers ?

        Yes. actually I've applied the patch in our prod cluster.
        Screen shot was attached. Thanks.

        Show
        Fengdong Yu added a comment - Mind attaching screen shot of the new UI showing more than 4 ZK servers ? Yes. actually I've applied the patch in our prod cluster. Screen shot was attached. Thanks.
        Hide
        Ted Yu added a comment -

        +1

        Show
        Ted Yu added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590254/screeshot.PNG
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6173//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590254/screeshot.PNG against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6173//console This message is automatically generated.
        Hide
        Fengdong Yu added a comment -

        So can I close this issue?

        Show
        Fengdong Yu added a comment - So can I close this issue?
        Hide
        stack added a comment -

        I applied to trunk and 0.95. Lars Hofhansl you want this fixup for 0.94? Thanks for the patch Fengdong Yu

        Show
        stack added a comment - I applied to trunk and 0.95. Lars Hofhansl you want this fixup for 0.94? Thanks for the patch Fengdong Yu
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4207 (See https://builds.apache.org/job/HBase-TRUNK/4207/)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499060)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers – REVERT MISAPPLICATION (Revision 1499059)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499056)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4207 (See https://builds.apache.org/job/HBase-TRUNK/4207/ ) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499060) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers – REVERT MISAPPLICATION (Revision 1499059) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499056) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        Lars Hofhansl added a comment -

        Yeah let's have it for 0.94 as well. Simple UI only patch.

        Show
        Lars Hofhansl added a comment - Yeah let's have it for 0.94 as well. Simple UI only patch.
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #280 (See https://builds.apache.org/job/hbase-0.95/280/)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499057)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        Hudson added a comment - Integrated in hbase-0.95 #280 (See https://builds.apache.org/job/hbase-0.95/280/ ) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499057) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #157 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/157/)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499057)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #157 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/157/ ) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499057) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #592 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/592/)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499060)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers – REVERT MISAPPLICATION (Revision 1499059)
        HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499056)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #592 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/592/ ) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499060) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers – REVERT MISAPPLICATION (Revision 1499059) HBASE-8812 Avoid a wide line on the HMaster webUI if we have many ZooKeeper servers (Revision 1499056) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        Fengdong Yu added a comment -

        I applied to trunk and 0.95. Lars Hofhansl you want this fixup for 0.94? Thanks for the patch Fengdong Yu

        Thanks Stack, please also update CHANGES.txt, Thanks.

        Show
        Fengdong Yu added a comment - I applied to trunk and 0.95. Lars Hofhansl you want this fixup for 0.94? Thanks for the patch Fengdong Yu Thanks Stack, please also update CHANGES.txt, Thanks.
        Hide
        stack added a comment -

        Fengdong Yu We update CHANGES.txt all in one go, just before release.

        Show
        stack added a comment - Fengdong Yu We update CHANGES.txt all in one go, just before release.

          People

          • Assignee:
            Fengdong Yu
            Reporter:
            Fengdong Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development