Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.9
    • Fix Version/s: 2.0.0, 1.1.0, 0.98.13
    • Component/s: metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Right now we have:

      • queueCallTime
        • exposes the ammount of time that a call is in the queue
      • processCallTime
        • exposes how long a call was processing

      We don't have a stat for total time. It's pretty easy to think that the two metrics might not track together so getting a total time could be useful.

      1. HBASE-8725-r1.patch
        6 kB
        Nate Edel
      2. HBASE-8725-0.98.patch
        8 kB
        Andrew Purtell
      3. HBASE-8275.patch
        7 kB
        Nate Edel

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        93d 18h 16m 1 Nate Edel 26/Mar/15 18:09
        Open Open Patch Available Patch Available
        560d 49m 2 Nate Edel 26/Mar/15 18:09
        Patch Available Patch Available Resolved Resolved
        19m 55s 1 Elliott Clark 26/Mar/15 18:29
        Resolved Resolved Closed Closed
        68d 20h 59m 1 Nick Dimiduk 03/Jun/15 16:28
        Nick Dimiduk made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Nick Dimiduk added a comment -

        Closing issues released in 1.1.0.

        Show
        Nick Dimiduk added a comment - Closing issues released in 1.1.0.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #926 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/926/)
        HBASE-8725 Add total time RPC call metrics (apurtell: rev 4a82713f6e8772e0cbfecdd3944af5766f8fa099)

        • hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        • hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java
        • hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #926 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/926/ ) HBASE-8725 Add total time RPC call metrics (apurtell: rev 4a82713f6e8772e0cbfecdd3944af5766f8fa099) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #973 (See https://builds.apache.org/job/HBase-0.98/973/)
        HBASE-8725 Add total time RPC call metrics (apurtell: rev 4a82713f6e8772e0cbfecdd3944af5766f8fa099)

        • hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java
        • hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #973 (See https://builds.apache.org/job/HBase-0.98/973/ ) HBASE-8725 Add total time RPC call metrics (apurtell: rev 4a82713f6e8772e0cbfecdd3944af5766f8fa099) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        Andrew Purtell made changes -
        Fix Version/s 0.98.13 [ 12329558 ]
        Hide
        Andrew Purtell added a comment -

        We can take new metrics on 0.98 branch. Picked to 0.98 with Hadoop 1 support added.

        Show
        Andrew Purtell added a comment - We can take new metrics on 0.98 branch. Picked to 0.98 with Hadoop 1 support added.
        Andrew Purtell made changes -
        Attachment HBASE-8725-0.98.patch [ 12729838 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #6307 (See https://builds.apache.org/job/HBase-TRUNK/6307/)
        HBASE-8725 Add total time RPC call metrics (eclark: rev 18256fc9544866fc7182dfc5dd9d73b8cef02d66)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java
        • hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #6307 (See https://builds.apache.org/job/HBase-TRUNK/6307/ ) HBASE-8725 Add total time RPC call metrics (eclark: rev 18256fc9544866fc7182dfc5dd9d73b8cef02d66) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-1.1 #326 (See https://builds.apache.org/job/HBase-1.1/326/)
        HBASE-8725 Add total time RPC call metrics (eclark: rev 797eee33ab2367805b99984aceea15258a95f766)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java
        • hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-1.1 #326 (See https://builds.apache.org/job/HBase-1.1/326/ ) HBASE-8725 Add total time RPC call metrics (eclark: rev 797eee33ab2367805b99984aceea15258a95f766) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
        Elliott Clark made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.0 [ 12327188 ]
        Fix Version/s 1.1.0 [ 12329043 ]
        Resolution Fixed [ 1 ]
        Hide
        Elliott Clark added a comment -

        Thanks Nate Edel

        Show
        Elliott Clark added a comment - Thanks Nate Edel
        Nate Edel made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707382/HBASE-8725-r1.patch
        against master branch at commit 69f6a2e7b44d33e01866928672700cde1366f429.
        ATTACHMENT ID: 12707382

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//testReport/
        Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//artifact/patchprocess/newFindbugsWarnings.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707382/HBASE-8725-r1.patch against master branch at commit 69f6a2e7b44d33e01866928672700cde1366f429. ATTACHMENT ID: 12707382 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13440//console This message is automatically generated.
        Nate Edel made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Nate Edel made changes -
        Attachment HBASE-8725-r1.patch [ 12707382 ]
        Hide
        Nate Edel added a comment -

        Rebased patch. Need to let tests run.

        Show
        Nate Edel added a comment - Rebased patch. Need to let tests run.
        Hide
        Elliott Clark added a comment -

        +1 sorry this was missed.

        Show
        Elliott Clark added a comment - +1 sorry this was missed.
        Hide
        stack added a comment -

        Nice. +1. Add release note on new metric.

        Show
        stack added a comment - Nice. +1. Add release note on new metric.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12688743/HBASE-8275.patch
        against master branch at commit 83db450fc634358b4f67cf9b8605bf7b74308365.
        ATTACHMENT ID: 12688743

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688743/HBASE-8275.patch against master branch at commit 83db450fc634358b4f67cf9b8605bf7b74308365. ATTACHMENT ID: 12688743 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12196//console This message is automatically generated.
        Elliott Clark made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.98.9 [ 12328795 ]
        Nate Edel made changes -
        Attachment HBASE-8275.patch [ 12688743 ]
        Elliott Clark made changes -
        Field Original Value New Value
        Assignee Elliott Clark [ eclark ] Nate Edel [ nkedel ]
        Elliott Clark created issue -

          People

          • Assignee:
            Nate Edel
            Reporter:
            Elliott Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development