HBase
  1. HBase
  2. HBASE-8664

Small fix ups for memory size outputs in UI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.1
    • Component/s: UI
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This issue goes in the 'polish' category. On regionserver ui, we were listing raw bytes for heap size, memstore size, etc. I put in place StringUtils.humanReadableInt (looked to see if bootstrap could do it for us but doesn't seem so, not w/o plugin). I then made all the megabytes and kilobytes match StringUtils.humanReadableInt with its 'm' instead of 'MB' and 'k' instead of KB. Removed a stray KB that was in the wrong place too.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        11d 19h 36m 1 stack 11/Jun/13 19:53
        Resolved Resolved Closed Closed
        104d 14m 1 stack 23/Sep/13 20:08
        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #564 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/564/)
        HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491902)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon
        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #564 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/564/ ) HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491902) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #129 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/129/)
        HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491903)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon
        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #129 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/129/ ) HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491903) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4173 (See https://builds.apache.org/job/HBase-TRUNK/4173/)
        HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491902)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon
        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4173 (See https://builds.apache.org/job/HBase-TRUNK/4173/ ) HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491902) Result = SUCCESS stack : Files : /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #236 (See https://builds.apache.org/job/hbase-0.95/236/)
        HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491903)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon
        • /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Show
        Hudson added a comment - Integrated in hbase-0.95 #236 (See https://builds.apache.org/job/hbase-0.95/236/ ) HBASE-8664 Small fix ups for memory size outputs in UI (Revision 1491903) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon /hbase/branches/0.95/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        stack made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.98.0 [ 12323143 ]
        Resolution Fixed [ 1 ]
        Hide
        stack added a comment -

        Committed to trunk and 0.95. Thanks for review Enis.

        Show
        stack added a comment - Committed to trunk and 0.95. Thanks for review Enis.
        Hide
        Enis Soztutar added a comment -

        +1 on commit. We can address later.

        Show
        Enis Soztutar added a comment - +1 on commit. We can address later.
        Hide
        stack added a comment -

        Enis Soztutar

        Not sure this is better readable. Should we instead wrap humanReadablleInt to uppercase K/M/G, and append B ourselves?

        If we were going to go this route, I'd just do up our own humanReadableInt.

        Mind if I commit this for time being?

        Show
        stack added a comment - Enis Soztutar Not sure this is better readable. Should we instead wrap humanReadablleInt to uppercase K/M/G, and append B ourselves? If we were going to go this route, I'd just do up our own humanReadableInt. Mind if I commit this for time being?
        Hide
        Enis Soztutar added a comment -

        'm' instead of 'MB' and 'k' instead of KB

        Not sure this is better readable. Should we instead wrap humanReadablleInt to uppercase K/M/G, and append B ourselves?

        Removed a stray KB that was in the wrong place too.

        Yeah, I noticed that too.
        Good on you Stack(™)

        Show
        Enis Soztutar added a comment - 'm' instead of 'MB' and 'k' instead of KB Not sure this is better readable. Should we instead wrap humanReadablleInt to uppercase K/M/G, and append B ourselves? Removed a stray KB that was in the wrong place too. Yeah, I noticed that too. Good on you Stack(™)
        stack made changes -
        Field Original Value New Value
        Attachment ui.txt [ 12585501 ]
        Hide
        stack added a comment -

        A few small fixes.

        Show
        stack added a comment - A few small fixes.
        stack created issue -

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development