[HBASE-8582] Possible NullPointerException in ZKInterProcessLockBase#visitLocks

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.98.0, 0.95.1
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 21/May/13 00:19
• Updated: 23/Sep/13 19:08
• Resolved: 21/May/13 02:01

Description

Running test suite on hadoop 2.0 I saw the following test failure:

testErrorReporter(org.apache.hadoop.hbase.util.TestHBaseFsck)  Time elapsed: 0.003 sec  <<< ERROR!
java.lang.NullPointerException
        at org.apache.hadoop.hbase.zookeeper.lock.ZKInterProcessLockBase.visitLocks(ZKInterProcessLockBase.java:426)
        at org.apache.hadoop.hbase.master.TableLockManager$ZKTableLockManager.visitAllLocks(TableLockManager.java:386)
        at org.apache.hadoop.hbase.util.hbck.TableLockChecker.checkTableLocks(TableLockChecker.java:76)
        at org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixTableLocks(HBaseFsck.java:2480)
        at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:460)
        at org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.doFsck(HbckTestingUtil.java:65)
        at org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.doFsck(HbckTestingUtil.java:41)
        at org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.doFsck(HbckTestingUtil.java:36)
        at org.apache.hadoop.hbase.util.TestHBaseFsck.testErrorReporter(TestHBaseFsck.java:1868)

Here is related code:

  public void visitLocks(MetadataHandler handler) throws IOException {
    List<String> children;
    try {
      children = ZKUtil.listChildrenNoWatch(zkWatcher, parentLockNode);

Looks like children was null.