Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8555

FilterList correctness may be affected by random ordering of sub-filter(list)

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.94.3
    • 0.98.0, 0.95.1, 0.94.9
    • Filters
    • None
    • Reviewed

    Description

      say, ther're 10 rows, column value is i%2:
      row0 0
      row1 1
      row2 0
      row3 1
      row4 0
      row5 1
      row6 0
      row7 1
      row8 0
      row9 1

      1: filter : row filter > row4 ===> row5 row6 row7 row8 row9
      2: subFilterList: row filter <= row4 && column==0 ===> row0 row2 row4
      3.1 filterlist[expected] filter || subFilterList ===> row0 row2 row4 row5 row6 row7 row8 row9
      3.2 filterlist[BUGON!] subFilterList || filter ===> row0 row1 row2 row3 row4 row5 row6 row7 row8 row9
      (Please refer to the new testNestedFilterListWithSCVF case)

      It was found when i managed to transform the following SQL into HBase scan statement:
      select xxx from xxx where (pk <= xxx and column1 = xxx) or pk > xxx

      My finding is that we had an assumption for filter methods call sequence:
      e.g. filterRowKey() should be called before filterKeyValue().
      and the orignial filterList.filterRowKey impl broke it due to fast short-circuit returning.

      Attachments

        1. 8555-trunk-v1.txt
          7 kB
          Ted Yu
        2. HBASE-8555-0.94.txt
          7 kB
          Liang Xie
        3. HBASE-8555-0.94-v2.txt
          7 kB
          Liang Xie
        4. HBASE-8555-0.94-v3.txt
          7 kB
          Liang Xie

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            xieliang007 Liang Xie
            xieliang007 Liang Xie
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment