HBase
  1. HBase
  2. HBASE-8533

HBaseAdmin does not ride over cluster restart

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.98.0, 0.95.0
    • Fix Version/s: 2.0.0
    • Component/s: Client
    • Labels:
      None

      Description

      For Restful servlet (org.apache.hadoop.hbase.rest.Main (0.94), org.apache.hadoop.hbase.rest.RESTServer (trunk)) on Jetty, we need to first explicitly start the service (% ./bin/hbase-daemon.sh start rest -p 8000 ) for application running. Here is a scenario, sometimes, HBase cluster are stopped/started for maintanence, but rest is a seperated standalone process, which binds the HBaseAdmin at construction method.
      HBase stop/start cause this binding lost for existing rest servlet. Rest servlet still exist to trying on old bound HBaseAdmin until a long time duration later with an "Unavailable" caught via an IOException caught in
      such as RootResource.

      Could we pairwise the HBase service with HBase rest service with some start/stop options? since seems no reason to still keep the rest servlet process after HBase stopped? When HBase restarts, original rest service could not resume to bind to the new HBase service via its old HBaseAdmin reference?
      So may we stop the rest when hbase stopped, or even if hbase was killed by acident, restart hbase with rest option could detect the old rest process, kill it and start to bind a new one?

      From this point of view, application rely on rest api in previous scenario could immediately detect it when setting up http connection session instead of wasting a long time to fail back from IOException with "Unavailable" from rest servlet.

      Put current options from the discussion history here from Andrew, Stack and Jean-Daniel,
      1) create an HBaseAdmin on demand in rest servlet instead of keeping singleton instance; (another possible enhancement for HBase client: automatic reconnection of an open HBaseAdmin handle after a cluster bounce?)
      2) pairwise the rest webapp with hbase webui so the rest is always on with HBase serive;
      3) add an option for rest service (such as HBASE_MANAGES_REST) in hbase-env.sh, set HBASE_MANAGES_REST to true, the scripts will start/stop the REST server.

      1. 8533-0.95-v1.patch
        3 kB
        Julian Zhou
      2. 8533-trunk-v1.patch
        3 kB
        Ted Yu
      3. hbase-8533-trunk-v0.patch
        3 kB
        Julian Zhou

        Issue Links

          Activity

          Hide
          Andrew Purtell added a comment -

          Option 1 seems best.

          Option 3 is a REST server at every RegionServer ? I don't think that is a typical deploy.

          Not sure about option 2 either. That would be an embedding of an HBase client on the server wherever a REST servlet is deployed, and lots of crosstalk among servers as a result. Or, we could reboot REST semantics and do the WebHDFS thing of redirecting clients: requests for one region's data via REST would be redirected to the other embedded REST servlet where the region is local. Wildcards and scanners in the current API address more than one region. Would we redirect at every region boundary? That might work for scanners but wildcards in paths could no longer be supported (these are "mini-scans") because they have to return all the results in one HTTP transaction, there's no place for a redirect at a boundary crossing. Anyway, as I mention, introducing redirects is a reboot of REST, it wouldn't be backwards compatible.

          Show
          Andrew Purtell added a comment - Option 1 seems best. Option 3 is a REST server at every RegionServer ? I don't think that is a typical deploy. Not sure about option 2 either. That would be an embedding of an HBase client on the server wherever a REST servlet is deployed, and lots of crosstalk among servers as a result. Or, we could reboot REST semantics and do the WebHDFS thing of redirecting clients: requests for one region's data via REST would be redirected to the other embedded REST servlet where the region is local. Wildcards and scanners in the current API address more than one region. Would we redirect at every region boundary? That might work for scanners but wildcards in paths could no longer be supported (these are "mini-scans") because they have to return all the results in one HTTP transaction, there's no place for a redirect at a boundary crossing. Anyway, as I mention, introducing redirects is a reboot of REST, it wouldn't be backwards compatible.
          Hide
          Julian Zhou added a comment -

          For the topic of HBaseAdmin riding over cluster restart, looks like the main logic is in HConnectionManager.
          For this rest scenario, at the very first restart of hbase service after rest started (no actual hbase admin rpc call happened yet), #isKeepAliveMasterConnectedAndRunning return false since MasterMonitorServiceState's stub is null (has not been built from protobuf via a RPC operation), otherwise MasterMonitorServiceState.isMasterRunning() will throw protobuf's ServiceException, then will make new protobuf BlockingStub via #makeStub().

          There is 2 rounds of retries for HBaseAdmin's HConnection trying to invoke master services if master is not running:
          1) RecoverableZooKeeper retries 3 times if ZooKeeperWatcher met KeeperException.CONNECTIONLOSS;
          2) in #makeStub(), there are 10 getMaster retries if any exception caught from ZooKeeper connection.

          I just tried to modify HConnectionImplementation#checkIfBaseNodeAvailable to throw the KeeperException with CONNECTIONLOSS out caught from "ZKUtil.checkExists" instead of throwing MasterNotRunningException out, then in #makeStub, adding this part
          ...
          try

          { Thread.sleep(pauseTime); }

          catch (InterruptedException e)

          { Thread.currentThread().interrupt(); throw new RuntimeException( "Thread was interrupted while trying to connect to master.", e); }

          // --------- added for reconnecting to ZK due to connection loss caused by master restart – Begin
          if (exceptionCaught instanceof KeeperException) {
          if (((KeeperException) exceptionCaught).code() == KeeperException.Code.CONNECTIONLOSS) {
          try

          { getKeepAliveZooKeeperWatcher().reconnectAfterExpiration(); }

          catch (Exception e)

          { LOG.error("Encountered unexpected exception while trying " + "to recover from ZooKeeper connection loss.", e); }

          }
          }
          // --------- added for reconnecting to ZK due to connection loss caused by master restart – End

          } else {
          // Enough tries, we stop now
          ...

          Then rest process could get reconnect to zk service via the same configuration after master restarted.

          Show
          Julian Zhou added a comment - For the topic of HBaseAdmin riding over cluster restart, looks like the main logic is in HConnectionManager. For this rest scenario, at the very first restart of hbase service after rest started (no actual hbase admin rpc call happened yet), #isKeepAliveMasterConnectedAndRunning return false since MasterMonitorServiceState's stub is null (has not been built from protobuf via a RPC operation), otherwise MasterMonitorServiceState.isMasterRunning() will throw protobuf's ServiceException, then will make new protobuf BlockingStub via #makeStub(). There is 2 rounds of retries for HBaseAdmin's HConnection trying to invoke master services if master is not running: 1) RecoverableZooKeeper retries 3 times if ZooKeeperWatcher met KeeperException.CONNECTIONLOSS; 2) in #makeStub(), there are 10 getMaster retries if any exception caught from ZooKeeper connection. I just tried to modify HConnectionImplementation#checkIfBaseNodeAvailable to throw the KeeperException with CONNECTIONLOSS out caught from "ZKUtil.checkExists" instead of throwing MasterNotRunningException out, then in #makeStub, adding this part ... try { Thread.sleep(pauseTime); } catch (InterruptedException e) { Thread.currentThread().interrupt(); throw new RuntimeException( "Thread was interrupted while trying to connect to master.", e); } // --------- added for reconnecting to ZK due to connection loss caused by master restart – Begin if (exceptionCaught instanceof KeeperException) { if (((KeeperException) exceptionCaught).code() == KeeperException.Code.CONNECTIONLOSS) { try { getKeepAliveZooKeeperWatcher().reconnectAfterExpiration(); } catch (Exception e) { LOG.error("Encountered unexpected exception while trying " + "to recover from ZooKeeper connection loss.", e); } } } // --------- added for reconnecting to ZK due to connection loss caused by master restart – End } else { // Enough tries, we stop now ... Then rest process could get reconnect to zk service via the same configuration after master restarted.
          Hide
          Ted Yu added a comment -

          @Julian:
          Can you make a patch based on above analysis ?

          Thanks

          Show
          Ted Yu added a comment - @Julian: Can you make a patch based on above analysis ? Thanks
          Hide
          Julian Zhou added a comment -

          Hi Ted Yu, looks like this will benefit all clients using HBaseAdmin besides rest to ride over cluster restart. I will attach the patch after I've done local testing. And just now, there are some new commits changing HConnectionManager, added "Registry" for cluster information. I need to base on that. Thanks~

          Show
          Julian Zhou added a comment - Hi Ted Yu , looks like this will benefit all clients using HBaseAdmin besides rest to ride over cluster restart. I will attach the patch after I've done local testing. And just now, there are some new commits changing HConnectionManager, added "Registry" for cluster information. I need to base on that. Thanks~
          Hide
          Julian Zhou added a comment -

          Lars Hofhansl, looks like this is similar with the issue met in 0.94 as described in HBASE-6523.

          Show
          Julian Zhou added a comment - Lars Hofhansl , looks like this is similar with the issue met in 0.94 as described in HBASE-6523 .
          Hide
          Julian Zhou added a comment -

          Using rest client to recreate, there are 2 scenarios, steps could be:
          – Scenario A: request after cluster restart
          1) start cluster;
          2) start rest at a port 8000;
          3) stop the whole cluster (including zk);
          4) start the whole cluster again;
          5) request http://<ip>:8000/ to get table list. ==> waiting for 10 getMaster retry (HConnectionManager), each retry with 3 zk connection retries by RecoverableZooKeeper. 10 getMaster retry failed, then "Unavailable" as rest response;

          – Scenario B: rest request between stop and start cluster
          1) start cluster;
          2) start rest at a port 8000;
          3) stop the whole cluster (including zk);
          4) request http://<ip>:8000/ to get table list ==> same retry logic as A..
          5) start the whole cluster again. ==> rest in 4) will kill old zk connection for HConnection and rebuild new zk connection:
          -------------
          2013-05-16 17:04:09,037 INFO [79168696@qtp-2077588437-0] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper: Closing dead ZooKeeper connection, session was: 0x0
          2013-05-16 17:04:09,037 DEBUG [79168696@qtp-2077588437-0] org.apache.zookeeper.ZooKeeper: Closing session: 0x0
          2013-05-16 17:04:09,037 DEBUG [79168696@qtp-2077588437-0] org.apache.zookeeper.ClientCnxn: Closing client for session: 0x0
          2013-05-16 17:04:09,131 DEBUG [79168696@qtp-2077588437-0] org.apache.zookeeper.ClientCnxn: Disconnecting client for session: 0x0
          2013-05-16 17:04:09,131 INFO [79168696@qtp-2077588437-0] org.apache.zookeeper.ZooKeeper: Session: 0x0 closed
          2013-05-16 17:04:09,131 INFO [79168696@qtp-2077588437-0] org.apache.zookeeper.ZooKeeper: Initiating client connection, connectString=localhost:2181 sessionTimeout=180000 watcher=hconnection-0x43724372-0x13eac8abdbc0003-0x13eac917e7e0003-0x13eac917e7e0004
          -------------
          Then, response successfully with table list.

          Show
          Julian Zhou added a comment - Using rest client to recreate, there are 2 scenarios, steps could be: – Scenario A: request after cluster restart 1) start cluster; 2) start rest at a port 8000; 3) stop the whole cluster (including zk); 4) start the whole cluster again; 5) request http://<ip>:8000/ to get table list. ==> waiting for 10 getMaster retry (HConnectionManager), each retry with 3 zk connection retries by RecoverableZooKeeper. 10 getMaster retry failed, then "Unavailable" as rest response; – Scenario B: rest request between stop and start cluster 1) start cluster; 2) start rest at a port 8000; 3) stop the whole cluster (including zk); 4) request http://<ip>:8000/ to get table list ==> same retry logic as A.. 5) start the whole cluster again. ==> rest in 4) will kill old zk connection for HConnection and rebuild new zk connection: ------------- 2013-05-16 17:04:09,037 INFO [79168696@qtp-2077588437-0] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper: Closing dead ZooKeeper connection, session was: 0x0 2013-05-16 17:04:09,037 DEBUG [79168696@qtp-2077588437-0] org.apache.zookeeper.ZooKeeper: Closing session: 0x0 2013-05-16 17:04:09,037 DEBUG [79168696@qtp-2077588437-0] org.apache.zookeeper.ClientCnxn: Closing client for session: 0x0 2013-05-16 17:04:09,131 DEBUG [79168696@qtp-2077588437-0] org.apache.zookeeper.ClientCnxn: Disconnecting client for session: 0x0 2013-05-16 17:04:09,131 INFO [79168696@qtp-2077588437-0] org.apache.zookeeper.ZooKeeper: Session: 0x0 closed 2013-05-16 17:04:09,131 INFO [79168696@qtp-2077588437-0] org.apache.zookeeper.ZooKeeper: Initiating client connection, connectString=localhost:2181 sessionTimeout=180000 watcher=hconnection-0x43724372-0x13eac8abdbc0003-0x13eac917e7e0003-0x13eac917e7e0004 ------------- Then, response successfully with table list.
          Hide
          Julian Zhou added a comment -

          A correction for previous comment: about scenario B, that's the behavior with the patch, if without patch, rest will also get "Unavailable" after 10 getMaster retries finally.

          Show
          Julian Zhou added a comment - A correction for previous comment: about scenario B, that's the behavior with the patch, if without patch, rest will also get "Unavailable" after 10 getMaster retries finally.
          Hide
          Ted Yu added a comment -
          +                      getKeepAliveZooKeeperWatcher().reconnectAfterExpiration();
          +                    } catch (Exception e) {
          +                      LOG.error("Encountered unexpected exception while trying "
          +                          + "to recover from ZooKeeper connection loss.", e);
          

          reconnectAfterExpiration() throws IOE and InterruptedException. Please catch them individually.

          Show
          Ted Yu added a comment - + getKeepAliveZooKeeperWatcher().reconnectAfterExpiration(); + } catch (Exception e) { + LOG.error( "Encountered unexpected exception while trying " + + "to recover from ZooKeeper connection loss." , e); reconnectAfterExpiration() throws IOE and InterruptedException. Please catch them individually.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12584821/8533-trunk-v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12584821/8533-trunk-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5830//console This message is automatically generated.
          Hide
          Julian Zhou added a comment -

          Ted Yu thanks, the same patch also works for 0.95, which is with new refactored HConnectionManager logic.

          Show
          Julian Zhou added a comment - Ted Yu thanks, the same patch also works for 0.95, which is with new refactored HConnectionManager logic.
          Hide
          Julian Zhou added a comment -

          Hi, Andrew Purtell, could you help review the patch? The logic for trunk and 0.95 are the same. Thanks~

          Show
          Julian Zhou added a comment - Hi, Andrew Purtell , could you help review the patch? The logic for trunk and 0.95 are the same. Thanks~
          Hide
          Julian Zhou added a comment -

          Andrew Purtell, the patch does not change the logic to create an HBaseAdmin on demand, still keep the singleton mode for rest servlet client. Just recovered the zk connection from the 1st failure of HConnectionManager's getMaster retry to make HBaseAdmin ride over cluster restart.

          Show
          Julian Zhou added a comment - Andrew Purtell , the patch does not change the logic to create an HBaseAdmin on demand, still keep the singleton mode for rest servlet client. Just recovered the zk connection from the 1st failure of HConnectionManager's getMaster retry to make HBaseAdmin ride over cluster restart.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5833//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          8533-0.95-v1 looks fine to me but it's a patch to hbase-client, not REST. Ping stack

          Show
          Andrew Purtell added a comment - 8533-0.95-v1 looks fine to me but it's a patch to hbase-client, not REST. Ping stack
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8177//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch
          against trunk revision .
          ATTACHMENT ID: 12584868

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10784//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch against trunk revision . ATTACHMENT ID: 12584868 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10784//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          Would the retrying in HBASE-12072 help in this case?

          Show
          Enis Soztutar added a comment - Would the retrying in HBASE-12072 help in this case?
          Hide
          Sean Busbey added a comment -

          bump. Julian Zhou are you still interested in working on this?

          Show
          Sean Busbey added a comment - bump. Julian Zhou are you still interested in working on this?

            People

            • Assignee:
              Julian Zhou
              Reporter:
              Julian Zhou
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:

                Development