Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8532

[Webui] Bootstrap based webui compatibility for IE and also fix some page format issues.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.95.0, 0.95.2
    • Fix Version/s: 0.98.0, 0.95.2
    • Component/s: UI
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-7425 brings bootstrap based webui to hbase. While trying on trunk version, Firefox works well, but IE 8/9 layout and style look strange due to compatibility issue. Add "<!DOCTYPE html ...>" at the beginning of all jamon html/jsp templates to fix it.

      Seems HBase-2110 had a work to comment out the DOCTYPE for all .jsp to make the browser run the pages in Quirks mode (http://en.wikipedia.org/wiki/Quirks_mode) due to jetty issue at that time?

      To support the compatibility of webui across browsers (IE/Firefox/Chrome, etc.), there are some guidelines for choosing rendering the page under standard mode or quirk mode:
      http://en.wikipedia.org/wiki/Quirks_mode
      http://hsivonen.iki.fi/doctype/

      According to document, "<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">" has the most extensive compatibility even for HTML 5. According to my test, add this could make webui works in IE (standard mode), while Firefox could not work well with styles. Looks like if in Firefox, we still need the quirk mode (no DOCTYPE declaration).

      So just adding conditional DOCTYPE declaration for IE,
      <!--[if IE]>
      <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
      <![endif]-->
      this could make webui works for both IE and Firefox, also for Chrome and other browsers.

        Attachments

        1. webui-IE-error-&apos;.png
          41 kB
          Julian Zhou
        2. webui-IE-error.png
          43 kB
          Julian Zhou
        3. hbase-8532_v0.patch
          6 kB
          Julian Zhou
        4. 8532-trunk-0.95-v1.patch
          7 kB
          Julian Zhou

          Issue Links

            Activity

              People

              • Assignee:
                julian.zhou Julian Zhou
                Reporter:
                julian.zhou Julian Zhou
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: