[HBASE-8465] Auto-drop rollback snapshot for snapshot restore

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.98.0, 0.96.1
• Hadoop Flags: Reviewed
• Assignee: Matteo Bertozzi
• Reporter: Ted Yu
• Created: 30/Apr/13 09:04
• Updated: 16/Dec/13 18:46
• Resolved: 25/Nov/13 18:10

Description

Below is an excerpt from snapshot restore javadoc:

   * Restore the specified snapshot on the original table. (The table must be disabled)
   * Before restoring the table, a new snapshot with the current table state is created.
   * In case of failure, the table will be rolled back to the its original state.

We can improve the handling of rollbackSnapshot in two ways:

1. give better name to the rollbackSnapshot (adding

'-for-rollback-'

). Currently the name is of the form:
String rollbackSnapshot = snapshotName + "-" + EnvironmentEdgeManager.currentTimeMillis();

2. drop rollbackSnapshot at the end of restoreSnapshot() if the restore is successful. We can introduce new config param, named 'hbase.snapshot.restore.drop.rollback', to keep compatibility with current behavior.

Issue Links

• supercedes: HBASE-8385 [SNAPSHOTS]: Restore fails to restore snapshot of a deleted table