HBase
  1. HBase
  2. HBASE-8427

Apache Rat is incorrectly excluding test source files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.92.1, 0.94.0
    • Fix Version/s: 0.98.0, 0.94.7, 0.95.1
    • Component/s: build
    • Labels:
      None

      Description

      HBASE-5524 added **/test/** as a rat exclude. This unfortunately excludes directories like hbase-it/src/test/* from the rat checks and has allowed a few unit tests to get in without proper licenses.

      Tightening it to only the directory HBASE-5524 was concerned about (and fixing files with non-compliant licenses)

      1. 0001-HBASE-8427-rat-fixes-for-0.94.patch
        5 kB
        Jonathan Hsieh
      2. hbase-8427.patch
        0.4 kB
        Jonathan Hsieh

        Issue Links

          Activity

          Hide
          Jonathan Hsieh added a comment -

          checking to see if we need to have exclusions at all for

          */test/**
          ./test/**
          
          Show
          Jonathan Hsieh added a comment - checking to see if we need to have exclusions at all for */test/** ./test/**
          Hide
          Jonathan Hsieh added a comment -

          Found that TestMetricsWALSourceImpl doesn't have license as well – from 0.95 and on. Filing a separate quick issue for that commit to 0.95 and trunk.

          Show
          Jonathan Hsieh added a comment - Found that TestMetricsWALSourceImpl doesn't have license as well – from 0.95 and on. Filing a separate quick issue for that commit to 0.95 and trunk.
          Hide
          Jonathan Hsieh added a comment - - edited

          Ran mvn test and no ./test/** or hbase-*/test/** files appeared. Thus the test exclude line is not needed anymore.

          Show
          Jonathan Hsieh added a comment - - edited Ran mvn test and no ./test/** or hbase-*/test/** files appeared. Thus the test exclude line is not needed anymore.
          Hide
          Jonathan Hsieh added a comment -

          trivial patch.

          Show
          Jonathan Hsieh added a comment - trivial patch.
          Hide
          Jonathan Hsieh added a comment -

          0.94 needs test/**, and has 4 files that are in violation:

          src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
          src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java
          src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java

          Show
          Jonathan Hsieh added a comment - 0.94 needs test/** , and has 4 files that are in violation: src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          Hide
          Jonathan Hsieh added a comment -

          fror the 0.94 version, attached as a git format-patch generated patch since an empty file is deleted.

          Show
          Jonathan Hsieh added a comment - fror the 0.94 version, attached as a git format-patch generated patch since an empty file is deleted.
          Hide
          Jonathan Hsieh added a comment -

          you can quickly verfiy by running

          mvn apache-rat:check
          find -name rat.txt | xargs less
          
          Show
          Jonathan Hsieh added a comment - you can quickly verfiy by running mvn apache-rat:check find -name rat.txt | xargs less
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12580424/0001-HBASE-8427-rat-fixes-for-0.94.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 14 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5434//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580424/0001-HBASE-8427-rat-fixes-for-0.94.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 14 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5434//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          +1 on patch

          Show
          Lars Hofhansl added a comment - +1 on patch
          Hide
          Jonathan Hsieh added a comment -

          committed to 0.94 and trunk.

          Show
          Jonathan Hsieh added a comment - committed to 0.94 and trunk.
          Hide
          Jonathan Hsieh added a comment -

          and to 0.95 branch.

          Show
          Jonathan Hsieh added a comment - and to 0.95 branch.
          Hide
          stack added a comment -

          +1 on patch. Thanks Jon.

          Show
          stack added a comment - +1 on patch. Thanks Jon.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #4079 (See https://builds.apache.org/job/HBase-TRUNK/4079/)
          HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471808)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #4079 (See https://builds.apache.org/job/HBase-TRUNK/4079/ ) HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471808) Result = FAILURE jmhsieh : Files : /hbase/trunk/pom.xml
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95-on-hadoop2 #80 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/80/)
          HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471795)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.95/pom.xml
          Show
          Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #80 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/80/ ) HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471795) Result = FAILURE jmhsieh : Files : /hbase/branches/0.95/pom.xml
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #510 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/510/)
          HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471808)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #510 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/510/ ) HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471808) Result = FAILURE jmhsieh : Files : /hbase/trunk/pom.xml
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #967 (See https://builds.apache.org/job/HBase-0.94/967/)
          HBASE-8427 Apache rat is incorrectly excluding test source files (Revision 1471794)

          Result = SUCCESS
          jmhsieh :
          Files :

          • /hbase/branches/0.94/pom.xml
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #967 (See https://builds.apache.org/job/HBase-0.94/967/ ) HBASE-8427 Apache rat is incorrectly excluding test source files (Revision 1471794) Result = SUCCESS jmhsieh : Files : /hbase/branches/0.94/pom.xml /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95 #162 (See https://builds.apache.org/job/hbase-0.95/162/)
          HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471795)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.95/pom.xml
          Show
          Hudson added a comment - Integrated in hbase-0.95 #162 (See https://builds.apache.org/job/hbase-0.95/162/ ) HBASE-8427 Apache Rat is incorrectly excluding test source files (Revision 1471795) Result = FAILURE jmhsieh : Files : /hbase/branches/0.95/pom.xml
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #141 (See https://builds.apache.org/job/HBase-0.94-security/141/)
          HBASE-8427 Apache rat is incorrectly excluding test source files (Revision 1471794)

          Result = FAILURE
          jmhsieh :
          Files :

          • /hbase/branches/0.94/pom.xml
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #141 (See https://builds.apache.org/job/HBase-0.94-security/141/ ) HBASE-8427 Apache rat is incorrectly excluding test source files (Revision 1471794) Result = FAILURE jmhsieh : Files : /hbase/branches/0.94/pom.xml /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java

            People

            • Assignee:
              Jonathan Hsieh
              Reporter:
              Jonathan Hsieh
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development