HBase
  1. HBase
  2. HBASE-8334

Enable essential column family support by default

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      0.96notable

      Description

      Essential column family support has gone through several iterations of refinement.
      We should enable this feature by default.

      1. 8334.txt
        0.8 kB
        Ted Yu

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #497 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/497/)
          HBASE-8334 Enable essential column family support by default (Revision 1467536)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #497 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/497/ ) HBASE-8334 Enable essential column family support by default (Revision 1467536) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #4060 (See https://builds.apache.org/job/HBase-TRUNK/4060/)
          HBASE-8334 Enable essential column family support by default (Revision 1467536)

          Result = SUCCESS
          tedyu :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #4060 (See https://builds.apache.org/job/HBase-TRUNK/4060/ ) HBASE-8334 Enable essential column family support by default (Revision 1467536) Result = SUCCESS tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95-on-hadoop2 #67 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/67/)
          HBASE-8334 Enable essential column family support by default (Revision 1467537)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          Show
          Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #67 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/67/ ) HBASE-8334 Enable essential column family support by default (Revision 1467537) Result = FAILURE tedyu : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          Hide
          Ted Yu added a comment -

          Integrated to 0.95 and trunk.

          Thanks for the reviews, Lars and Sergey.

          Show
          Ted Yu added a comment - Integrated to 0.95 and trunk. Thanks for the reviews, Lars and Sergey.
          Hide
          Sergey Shelukhin added a comment -

          +1

          Show
          Sergey Shelukhin added a comment - +1
          Hide
          Lars Hofhansl added a comment -

          MVCC should handle that. I.e. nothing is removed of there a scanner older than the memstoreTS and scanner won't see newer KVs.

          +1 on patch for 0.95 and 0.98.
          Let's leave it optional/default-off for 0.94.

          Show
          Lars Hofhansl added a comment - MVCC should handle that. I.e. nothing is removed of there a scanner older than the memstoreTS and scanner won't see newer KVs. +1 on patch for 0.95 and 0.98. Let's leave it optional/default-off for 0.94.
          Hide
          Ted Yu added a comment -

          I briefly went over HBASE-5416 but didn't seem to find discussion w.r.t. rows that never existed in rare cases

          Can you post a link ?

          Thanks

          Show
          Ted Yu added a comment - I briefly went over HBASE-5416 but didn't seem to find discussion w.r.t. rows that never existed in rare cases Can you post a link ? Thanks
          Hide
          Sergey Shelukhin added a comment -

          I think we were discussing that this can produce rows that never existed in rare cases (when the value changes for row that you scan)? Or would MVCC prevent that?
          +1 if MVCC prevents that, otherwise it seems that requests/users should specify it explicitly.

          Show
          Sergey Shelukhin added a comment - I think we were discussing that this can produce rows that never existed in rare cases (when the value changes for row that you scan)? Or would MVCC prevent that? +1 if MVCC prevents that, otherwise it seems that requests/users should specify it explicitly.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12578419/8334.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12578419/8334.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5290//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          @Jon:
          You're right. This was not intended for 0.94

          Show
          Ted Yu added a comment - @Jon: You're right. This was not intended for 0.94
          Hide
          Jonathan Hsieh added a comment -

          For which versions? I'm fine with 95/98. If you want to do 94, what if any is the impact is there on the existing code paths?

          Show
          Jonathan Hsieh added a comment - For which versions? I'm fine with 95/98. If you want to do 94, what if any is the impact is there on the existing code paths?

            People

            • Assignee:
              Ted Yu
              Reporter:
              Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development