HBase
  1. HBase
  2. HBASE-8319

hbase-it tests are run when you ask to run all tests -- it should be that you have to ask explicitly to run them

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.1
    • Component/s: None
    • Labels:
      None

      Description

      Up on trunk and on 0.95 apache builds, Sergey noticed that hbase-it tests are running. Up to this, the convention was that you had to explicitly ask that they run but that changed somehow recently. These tests are heavyweight, take a long time to complete, and are very likely to fail up on the apache infra (which is what we want of them but not as part of the general proofing build).

      For now the tests have been artificially disabled up on builds.apache.org but their inclusion likely frustrates joe blow trying to do a local hbase packaging.

        Activity

        Hide
        Sergey Shelukhin added a comment -

        Hmm... I cannot find mvn install in test-patch.sh. Is some other script used in jenkins?
        I will take a look later

        Show
        Sergey Shelukhin added a comment - Hmm... I cannot find mvn install in test-patch.sh. Is some other script used in jenkins? I will take a look later
        Hide
        Nicolas Liochon added a comment -

        trunk build does not use this script but directly calls mvn install, and mvn install calls the integration test. I think we can close this jira, it's not in our code base but in jenkins configuration screen (and it's solved there).

        Show
        Nicolas Liochon added a comment - trunk build does not use this script but directly calls mvn install, and mvn install calls the integration test. I think we can close this jira, it's not in our code base but in jenkins configuration screen (and it's solved there).
        Hide
        Nick Dimiduk added a comment -

        Can this be moved into a script in dev-tools? IMHO, the fewer moving parts in jenkins, the better.

        Show
        Nick Dimiduk added a comment - Can this be moved into a script in dev-tools? IMHO, the fewer moving parts in jenkins, the better.
        Hide
        Sergey Shelukhin added a comment -

        Who controls the jenkins config screen?
        I wonder how it didn't happen before. Must be something in our pom that changed.

        Show
        Sergey Shelukhin added a comment - Who controls the jenkins config screen? I wonder how it didn't happen before. Must be something in our pom that changed.
        Hide
        Nicolas Liochon added a comment -

        Can this be moved into a script in dev-tools? IMHO, the fewer moving parts in jenkins, the better.

        It's adding a level of indirection, so it makes things more complex and more fragile. See for example the jenkins configuration that sayd 1.7, while the script was pretending to use openjdk 1.6 before finally running with oracle 1.6.

        Who controls the jenkins config screen?

        It's an access right per project. I have it, Ted has it, and you could probably have it if you ask to Stack (if you don't have it already which is possible as well).

        I wonder how it didn't happen before. Must be something in our pom that changed.

        It's unlikely, as it's hardcoded in maven (that's the advantage of maven). More probably, it was changed a while ago, and as we were failing 90% of time if not more in the hbase-server part, so no one saw the impact from hbase-it.

        Show
        Nicolas Liochon added a comment - Can this be moved into a script in dev-tools? IMHO, the fewer moving parts in jenkins, the better. It's adding a level of indirection, so it makes things more complex and more fragile. See for example the jenkins configuration that sayd 1.7, while the script was pretending to use openjdk 1.6 before finally running with oracle 1.6. Who controls the jenkins config screen? It's an access right per project. I have it, Ted has it, and you could probably have it if you ask to Stack (if you don't have it already which is possible as well). I wonder how it didn't happen before. Must be something in our pom that changed. It's unlikely, as it's hardcoded in maven (that's the advantage of maven). More probably, it was changed a while ago, and as we were failing 90% of time if not more in the hbase-server part, so no one saw the impact from hbase-it.
        Hide
        Sergey Shelukhin added a comment -

        It's adding a level of indirection, so it makes things more complex and more fragile. See for example the jenkins configuration that sayd 1.7, while the script was pretending to use openjdk 1.6 before finally running with oracle 1.6.

        What would you suggest? Can the commands be changed in the screen to change mvn install to install-skipTests + test-runAllTests?

        Show
        Sergey Shelukhin added a comment - It's adding a level of indirection, so it makes things more complex and more fragile. See for example the jenkins configuration that sayd 1.7, while the script was pretending to use openjdk 1.6 before finally running with oracle 1.6. What would you suggest? Can the commands be changed in the screen to change mvn install to install-skipTests + test-runAllTests?
        Hide
        Nicolas Liochon added a comment -

        Can the commands be changed in the screen to change mvn install to install-skipTests + test-runAllTests?

        Yep, today the command is
        "-PrunAllTests -Dmaven.test.redirectTestOutputToFile=true install -Dsurefire.secondPartThreadCount=2 -Dit.test=noItTest"

        I can change it to something else if you want and you don't have the AR (in other words, the problem today is solved, but we can change the solution if you like).

        Show
        Nicolas Liochon added a comment - Can the commands be changed in the screen to change mvn install to install-skipTests + test-runAllTests? Yep, today the command is "-PrunAllTests -Dmaven.test.redirectTestOutputToFile=true install -Dsurefire.secondPartThreadCount=2 -Dit.test=noItTest" I can change it to something else if you want and you don't have the AR (in other words, the problem today is solved, but we can change the solution if you like).
        Hide
        Sergey Shelukhin added a comment - - edited

        Hmm... theoretically -Dit.test=noItTest should make sure the tests don't execute.

        mvn install -PrunAllTests -Dit.test=noItTest

        under hbase-it works for me, no tests run. Maybe it's interaction from default pom.xml.
        Maybe we should use -PskipIntegrationTests instead, this also works for me, need to see whether these will work with full build.

        Show
        Sergey Shelukhin added a comment - - edited Hmm... theoretically -Dit.test=noItTest should make sure the tests don't execute. mvn install -PrunAllTests -Dit.test=noItTest under hbase-it works for me, no tests run. Maybe it's interaction from default pom.xml. Maybe we should use -PskipIntegrationTests instead, this also works for me, need to see whether these will work with full build.
        Hide
        Nicolas Liochon added a comment -

        Yes, they're not executed anymore. It's me who put Dit.test=noItTest, because I wanted to be sure that the integration test will be compile but not executed. But if you prefer PskipIntegrationTests I can change the config.

        Show
        Nicolas Liochon added a comment - Yes, they're not executed anymore. It's me who put Dit.test=noItTest, because I wanted to be sure that the integration test will be compile but not executed. But if you prefer PskipIntegrationTests I can change the config.
        Hide
        Sergey Shelukhin added a comment -

        Ah, then if this is fixed this JIRA is no longer relevant

        Show
        Sergey Shelukhin added a comment - Ah, then if this is fixed this JIRA is no longer relevant

          People

          • Assignee:
            Nicolas Liochon
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development