HBase
  1. HBase
  2. HBASE-8271

Book updates for changes to GC options in shell scripts

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      http://hbase.apache.org/book/trouble.log.html is a bit out of date as the 'right' way to do GC logging is via the GC_OPTS, rather than going through the general HBASE_OPTS.

      Follow up to HBASE-7817

      1. HBASE-8271.patch
        4 kB
        Vasu Mariyala

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4081 (See https://builds.apache.org/job/HBase-TRUNK/4081/)
        HBASE-8271 Book updates for changes to GC options in shell scripts (Revision 1476037)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/docbkx/troubleshooting.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4081 (See https://builds.apache.org/job/HBase-TRUNK/4081/ ) HBASE-8271 Book updates for changes to GC options in shell scripts (Revision 1476037) Result = SUCCESS stack : Files : /hbase/trunk/src/main/docbkx/troubleshooting.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #511 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/511/)
        HBASE-8271 Book updates for changes to GC options in shell scripts (Revision 1476037)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/docbkx/troubleshooting.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #511 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/511/ ) HBASE-8271 Book updates for changes to GC options in shell scripts (Revision 1476037) Result = FAILURE stack : Files : /hbase/trunk/src/main/docbkx/troubleshooting.xml
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12580665/HBASE-8271.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        -1 lineLengths. The patch introduces lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.backup.TestHFileArchiving

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580665/HBASE-8271.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.backup.TestHFileArchiving Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5465//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to trunk (will show next time we update site). Thanks for the patch Vasu.

        Show
        stack added a comment - Committed to trunk (will show next time we update site). Thanks for the patch Vasu.
        Hide
        Vasu Mariyala added a comment -

        stack I am sorry for attaching a wrong patch. Please find the attached the correct patch (HBASE-8271.patch) which fixes this issue.

        Show
        Vasu Mariyala added a comment - stack I am sorry for attaching a wrong patch. Please find the attached the correct patch ( HBASE-8271 .patch) which fixes this issue.
        Hide
        stack added a comment -

        Vasu Mariyala When I try to apply the patch to trunk:

        durruti:trunk stack$ patch -p1 < HBASE-7817.patch.1
        patching file bin/hbase-config.sh
        Reversed (or previously applied) patch detected!  Assume -R? [n]
        Apply anyway? [n]
        Skipping patch.
        1 out of 1 hunk ignored -- saving rejects to file bin/hbase-config.sh.rej
        patching file bin/hbase-daemon.sh
        Hunk #1 FAILED at 153.
        1 out of 1 hunk FAILED -- saving rejects to file bin/hbase-daemon.sh.rej
        patching file conf/hbase-env.sh
        Reversed (or previously applied) patch detected!  Assume -R? [n]
        Apply anyway? [n]
        Skipping patch.
        1 out of 1 hunk ignored -- saving rejects to file conf/hbase-env.sh.rej
        

        ... because it has already been applied.

        Looks like it was applied here:

          0 r1464736 | jyates | 2013-04-04 13:45:25 -0700 (Thu, 04 Apr 2013) | 1 line
          1
          2 HBASE-7817: Suggested JDWP debug options in hbase-env.sh are wrong (Vasu Mariyala)
        
        Show
        stack added a comment - Vasu Mariyala When I try to apply the patch to trunk: durruti:trunk stack$ patch -p1 < HBASE-7817.patch.1 patching file bin/hbase-config.sh Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file bin/hbase-config.sh.rej patching file bin/hbase-daemon.sh Hunk #1 FAILED at 153. 1 out of 1 hunk FAILED -- saving rejects to file bin/hbase-daemon.sh.rej patching file conf/hbase-env.sh Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file conf/hbase-env.sh.rej ... because it has already been applied. Looks like it was applied here: 0 r1464736 | jyates | 2013-04-04 13:45:25 -0700 (Thu, 04 Apr 2013) | 1 line 1 2 HBASE-7817: Suggested JDWP debug options in hbase-env.sh are wrong (Vasu Mariyala)
        Hide
        Vasu Mariyala added a comment -

        stack This patch has not been applied to any of the branches.

        Show
        Vasu Mariyala added a comment - stack This patch has not been applied to any of the branches.
        Hide
        stack added a comment -

        Vasu Mariyala This patch has already been applied to trunk and 0.95?

        Show
        stack added a comment - Vasu Mariyala This patch has already been applied to trunk and 0.95?
        Hide
        Vasu Mariyala added a comment -

        stack Yes, this is the correct patch for the documentation issue. Let me know if you need any thing else.

        Show
        Vasu Mariyala added a comment - stack Yes, this is the correct patch for the documentation issue. Let me know if you need any thing else.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12580111/HBASE-7817.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5410//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580111/HBASE-7817.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5410//console This message is automatically generated.
        Hide
        stack added a comment -

        Vasu Mariyala Is this the right patch? I was expecting a patch for the refguide or at least a sentence that I can patch in. Thanks.

        Show
        stack added a comment - Vasu Mariyala Is this the right patch? I was expecting a patch for the refguide or at least a sentence that I can patch in. Thanks.
        Hide
        Jesse Yates added a comment -

        this was an update based on the handiwork of Vasu Mariyala - I'll ping him offline and see if he has time to do a change. If not, I'll see what I can churn out.

        Show
        Jesse Yates added a comment - this was an update based on the handiwork of Vasu Mariyala - I'll ping him offline and see if he has time to do a change. If not, I'll see what I can churn out.
        Hide
        stack added a comment -

        Jesse Yates Write a sentence and I'll add it to the book.

        Show
        stack added a comment - Jesse Yates Write a sentence and I'll add it to the book.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jesse Yates
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development