[HBASE-8240] CompoundConfiguration should implement Iterable

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.98.0, 0.95.1
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 02/Apr/13 03:29
• Updated: 23/Sep/13 19:08
• Resolved: 08/Apr/13 17:30

Description

Here is from hadoop Configuration class:

public class Configuration implements Iterable<Map.Entry<String,String>>,

There're 3 addXX() methods for CompoundConfiguration:

  public CompoundConfiguration add(final Configuration conf) {

  public CompoundConfiguration addWritableMap(
      final Map<ImmutableBytesWritable, ImmutableBytesWritable> map) {

  public CompoundConfiguration addStringMap(final Map<String, String> map) {

Parameters to these methods all support iteration.

We can enhance ImmutableConfigMap with the following new method:

  public abstract java.util.Iterator iterator();

Then the following method of CompoundConfiguration can be implemented:

  public Iterator<Map.Entry<String, String>> iterator() {

This enhancement would be useful in scenario where a mutable Configuration is required.