HBase
  1. HBase
  2. HBASE-8240

CompoundConfiguration should implement Iterable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Here is from hadoop Configuration class:

      public class Configuration implements Iterable<Map.Entry<String,String>>,
      

      There're 3 addXX() methods for CompoundConfiguration:

        public CompoundConfiguration add(final Configuration conf) {
      
        public CompoundConfiguration addWritableMap(
            final Map<ImmutableBytesWritable, ImmutableBytesWritable> map) {
      
        public CompoundConfiguration addStringMap(final Map<String, String> map) {
      

      Parameters to these methods all support iteration.

      We can enhance ImmutableConfigMap with the following new method:

        public abstract java.util.Iterator iterator();
      

      Then the following method of CompoundConfiguration can be implemented:

        public Iterator<Map.Entry<String, String>> iterator() {
      

      This enhancement would be useful in scenario where a mutable Configuration is required.

      1. 8240-v7.txt
        7 kB
        Ted Yu
      2. 8240-v6.txt
        7 kB
        Ted Yu
      3. 8240-v4.txt
        7 kB
        Ted Yu
      4. 8240-v3.txt
        3 kB
        Ted Yu
      5. 8240-v2.txt
        5 kB
        Ted Yu

        Activity

        Ted Yu created issue -
        Ted Yu made changes -
        Field Original Value New Value
        Description Here is from hadoop Configuration class:
        {code}
        public class Configuration implements Iterable<Map.Entry<String,String>>,
        {code}
        There're 3 addXX() methods for CompoundConfiguration:
        {code}
          public CompoundConfiguration add(final Configuration conf) {

          public CompoundConfiguration addWritableMap(
              final Map<ImmutableBytesWritable, ImmutableBytesWritable> map) {

          public CompoundConfiguration addStringMap(final Map<String, String> map) {
        {code}
        Parameters to these methods all support iteration.

        We can enhance ImmutableConfigMap with the following new method:
        {code}
          public abstract java.util.Iterator iterator();
        {code}
        This enhancement would be useful in scenario where a mutable Configuration is required.
        Here is from hadoop Configuration class:
        {code}
        public class Configuration implements Iterable<Map.Entry<String,String>>,
        {code}
        There're 3 addXX() methods for CompoundConfiguration:
        {code}
          public CompoundConfiguration add(final Configuration conf) {

          public CompoundConfiguration addWritableMap(
              final Map<ImmutableBytesWritable, ImmutableBytesWritable> map) {

          public CompoundConfiguration addStringMap(final Map<String, String> map) {
        {code}
        Parameters to these methods all support iteration.

        We can enhance ImmutableConfigMap with the following new method:
        {code}
          public abstract java.util.Iterator iterator();
        {code}
        Then the following method of CompoundConfiguration can be implemented:
        {code}
          public Iterator<Map.Entry<String, String>> iterator() {
        {code}
        This enhancement would be useful in scenario where a mutable Configuration is required.
        Ted Yu made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Hide
        Ted Yu added a comment -

        Iterable support is intended for read-only usage.

        Show
        Ted Yu added a comment - Iterable support is intended for read-only usage.
        Hide
        Nicolas Spiegelberg added a comment -

        looks good & sensible. this should be a simple n-way merge and all the existing ImmutableConfigMap types should have their own iterator, so this should be trivial. Note that the current implementation of CompoundConfiguration is not threadsafe, so you may need some extra work there depending upon how you are using this.

        Show
        Nicolas Spiegelberg added a comment - looks good & sensible. this should be a simple n-way merge and all the existing ImmutableConfigMap types should have their own iterator, so this should be trivial. Note that the current implementation of CompoundConfiguration is not threadsafe, so you may need some extra work there depending upon how you are using this.
        Ted Yu made changes -
        Attachment 8240-v1.txt [ 12576696 ]
        Hide
        Ted Yu added a comment -

        Patch v2 needs to add tests

        Show
        Ted Yu added a comment - Patch v2 needs to add tests
        Ted Yu made changes -
        Attachment 8240-v2.txt [ 12576707 ]
        Hide
        Lars Hofhansl added a comment -

        Should CompositeIterator be an inner class with a private constructor and never leaked out of CompoundConfiguration?

        Show
        Lars Hofhansl added a comment - Should CompositeIterator be an inner class with a private constructor and never leaked out of CompoundConfiguration?
        Hide
        Ted Yu added a comment -

        Patch v3 doesn't use CompositeIterator

        Will add tests.

        Show
        Ted Yu added a comment - Patch v3 doesn't use CompositeIterator Will add tests.
        Ted Yu made changes -
        Attachment 8240-v3.txt [ 12576708 ]
        Hide
        Ted Yu added a comment -

        Patch v4 adds tests for iterator.

        Show
        Ted Yu added a comment - Patch v4 adds tests for iterator.
        Ted Yu made changes -
        Attachment 8240-v4.txt [ 12576809 ]
        Ted Yu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Sergey Shelukhin added a comment -

        Test could just check values by getting the keys iterator returns and checking that value is the same from iterator and from get.
        Not sure if we need to copy entire map, could make iterator of iterators; adding the comment to say that this is an expensive operation might be enough.
        Would it be better to return UnmodifiableIterator<E> (from guava) given that remove on this iterator will have no effect on configuration?

        Show
        Sergey Shelukhin added a comment - Test could just check values by getting the keys iterator returns and checking that value is the same from iterator and from get. Not sure if we need to copy entire map, could make iterator of iterators; adding the comment to say that this is an expensive operation might be enough. Would it be better to return UnmodifiableIterator<E> (from guava) given that remove on this iterator will have no effect on configuration?
        Hide
        Ted Yu added a comment -

        Thanks for the review, Sergey.
        I tried the following assertion:

              assertEquals(compoundConf.get(entry.getKey()), entry.getValue());
        

        I got:

        junit.framework.ComparisonFailure: expected:<[/Users/tyu]/hadoop-http-auth-si...> but was:<[${user.home}]/hadoop-http-auth-si...>
        	at junit.framework.Assert.assertEquals(Assert.java:100)
        	at junit.framework.Assert.assertEquals(Assert.java:107)
        	at junit.framework.TestCase.assertEquals(TestCase.java:269)
        	at org.apache.hadoop.hbase.TestCompoundConfiguration.testLaterConfigsOverrideEarlier(TestCompoundConfiguration.java:183)
        

        There is logic in Configuration.get() that does substitution which I don't want to get involved.

        Show
        Ted Yu added a comment - Thanks for the review, Sergey. I tried the following assertion: assertEquals(compoundConf.get(entry.getKey()), entry.getValue()); I got: junit.framework.ComparisonFailure: expected:<[/Users/tyu]/hadoop-http-auth-si...> but was:<[${user.home}]/hadoop-http-auth-si...> at junit.framework.Assert.assertEquals(Assert.java:100) at junit.framework.Assert.assertEquals(Assert.java:107) at junit.framework.TestCase.assertEquals(TestCase.java:269) at org.apache.hadoop.hbase.TestCompoundConfiguration.testLaterConfigsOverrideEarlier(TestCompoundConfiguration.java:183) There is logic in Configuration.get() that does substitution which I don't want to get involved.
        Hide
        Ted Yu added a comment -

        Patch v6 adds a warning for using iterator.

        Also introduced UnmodifiableIterator as Sergey suggested.

        I tried CompositeIterator approach but its semantics is not correct: iterator would return multiple values for the same key.

        Show
        Ted Yu added a comment - Patch v6 adds a warning for using iterator. Also introduced UnmodifiableIterator as Sergey suggested. I tried CompositeIterator approach but its semantics is not correct: iterator would return multiple values for the same key.
        Ted Yu made changes -
        Attachment 8240-v6.txt [ 12576819 ]
        Ted Yu made changes -
        Assignee Ted Yu [ yuzhihong@gmail.com ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12576819/8240-v6.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576819/8240-v6.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5113//console This message is automatically generated.
        Ted Yu made changes -
        Fix Version/s 0.95.1 [ 12324288 ]
        Fix Version/s 0.98.0 [ 12323143 ]
        Hide
        Sergey Shelukhin added a comment -

        +1

        Show
        Sergey Shelukhin added a comment - +1
        Hide
        stack added a comment -

        Suggest removing "... which should only be conducted when absolutely necessary." on commit.

        Iterable<Map.Entry<String,String>>

        Is all config. in this CompoundConfiguration a String key and a String value? No ints, longs, etc.?

        I suppose it is ok because base Configuration does this.

        Do we have to save up all of the Configuation into a HashMap to decorate it with an unmodifiable?

        Where do we need this functionatlity?

        Show
        stack added a comment - Suggest removing "... which should only be conducted when absolutely necessary." on commit. Iterable<Map.Entry<String,String>> Is all config. in this CompoundConfiguration a String key and a String value? No ints, longs, etc.? I suppose it is ok because base Configuration does this. Do we have to save up all of the Configuation into a HashMap to decorate it with an unmodifiable? Where do we need this functionatlity?
        Hide
        stack added a comment -

        Moving new feature out of 0.95. Feel free to pull back later.

        Show
        stack added a comment - Moving new feature out of 0.95. Feel free to pull back later.
        stack made changes -
        Fix Version/s 0.95.1 [ 12324288 ]
        Hide
        Ted Yu added a comment -

        I suppose it is ok because base Configuration does this.

        That's right. Query to ImmutableConfigMap always uses String parameter:

              public String get(String key) {
        

        Do we have to save up all of the Configuation into a HashMap

        This is done so that the returned iterator doesn't give user duplicate keys. See my comment above:

        I tried CompositeIterator approach but its semantics is not correct: iterator would return multiple values for the same key.

        Where do we need this functionatlity?

        This is needed in FileSystem.get(Configuration) call. hadoop 2.0 expects a mutable Configuration. We would get the following if CompoundConfiguration is passed:

        java.lang.UnsupportedOperationException: Immutable Configuration
          at org.apache.hadoop.hbase.CompoundConfiguration.setClass(CompoundConfiguration.java:474)
          at org.apache.hadoop.ipc.RPC.setProtocolEngine(RPC.java:193)
          at org.apache.hadoop.hdfs.NameNodeProxies.createNNProxyWithClientProtocol(NameNodeProxies.java:249)
          at org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:168)
          at org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:129)
          at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:421)
          at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:388)
          at org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:125)
          at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2277)
          at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:86)
          at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2311)
          at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2293)
          at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:317)
          at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:163)
        

        So this JIRA should go into 0.95 as well.

        Show
        Ted Yu added a comment - I suppose it is ok because base Configuration does this. That's right. Query to ImmutableConfigMap always uses String parameter: public String get( String key) { Do we have to save up all of the Configuation into a HashMap This is done so that the returned iterator doesn't give user duplicate keys. See my comment above: I tried CompositeIterator approach but its semantics is not correct: iterator would return multiple values for the same key. Where do we need this functionatlity? This is needed in FileSystem.get(Configuration) call. hadoop 2.0 expects a mutable Configuration. We would get the following if CompoundConfiguration is passed: java.lang.UnsupportedOperationException: Immutable Configuration at org.apache.hadoop.hbase.CompoundConfiguration.setClass(CompoundConfiguration.java:474) at org.apache.hadoop.ipc.RPC.setProtocolEngine(RPC.java:193) at org.apache.hadoop.hdfs.NameNodeProxies.createNNProxyWithClientProtocol(NameNodeProxies.java:249) at org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:168) at org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:129) at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:421) at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:388) at org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:125) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2277) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:86) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2311) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2293) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:317) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:163) So this JIRA should go into 0.95 as well.
        Hide
        Ted Yu added a comment -

        Patch v7 removes the sentence as Stack advised.

        Show
        Ted Yu added a comment - Patch v7 removes the sentence as Stack advised.
        Ted Yu made changes -
        Attachment 8240-v7.txt [ 12577000 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12577000/8240-v7.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577000/8240-v7.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5135//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        stack:
        Can this patch go into 0.95 ?

        Thanks

        Show
        Ted Yu added a comment - stack : Can this patch go into 0.95 ? Thanks
        Hide
        stack added a comment -

        Ted Yu No harm I'd say. Has a test. +1

        Show
        stack added a comment - Ted Yu No harm I'd say. Has a test. +1
        Hide
        Ted Yu added a comment -

        Integrated to 0.95 and trunk.

        Thanks for the reviews, Sergey and Stack.

        Show
        Ted Yu added a comment - Integrated to 0.95 and trunk. Thanks for the reviews, Sergey and Stack.
        Ted Yu made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.95.1 [ 12324288 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4014 (See https://builds.apache.org/job/HBase-TRUNK/4014/)
        HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464669)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java
        • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4014 (See https://builds.apache.org/job/HBase-TRUNK/4014/ ) HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464669) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #124 (See https://builds.apache.org/job/hbase-0.95/124/)
        HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464670)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java
        • /hbase/branches/0.95/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Show
        Hudson added a comment - Integrated in hbase-0.95 #124 (See https://builds.apache.org/job/hbase-0.95/124/ ) HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464670) Result = FAILURE tedyu : Files : /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java /hbase/branches/0.95/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #55 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/55/)
        HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464670)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java
        • /hbase/branches/0.95/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #55 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/55/ ) HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464670) Result = FAILURE tedyu : Files : /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java /hbase/branches/0.95/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #477 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/477/)
        HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464669)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java
        • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #477 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/477/ ) HBASE-8240 CompoundConfiguration should implement Iterable (Ted Yu) (Revision 1464669) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
        Hide
        Ted Yu added a comment -

        Lars Hofhansl:
        Are you Okay with this going into 0.94 ?

        Thanks

        Show
        Ted Yu added a comment - Lars Hofhansl : Are you Okay with this going into 0.94 ? Thanks
        Hide
        stack added a comment -

        -1 for 0.94. It is not even needed in 0.95 it seems.

        Show
        stack added a comment - -1 for 0.94. It is not even needed in 0.95 it seems.
        Hide
        Lars Hofhansl added a comment -

        Patch is simple enough, I am fine on that front.
        But I, too, do not understand what this is needed for.

        Show
        Lars Hofhansl added a comment - Patch is simple enough, I am fine on that front. But I, too, do not understand what this is needed for.
        Ted Yu made changes -
        Attachment 8240-v1.txt [ 12576696 ]
        Ted Yu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Lars Hofhansl added a comment -

        If we're not sure that this is needed, why is it in 0.95+?
        (Or phrased the other way around, if this is needed in 0.95+ then why not in 0.94?)

        Show
        Lars Hofhansl added a comment - If we're not sure that this is needed, why is it in 0.95+? (Or phrased the other way around, if this is needed in 0.95+ then why not in 0.94?)
        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ted Yu
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development