[HBASE-8225] [replication] minor code bug when registering ReplicationLogCleaner

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.94.6
• Fix Version/s: 0.94.7, 0.95.0, 0.95.2
• Component/s: Replication
• Assignee: Jerry He
• Reporter: Jerry He
• Created: 29/Mar/13 20:03
• Updated: 27/Apr/13 15:55
• Resolved: 02/Apr/13 03:45

Description

We try to register ReplicationLogCleaner by default. This is done by calling Replication.decorateMasterConfiguration()in the master.

In the current Replication.decorateMasterConfiguration():
...
String plugins = conf.get(HBASE_MASTER_LOGCLEANER_PLUGINS);
if (!plugins.contains(ReplicationLogCleaner.class.toString()))

{ conf.set(HBASE_MASTER_LOGCLEANER_PLUGINS, plugins + "," + ReplicationLogCleaner.class.getCanonicalName()); }

...

ReplicationLogCleaner.class.toString() will return prefix 'class' to the full class name, which will make the if checking mostly useless.