Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8225

[replication] minor code bug when registering ReplicationLogCleaner

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.6
    • Fix Version/s: 0.94.7, 0.95.0, 0.95.2
    • Component/s: Replication
    • Labels:
      None

      Description

      We try to register ReplicationLogCleaner by default. This is done by calling Replication.decorateMasterConfiguration()in the master.

      In the current Replication.decorateMasterConfiguration():
      ...
      String plugins = conf.get(HBASE_MASTER_LOGCLEANER_PLUGINS);
      if (!plugins.contains(ReplicationLogCleaner.class.toString()))

      { conf.set(HBASE_MASTER_LOGCLEANER_PLUGINS, plugins + "," + ReplicationLogCleaner.class.getCanonicalName()); }

      ...

      ReplicationLogCleaner.class.toString() will return prefix 'class' to the full class name, which will make the if checking mostly useless.

        Attachments

        1. HBASE-8255-0.94.patch
          0.9 kB
          Jerry He
        2. HBASE-8255-trunk.patch
          1.0 kB
          Jerry He

          Activity

            People

            • Assignee:
              jinghe Jerry He
              Reporter:
              jinghe Jerry He
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: