HBase
  1. HBase
  2. HBASE-8135

Mutation should implement HeapSize

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.5, 0.95.0, 0.95.2
    • Fix Version/s: 0.98.0, 0.95.0
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Code is there already.
      Doing so would allow to share some code when doing client side buffering.
      patch compiles locally, should not impact tests, but not tested locally.

      1. 8135-v3.txt
        8 kB
        Ted Yu
      2. 8135.v5.patch
        10 kB
        Nicolas Liochon
      3. 8135.v5.patch
        10 kB
        Nicolas Liochon
      4. 8135.v5.patch
        10 kB
        Ted Yu
      5. 8135.v4.patch
        10 kB
        Nicolas Liochon
      6. 8135.v2.patch
        8 kB
        Nicolas Liochon
      7. 8135.v1.patch
        2 kB
        Nicolas Liochon

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #455 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/455/)
        HBASE-8135 Mutation should implement HeapSize (Revision 1458418)

        Result = FAILURE
        nkeywal :
        Files :

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #455 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/455/ ) HBASE-8135 Mutation should implement HeapSize (Revision 1458418) Result = FAILURE nkeywal : Files : /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #34 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/34/)
        HBASE-8135 Mutation should implement HeapSize (Revision 1458421)

        Result = FAILURE
        nkeywal :
        Files :

        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #34 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/34/ ) HBASE-8135 Mutation should implement HeapSize (Revision 1458421) Result = FAILURE nkeywal : Files : /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #87 (See https://builds.apache.org/job/hbase-0.95/87/)
        HBASE-8135 Mutation should implement HeapSize (Revision 1458421)

        Result = FAILURE
        nkeywal :
        Files :

        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Show
        Hudson added a comment - Integrated in hbase-0.95 #87 (See https://builds.apache.org/job/hbase-0.95/87/ ) HBASE-8135 Mutation should implement HeapSize (Revision 1458421) Result = FAILURE nkeywal : Files : /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3973 (See https://builds.apache.org/job/HBase-TRUNK/3973/)
        HBASE-8135 Mutation should implement HeapSize (Revision 1458418)

        Result = SUCCESS
        nkeywal :
        Files :

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3973 (See https://builds.apache.org/job/HBase-TRUNK/3973/ ) HBASE-8135 Mutation should implement HeapSize (Revision 1458418) Result = SUCCESS nkeywal : Files : /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        Hide
        Nicolas Liochon added a comment -

        This seems to prove that we're in the usual flakiness (thanks for having relaunched the tests, Ted). Committed to trunk and 0.95.

        Thanks for the review, Stack & Ted!

        Show
        Nicolas Liochon added a comment - This seems to prove that we're in the usual flakiness (thanks for having relaunched the tests, Ted). Committed to trunk and 0.95. Thanks for the review, Stack & Ted!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574350/8135.v5.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574350/8135.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4889//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574335/8135.v5.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestJoinedScanners
        org.apache.hadoop.hbase.client.TestHTableMultiplexer
        org.apache.hadoop.hbase.client.TestHCM

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574335/8135.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestJoinedScanners org.apache.hadoop.hbase.client.TestHTableMultiplexer org.apache.hadoop.hbase.client.TestHCM Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4888//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574332/8135.v4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestJoinedScanners
        org.apache.hadoop.hbase.client.TestHTableMultiplexer

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574332/8135.v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestJoinedScanners org.apache.hadoop.hbase.client.TestHTableMultiplexer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4886//console This message is automatically generated.
        Hide
        Nicolas Liochon added a comment -

        v5 is what I will commit if the build runs ok.

        Show
        Nicolas Liochon added a comment - v5 is what I will commit if the build runs ok.
        Hide
        Nicolas Liochon added a comment -

        There was a javadoc warning.

        Right. I'm going to hunt it.

        Show
        Nicolas Liochon added a comment - There was a javadoc warning. Right. I'm going to hunt it.
        Hide
        Ted Yu added a comment -

        There was a javadoc warning.

        Please fix.

        Other than that, +1.

        Show
        Ted Yu added a comment - There was a javadoc warning. Please fix. Other than that, +1.
        Hide
        Nicolas Liochon added a comment -

        Thanks a lot Ted. For v4 I've just moved the test 'Put' with the other tests. I will commit as soon as I get a +1.

        Show
        Nicolas Liochon added a comment - Thanks a lot Ted. For v4 I've just moved the test 'Put' with the other tests. I will commit as soon as I get a +1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574238/8135-v3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574238/8135-v3.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4875//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Patch v3 makes TestHeapSize pass.

        Put has already been covered in TestHeapSize#testSizes()

        Show
        Ted Yu added a comment - Patch v3 makes TestHeapSize pass. Put has already been covered in TestHeapSize#testSizes()
        Hide
        Nicolas Liochon added a comment -

        Yes, just locally (I do test before submitting ) I used ClassSize.align for timerange, and it went ok. But for Put/Delete/Increment, There are 88 bytes of difference I cannot explain. The code is on the v2.patch.

        Show
        Nicolas Liochon added a comment - Yes, just locally (I do test before submitting ) I used ClassSize.align for timerange, and it went ok. But for Put/Delete/Increment, There are 88 bytes of difference I cannot explain. The code is on the v2.patch.
        Hide
        stack added a comment -

        Oh, this is just locally, no jenkins involved? You using ClassSize.align?

        Show
        stack added a comment - Oh, this is just locally, no jenkins involved? You using ClassSize.align?
        Hide
        stack added a comment -

        Try using -d32 flag locally. Jenkins seems to do 32bit java.

        Show
        stack added a comment - Try using -d32 flag locally. Jenkins seems to do 32bit java.
        Hide
        Nicolas Liochon added a comment -

        There is an issue: with the unit tests, I've got a huge gap I do not explain:

        Expected :80
        Actual :168

        2013-03-18 19:54:28,845 DEBUG [main] util.ClassSize(246): 0 row class [B
        2013-03-18 19:54:28,845 DEBUG [main] util.ClassSize(246): 1 ts long
        2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 2 writeToWAL boolean
        2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 3 familyMap interface java.util.NavigableMap
        2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 4 attributes interface java.util.Map
        2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(273): Primitives=9, arrays=1, references(includes 2 for object overhead)=5, refSize 8, size=80, prealign_size=73

        Any hint?

        Show
        Nicolas Liochon added a comment - There is an issue: with the unit tests, I've got a huge gap I do not explain: Expected :80 Actual :168 2013-03-18 19:54:28,845 DEBUG [main] util.ClassSize(246): 0 row class [B 2013-03-18 19:54:28,845 DEBUG [main] util.ClassSize(246): 1 ts long 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 2 writeToWAL boolean 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 3 familyMap interface java.util.NavigableMap 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 4 attributes interface java.util.Map 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(273): Primitives=9, arrays=1, references(includes 2 for object overhead)=5, refSize 8, size=80, prealign_size=73 Any hint?
        Hide
        Nicolas Liochon added a comment -

        I was trying to find a generic way to get the size of an object. A google search on this leads to quite a lot of terrible practises . It should be possible to do a static{} block for the fixed fields, but it won't bring much actual value. With the current implementation, it's better to have unit tests when ones adds fields. I'm going to do this in this patch (including Increment) it will be simpler.

        Show
        Nicolas Liochon added a comment - I was trying to find a generic way to get the size of an object. A google search on this leads to quite a lot of terrible practises . It should be possible to do a static{} block for the fixed fields, but it won't bring much actual value. With the current implementation, it's better to have unit tests when ones adds fields. I'm going to do this in this patch (including Increment) it will be simpler.
        Hide
        stack added a comment -

        Ted Yu Not in this patch.

        Show
        stack added a comment - Ted Yu Not in this patch.
        Hide
        Ted Yu added a comment -

        Increment inherits heapSize() from Mutation.
        Increment has a field of TimeRange which is not accounted for in Mutation#heapSize()

        Should we account for this field in Increment#heapSize() ?

        Show
        Ted Yu added a comment - Increment inherits heapSize() from Mutation. Increment has a field of TimeRange which is not accounted for in Mutation#heapSize() Should we account for this field in Increment#heapSize() ?
        Hide
        stack added a comment -

        +1

        I think I added heapsize method to Mutation when I made Increment a Mutation; didn't add the interface because wasn't sure it was needed generally.

        Show
        stack added a comment - +1 I think I added heapsize method to Mutation when I made Increment a Mutation; didn't add the interface because wasn't sure it was needed generally.
        Hide
        Nicolas Liochon added a comment -

        Agreed, I will do that on commit. Are you +1 otherwise?

        Show
        Nicolas Liochon added a comment - Agreed, I will do that on commit. Are you +1 otherwise?
        Hide
        Ted Yu added a comment -
        -  long heapSize() {
        +  public long heapSize() {
        

        Add @Override.

        Show
        Ted Yu added a comment - - long heapSize() { + public long heapSize() { Add @Override.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574131/8135.v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574131/8135.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4862//console This message is automatically generated.

          People

          • Assignee:
            Nicolas Liochon
            Reporter:
            Nicolas Liochon
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development