Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8125

HBASE-7435 breaks BuiltInGzipDecompressor on Hadoop < 1.0.x

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.94.7
    • None
    • None
    • Reviewed

    Description

      From some friends of ours at dropbox:

      Index: src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
      ===================================================================
      — src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java (revision 1425723)
      +++ src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java (working copy)
      @@ -33,6 +33,7 @@
      import org.apache.hadoop.io.compress.CompressionOutputStream;
      import org.apache.hadoop.io.compress.Compressor;
      import org.apache.hadoop.io.compress.Decompressor;
      +import org.apache.hadoop.io.compress.DoNotPool;
      import org.apache.hadoop.io.compress.GzipCodec;
      import org.apache.hadoop.io.compress.DefaultCodec;
      import org.apache.hadoop.util.ReflectionUtils;
      @@ -308,6 +309,9 @@
      public void returnDecompressor(Decompressor decompressor) {
      if (decompressor != null) {
      CodecPool.returnDecompressor(decompressor);
      + if (decompressor.getClass().isAnnotationPresent(DoNotPool.class))

      { + decompressor.end(); + }

      }
      }

      breaks compatibility with hadoop-0.20.2-cdh3u2.
      +import org.apache.hadoop.io.compress.DoNotPool;
      does not exist in that version of hadoop.

      Attachments

        1. 8125.addendum
          0.8 kB
          Ted Yu
        2. 8125-0.94.txt
          2 kB
          Ted Yu

        Issue Links

          Activity

            People

              yuzhihong@gmail.com Ted Yu
              stack Michael Stack
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: