[HBASE-8094] TestTableInputFormatScan doesn't assert anything

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.98.0, 0.95.0
• Component/s: mapreduce, test
• Hadoop Flags: Reviewed
• Assignee: Nick Dimiduk
• Reporter: Nick Dimiduk
• Created: 13/Mar/13 22:02
• Updated: 23/Sep/13 18:30
• Resolved: 14/Mar/13 00:06

Description

This test makes assertions from within the Reducer. These tests are not respected because the control harness asserts only that jobs complete, not that they succeed.

Verify this is true by adding a failure to the reducer:

$ git diff 
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
index bab9633..322cb4f 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
@@ -160,6 +160,7 @@ public class TestTableInputFormatScan {
       if (lastRow != null && lastRow.length() > 0) {
         assertEquals(lastRow, last);
       }
+      assertTrue(false);
     }
 
   }

The test still passes.

Issue Links

• is depended upon by: HBASE-8074 Consolidate map-side features across mapreduce tools into a single place