HBase
  1. HBase
  2. HBASE-8026

HBase Shell docs for scan command does not reference VERSIONS

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0, 2.0.0, 0.98.10, 1.1.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      hbase(main):046:0> help 'scan'
      Scan a table; pass table name and optionally a dictionary of scanner
      specifications. Scanner specifications may include one or more of:
      TIMERANGE, FILTER, LIMIT, STARTROW, STOPROW, TIMESTAMP, MAXLENGTH,
      or COLUMNS, CACHE

      VERSIONS should be mentioned somewhere here.

        Activity

        Hide
        Amit Kabra added a comment -

        Agree.
        Versions go along with RAW scanner attribute.
        Eg : scan 't1',

        {RAW => true, VERSIONS => 10}

        So we need to mention both RAW and VERSIONS.

        Show
        Amit Kabra added a comment - Agree. Versions go along with RAW scanner attribute. Eg : scan 't1', {RAW => true, VERSIONS => 10} So we need to mention both RAW and VERSIONS.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691486/HBASE-8026.patch
        against master branch at commit 988cba762a6d99b4b512ff97a607891f4b82f7dc.
        ATTACHMENT ID: 12691486

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691486/HBASE-8026.patch against master branch at commit 988cba762a6d99b4b512ff97a607891f4b82f7dc. ATTACHMENT ID: 12691486 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12399//console This message is automatically generated.
        Hide
        Amit Kabra added a comment -

        Manual steps :
        1) Following works : scan 't1',

        {RAW => true, VERSIONS => 10}

        2) help 'scan' shows both RAW and VERSIONS info.

        Show
        Amit Kabra added a comment - Manual steps : 1) Following works : scan 't1', {RAW => true, VERSIONS => 10} 2) help 'scan' shows both RAW and VERSIONS info.
        Hide
        Sean Busbey added a comment -

        Could you expand the help to include mention of how one uses RAW/VERSIONS? Also please add a test in hbase-shell/src/test/ruby/shell; should be straight forward.

        Show
        Sean Busbey added a comment - Could you expand the help to include mention of how one uses RAW/VERSIONS? Also please add a test in hbase-shell/src/test/ruby/shell; should be straight forward.
        Hide
        Amit Kabra added a comment -

        1) Usage :

        Its already present and can be seen once we do help scan on shell. Excerpt that include info on versions and raw :

        "
        Also for experts, there is an advanced option – RAW – which instructs the
        scanner to return all cells (including delete markers and uncollected deleted
        cells). This option cannot be combined with requesting specific COLUMNS.
        Disabled by default. Example:

        hbase> scan 't1',

        {RAW => true, VERSIONS => 10}

        "

        2) Test - This jira is not about functionality of RAW and VERSIONS command. Its just the mention of these commands missing in the help.
        If you meant writing a new unit test for versions and raw command, then I will go through the shell tests to see if there is any corresponding test there and if not present, I can raise a new Jira and can work on it.

        Show
        Amit Kabra added a comment - 1) Usage : Its already present and can be seen once we do help scan on shell. Excerpt that include info on versions and raw : " Also for experts, there is an advanced option – RAW – which instructs the scanner to return all cells (including delete markers and uncollected deleted cells). This option cannot be combined with requesting specific COLUMNS. Disabled by default. Example: hbase> scan 't1', {RAW => true, VERSIONS => 10} " 2) Test - This jira is not about functionality of RAW and VERSIONS command. Its just the mention of these commands missing in the help. If you meant writing a new unit test for versions and raw command, then I will go through the shell tests to see if there is any corresponding test there and if not present, I can raise a new Jira and can work on it.
        Hide
        Sean Busbey added a comment -

        1) Okay, that looks good.

        2) yes please raise a follow on jira for the test if there isn't one.

        Show
        Sean Busbey added a comment - 1) Okay, that looks good. 2) yes please raise a follow on jira for the test if there isn't one.
        Hide
        Andrew Purtell added a comment -

        +1

        Pushed to 0.98+

        Show
        Andrew Purtell added a comment - +1 Pushed to 0.98+
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #6031 (See https://builds.apache.org/job/HBase-TRUNK/6031/)
        HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev f1d1dbfaa4a5ece96b8263bd0cae18ffea11a75f)

        • hbase-shell/src/main/ruby/shell/commands/scan.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6031 (See https://builds.apache.org/job/HBase-TRUNK/6031/ ) HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev f1d1dbfaa4a5ece96b8263bd0cae18ffea11a75f) hbase-shell/src/main/ruby/shell/commands/scan.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.1 #86 (See https://builds.apache.org/job/HBase-1.1/86/)
        HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev c339e181ae5b175ef757095741a89f3b92229c9d)

        • hbase-shell/src/main/ruby/shell/commands/scan.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.1 #86 (See https://builds.apache.org/job/HBase-1.1/86/ ) HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev c339e181ae5b175ef757095741a89f3b92229c9d) hbase-shell/src/main/ruby/shell/commands/scan.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.0 #661 (See https://builds.apache.org/job/HBase-1.0/661/)
        HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev 7cd43e7b265c4503e5f77ea0c56bf5832a76bdde)

        • hbase-shell/src/main/ruby/shell/commands/scan.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.0 #661 (See https://builds.apache.org/job/HBase-1.0/661/ ) HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev 7cd43e7b265c4503e5f77ea0c56bf5832a76bdde) hbase-shell/src/main/ruby/shell/commands/scan.rb
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #802 (See https://builds.apache.org/job/HBase-0.98/802/)
        HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev dc36b4dfd7a4f98ae23b88f6f1b589a5b9eb44da)

        • hbase-shell/src/main/ruby/shell/commands/scan.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #802 (See https://builds.apache.org/job/HBase-0.98/802/ ) HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev dc36b4dfd7a4f98ae23b88f6f1b589a5b9eb44da) hbase-shell/src/main/ruby/shell/commands/scan.rb
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #765 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/765/)
        HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev dc36b4dfd7a4f98ae23b88f6f1b589a5b9eb44da)

        • hbase-shell/src/main/ruby/shell/commands/scan.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #765 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/765/ ) HBASE-8026 HBase Shell docs for scan command does not reference VERSIONS (Amit Kabra) (apurtell: rev dc36b4dfd7a4f98ae23b88f6f1b589a5b9eb44da) hbase-shell/src/main/ruby/shell/commands/scan.rb
        Hide
        Amit Kabra added a comment -
        Show
        Amit Kabra added a comment - Sean Busbey , Andrew Purtell : created new jira for test case : https://issues.apache.org/jira/browse/HBASE-12885
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 1.0.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 1.0.0 release.

          People

          • Assignee:
            Amit Kabra
            Reporter:
            Jonathan Natkins
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development