HBase
  1. HBase
  2. HBASE-8012

Reseek should position to the beginning of file for the first time it is invoked with a KV smaller than the first KV in file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.5
    • Fix Version/s: 0.98.0, 0.95.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The storeFileScanner's seekAtOrAfter method will position at the beginning of the file when the passed KV is smaller than first KV in file. While for reseekAtOrAfter, I think it should also do the same thing when it is the first time it been seeked. originally, this is workaround by adding a isReseekable property in StoreFileScanner, and is checked upon each enforceSeek(), if it is not seeked before, it will go with seek approaching instead of reseek approaching. While why not make reseekAtOrAfter working correctly for the first time it been reseek (also never been seek before), since the file is never seeked before, so position it at the beginning of the file don't break the idea of "reseek", say never rewind.

      It will save the effort for HBASE-8001, with this fixed, it won't need to check isReseekable any more.

      1. HBASE-8012_v2.patch
        4 kB
        Raymond Liu
      2. HBASE-8012.patch
        2 kB
        stack
      3. HBASE-8012.patch
        2 kB
        Raymond Liu

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Raymond Liu
              Reporter:
              Raymond Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development