HBase
  1. HBase
  2. HBASE-7951

TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Failed with this:

      java.lang.AssertionError: expected:<SUCCESS> but was:<TIMED_OUT>
      	at org.junit.Assert.fail(Assert.java:88)
      

      The first execution TIMED_OUT. Timeout invoking shell is 200ms.

      1. 7951v2.txt
        6 kB
        stack
      2. 7951.txt
        6 kB
        stack

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        stack added a comment -

        This failed again in https://builds.apache.org/view/G-L/view/HBase/job/hbase-0.95/36/testReport/org.apache.hadoop.hbase/TestNodeHealthCheckChore/testHealthChecker/

        My fix above adjusting timeout is not enough. I missed that a default is being set on the tail of the test and the 200ms is being used in place of my suggested 2000. Will open new issue to fix.

        Show
        stack added a comment - This failed again in https://builds.apache.org/view/G-L/view/HBase/job/hbase-0.95/36/testReport/org.apache.hadoop.hbase/TestNodeHealthCheckChore/testHealthChecker/ My fix above adjusting timeout is not enough. I missed that a default is being set on the tail of the test and the 200ms is being used in place of my suggested 2000. Will open new issue to fix.
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #3 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/3/)
        HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450946)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #3 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/3/ ) HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450946) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #423 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/423/)
        HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450947)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #423 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/423/ ) HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450947) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3904 (See https://builds.apache.org/job/HBase-TRUNK/3904/)
        HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450947)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3904 (See https://builds.apache.org/job/HBase-TRUNK/3904/ ) HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450947) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #6 (See https://builds.apache.org/job/hbase-0.95/6/)
        HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450946)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Show
        Hudson added a comment - Integrated in hbase-0.95 #6 (See https://builds.apache.org/job/hbase-0.95/6/ ) HBASE-7951 TestNodeHealthCheckChore.testHealthChecker failed 0.95 build #3 (Revision 1450946) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthReport.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java
        Hide
        stack added a comment -

        Committed to 0.95 and trunk.

        Show
        stack added a comment - Committed to 0.95 and trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12571152/7951v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571152/7951v2.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4577//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        +1

        Show
        Andrew Purtell added a comment - +1
        Hide
        stack added a comment -

        Here is the proper patch

        Show
        stack added a comment - Here is the proper patch
        Hide
        stack added a comment -

        Up the time to execute external shell command from 200ms to 2seconds. Add try/catches so don't leak resources (but it looks like hadoop shellcommandexecutable leaves an executor around). Improve the logging strings to do stuff like include path to command being run. Check result of filesystem operations like mkdirs and create file.

        Show
        stack added a comment - Up the time to execute external shell command from 200ms to 2seconds. Add try/catches so don't leak resources (but it looks like hadoop shellcommandexecutable leaves an executor around). Improve the logging strings to do stuff like include path to command being run. Check result of filesystem operations like mkdirs and create file.
        Show
        stack added a comment - Here is the test that failed: https://builds.apache.org/job/hbase-0.95/3/testReport/org.apache.hadoop.hbase/TestNodeHealthCheckChore/testHealthChecker/

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development