HBase
  1. HBase
  2. HBASE-7921

TestHFileBlock.testGzipCompression should ignore the block checksum

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.94.8, 0.95.1
    • Fix Version/s: 0.98.0, 0.94.8, 0.95.1
    • Component/s: test
    • Labels:
      None

      Description

      TestHFileBlock.createTestBlockStr can change the gzip header after the block is produced. The OS field can be set to 0 on Linux or Mac if the native gzip codec is available and is used, but the test code then resets it to 3. When comparing the resulting block the checksum should be ignored.

      1. 7921.patch
        2 kB
        Andrew Purtell

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #141 (See https://builds.apache.org/job/HBase-0.94-security/141/)
        HBASE-7921. TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471227)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #141 (See https://builds.apache.org/job/HBase-0.94-security/141/ ) HBASE-7921 . TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471227) Result = FAILURE apurtell : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #965 (See https://builds.apache.org/job/HBase-0.94/965/)
        HBASE-7921. TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471227)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #965 (See https://builds.apache.org/job/HBase-0.94/965/ ) HBASE-7921 . TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471227) Result = FAILURE apurtell : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #160 (See https://builds.apache.org/job/hbase-0.95/160/)
        HBASE-7921. TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471226)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Show
        Hudson added a comment - Integrated in hbase-0.95 #160 (See https://builds.apache.org/job/hbase-0.95/160/ ) HBASE-7921 . TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471226) Result = FAILURE apurtell : Files : /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4077 (See https://builds.apache.org/job/HBase-TRUNK/4077/)
        HBASE-7921. TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471225)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4077 (See https://builds.apache.org/job/HBase-TRUNK/4077/ ) HBASE-7921 . TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471225) Result = FAILURE apurtell : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #78 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/78/)
        HBASE-7921. TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471226)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #78 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/78/ ) HBASE-7921 . TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471226) Result = FAILURE apurtell : Files : /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #508 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/508/)
        HBASE-7921. TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471225)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #508 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/508/ ) HBASE-7921 . TestHFileBlock.testGzipCompression should ignore the block checksum (Revision 1471225) Result = FAILURE apurtell : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
        Hide
        Andrew Purtell added a comment -

        Committed.

        Show
        Andrew Purtell added a comment - Committed.
        Hide
        Andrew Purtell added a comment -

        Sorry I forgot about this. It came up on the user list today. Will commit to all active branches shortly if no objections.

        Show
        Andrew Purtell added a comment - Sorry I forgot about this. It came up on the user list today. Will commit to all active branches shortly if no objections.
        Hide
        Andrew Purtell added a comment -

        Does this bring on test failures Andrew?

        Yes, but only if the native Hadoop library (thus native gzip codec) is loaded. I tripped over this when running the unit test suite with the native libraries available (as part of testing for HBASE-7544).

        Show
        Andrew Purtell added a comment - Does this bring on test failures Andrew? Yes, but only if the native Hadoop library (thus native gzip codec) is loaded. I tripped over this when running the unit test suite with the native libraries available (as part of testing for HBASE-7544 ).
        Hide
        stack added a comment -

        +1

        Does this bring on test failures Andrew?

        Show
        stack added a comment - +1 Does this bring on test failures Andrew?

          People

          • Assignee:
            Andrew Purtell
            Reporter:
            Andrew Purtell
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development