Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      From SnapshotManager:

       * Note: Currently there can only be one snapshot being taken at a time over the cluster. This is a
       * simplification in the current implementation.
      

      We should support concurrent snapshots (on different tables)

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        92d 17h 48m 1 Ted Yu 19/May/13 16:56
        Ted Yu made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Duplicate [ 3 ]
        Hide
        Ted Yu added a comment -

        This has been implemented in HBASE-8446

        Show
        Ted Yu added a comment - This has been implemented in HBASE-8446
        Hide
        Ted Yu added a comment -

        In SnapshotManager:

        +  // TODO - enable having multiple snapshots with multiple monitors/threads
        +  // this needs to be configuration based when running multiple snapshots is implemented
        +  /** number of current operations running on the master */
        +  private static final int opThreads = 1;
        ...
        +  synchronized boolean isTakingSnapshot() throws SnapshotCreationException {
        +    // TODO later when we handle multiple there would be a map with ssname to handler.
        +    return handler != null && !handler.isFinished();
        

        In RegionServerSnapshotManager:

        +     * Submit a task to the pool.
        +     *
        +     * NOTE: all must be submitted before you can safely {@link #waitForOutstandingTasks()}. This
        +     * version does not support issuing tasks from multiple concurrent table snapshots requests.
        +     */
        +    void submitTask(final Callable<Void> task) {
        
        Show
        Ted Yu added a comment - In SnapshotManager: + // TODO - enable having multiple snapshots with multiple monitors/threads + // this needs to be configuration based when running multiple snapshots is implemented + /** number of current operations running on the master */ + private static final int opThreads = 1; ... + synchronized boolean isTakingSnapshot() throws SnapshotCreationException { + // TODO later when we handle multiple there would be a map with ssname to handler. + return handler != null && !handler.isFinished(); In RegionServerSnapshotManager: + * Submit a task to the pool. + * + * NOTE: all must be submitted before you can safely {@link #waitForOutstandingTasks()}. This + * version does not support issuing tasks from multiple concurrent table snapshots requests. + */ + void submitTask( final Callable< Void > task) {
        Ted Yu created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development