HBase
  1. HBase
  2. HBASE-7846

Add support for merging implicit regions in Merge tool

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: util
    • Labels:
      None

      Description

      Currently org.apache.hadoop.hbase.util.Merge needs 2 region names to be explicitly specified to perform a merge. This can be cumbersome.
      One idea for improvement is to have Merge to figure out all the adjacent regions and perform the merges.

      For example:
      regions before merge: row-10, row-20, row-30, row-40, row-50
      regions after merge: row-10, row-30, row-50

      In the above example, region names of "row-10" and "row-20" are merged to become a new bigger region of "row-10".

      1. HBASE-7846-v2-trunk.patch
        7 kB
        Jean-Marc Spaggiari
      2. HBASE-7846-v1-trunk.patch
        7 kB
        Jean-Marc Spaggiari
      3. HBASE-7846-v0-trunk.patch
        6 kB
        Jean-Marc Spaggiari

        Activity

        Hide
        Jean-Marc Spaggiari added a comment -

        I have done exactly that in something I called "MassMerger"

        I can attach it here if you want.

        There is also one option to "loop" until there is one region remaining...

        Show
        Jean-Marc Spaggiari added a comment - I have done exactly that in something I called "MassMerger" I can attach it here if you want. There is also one option to "loop" until there is one region remaining...
        Hide
        Kaufman Ng added a comment -

        Sure. Maybe that could be merged into Merge

        Show
        Kaufman Ng added a comment - Sure. Maybe that could be merged into Merge
        Hide
        Jean-Marc Spaggiari added a comment -

        Here is how I did it. Regions is constructed from MetaUtils.scanMetaRegion

        MassMerger.java
        
        

        HRegionInfo region1 = null;
        HRegionInfo region2 = null;
        for (HRegionInfo regionInfo : regions) {
        if (region1 == null)

        { region1 = regionInfo; }

        } else

        { region2 = regionInfo; }

        if ((region1 != null) && (region2 != null)) {
        regionsCount++;
        String[] args = new String[3];
        args[0] = tableName;
        args[1] = region1.getRegionNameAsString();
        args[2] = region2.getRegionNameAsString();
        System.out.println ("Merging " + region1.getRegionNameAsString() + " with " + region2.getRegionNameAsString());
        region1 = null;
        region2 = null;
        int status;
        try {
        status = ToolRunner.run(HBaseConfiguration.create(config), new Merge(), args);
        if ((System.in.available() > 0) || (status != 0))

        { return; }

        } catch (Exception e)

        { e.printStackTrace(); }

        }
        }
        }

        
        

        Pretty simple way.

        I will clean the code, and see how I can merge it into the Merge class...

        Show
        Jean-Marc Spaggiari added a comment - Here is how I did it. Regions is constructed from MetaUtils.scanMetaRegion MassMerger.java HRegionInfo region1 = null; HRegionInfo region2 = null; for (HRegionInfo regionInfo : regions) { if (region1 == null) { region1 = regionInfo; } } else { region2 = regionInfo; } if ((region1 != null) && (region2 != null)) { regionsCount++; String[] args = new String [3] ; args [0] = tableName; args [1] = region1.getRegionNameAsString(); args [2] = region2.getRegionNameAsString(); System.out.println ("Merging " + region1.getRegionNameAsString() + " with " + region2.getRegionNameAsString()); region1 = null; region2 = null; int status; try { status = ToolRunner.run(HBaseConfiguration.create(config), new Merge(), args); if ((System.in.available() > 0) || (status != 0)) { return; } } catch (Exception e) { e.printStackTrace(); } } } } Pretty simple way. I will clean the code, and see how I can merge it into the Merge class...
        Hide
        Jean-Marc Spaggiari added a comment -

        Attached patch for trunk.

        Adding 2 parameters to the merge tool. --all to merge all the regions 2 by 2 and --allrecurse to merge all the regions 2 by 2 and recuse until there is only one region remaining.

        Patch for 0.94 ready too. Will post it when trunk will be built.

        Show
        Jean-Marc Spaggiari added a comment - Attached patch for trunk. Adding 2 parameters to the merge tool. --all to merge all the regions 2 by 2 and --allrecurse to merge all the regions 2 by 2 and recuse until there is only one region remaining. Patch for 0.94 ready too. Will post it when trunk will be built.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12569810/HBASE-7846-v0-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12569810/HBASE-7846-v0-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4454//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        Fixed lineLengths issue.

        There is no unit test class for util.Merge. I tested it locally by splitting and merging many different tables.

        Show
        Jean-Marc Spaggiari added a comment - Fixed lineLengths issue. There is no unit test class for util.Merge. I tested it locally by splitting and merging many different tables.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12569862/HBASE-7846-v1-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12569862/HBASE-7846-v1-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4456//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        Cancelling to give Hadoop QA a change to re-test it.

        Show
        Jean-Marc Spaggiari added a comment - Cancelling to give Hadoop QA a change to re-test it.
        Hide
        Jean-Marc Spaggiari added a comment -

        Re-attaching for Hadoop QA

        Show
        Jean-Marc Spaggiari added a comment - Re-attaching for Hadoop QA
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12570138/HBASE-7846-v1-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12570138/HBASE-7846-v1-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4467//console This message is automatically generated.
        Hide
        Sergey Shelukhin added a comment -

        resion

        typo.

        Could merge methods accept things as parameters instead of relying on fields?
        Help should probably have full command for all/allrecurse, to make sure its clear it is the first argument.

        if (info != null) if (Bytes.compareTo(info.getTableName(), tableName) == 0) {

        &&?

        Show
        Sergey Shelukhin added a comment - resion typo. Could merge methods accept things as parameters instead of relying on fields? Help should probably have full command for all/allrecurse, to make sure its clear it is the first argument. if (info != null) if (Bytes.compareTo(info.getTableName(), tableName) == 0) { &&?
        Hide
        Jean-Marc Spaggiari added a comment -

        Hi Sergey,

        Thanks a lot for the review!

        I'm not sure to get the comment about the parameters. run() is from the interface and is called from the main. In the run() we are parsing the parameters from parseArgs which is getting the table name, regions, and other paramters if any and then directly running the merge. Can you please suggest a way? I'm not sure to get it.

        I fixed the other suggestions. Not 100% sure about the best way to display the usage.

        Show
        Jean-Marc Spaggiari added a comment - Hi Sergey, Thanks a lot for the review! I'm not sure to get the comment about the parameters. run() is from the interface and is called from the main. In the run() we are parsing the parameters from parseArgs which is getting the table name, regions, and other paramters if any and then directly running the merge. Can you please suggest a way? I'm not sure to get it. I fixed the other suggestions. Not 100% sure about the best way to display the usage.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12570399/HBASE-7846-v2-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestMultiParallel

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12570399/HBASE-7846-v2-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4492//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        Cancelling to restart Hadoop QA.

        Show
        Jean-Marc Spaggiari added a comment - Cancelling to restart Hadoop QA.
        Hide
        Jean-Marc Spaggiari added a comment -

        Triggering Hadoop QA again.

        Show
        Jean-Marc Spaggiari added a comment - Triggering Hadoop QA again.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574876/HBASE-7846-v2-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4948//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574876/HBASE-7846-v2-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4948//console This message is automatically generated.
        Hide
        chunhui shen added a comment -

        One idea for improvement is to have Merge to figure out all the adjacent regions and perform the merges.

        Should we call HRegion#mergeAdjacent instead of HRegion#merge in Merge.java for the 'all' or 'allrecurse' case ?

        Show
        chunhui shen added a comment - One idea for improvement is to have Merge to figure out all the adjacent regions and perform the merges. Should we call HRegion#mergeAdjacent instead of HRegion#merge in Merge.java for the 'all' or 'allrecurse' case ?
        Hide
        Jimmy Xiang added a comment -

        Should we call HRegion#mergeAdjacent instead of HRegion#merge in Merge.java for the 'all' or 'allrecurse' case ?

        +1

        By the way, there is some good feature in HMerge: merge some small regions. Should we get it into the merge tool?

        Show
        Jimmy Xiang added a comment - Should we call HRegion#mergeAdjacent instead of HRegion#merge in Merge.java for the 'all' or 'allrecurse' case ? +1 By the way, there is some good feature in HMerge: merge some small regions. Should we get it into the merge tool?
        Hide
        Jean-Marc Spaggiari added a comment -

        No activity here and I think with online merge available in 0.96 there will not be any traction.
        Kaufman Ng d you mind if I close this JIRA?

        Show
        Jean-Marc Spaggiari added a comment - No activity here and I think with online merge available in 0.96 there will not be any traction. Kaufman Ng d you mind if I close this JIRA?
        Hide
        Kaufman Ng added a comment -

        I am good with online merge. Let's close this.

        Show
        Kaufman Ng added a comment - I am good with online merge. Let's close this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12574876/HBASE-7846-v2-trunk.patch
        against trunk revision .
        ATTACHMENT ID: 12574876

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8213//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12574876/HBASE-7846-v2-trunk.patch against trunk revision . ATTACHMENT ID: 12574876 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8213//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        0.96 already has an online merge and we already have an offline merge in 0.94.

        Show
        Jean-Marc Spaggiari added a comment - 0.96 already has an online merge and we already have an offline merge in 0.94.

          People

          • Assignee:
            Jean-Marc Spaggiari
            Reporter:
            Kaufman Ng
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development