HBase
  1. HBase
  2. HBASE-7805

Scan of same region processed serially if table has region observer coprocessor

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: 0.94.4
    • Fix Version/s: None
    • Component/s: Coprocessors, Scanners
    • Labels:
      None

      Description

      If multiple scans to different parts of the same region are executed in parallel, they are processed serially if the table has a region observer coprocessor.

      1. ParallelScanTest.java
        6 kB
        James Taylor
      2. ParallelScanTestCoProc.java
        2 kB
        James Taylor
      3. 7805-trunk.txt
        11 kB
        Ted Yu
      4. 7805-0.94.patch
        11 kB
        Andrew Purtell
      5. 7805-trunk-v2.txt
        11 kB
        Ted Yu
      6. ParallelScanTest.java
        6 kB
        James Taylor
      7. ParallelScanTestCoProc.java
        3 kB
        James Taylor

        Activity

        Hide
        James Taylor added a comment -

        Updated test to move the start of the timing to the right place and ensured coprocessor configured correctly so that its used in 0.94.5.

        Show
        James Taylor added a comment - Updated test to move the start of the timing to the right place and ensured coprocessor configured correctly so that its used in 0.94.5.
        Hide
        Lars Hofhansl added a comment -

        If the data is in cache and we have a multi core machine I would expect that scanning 1/2 the rows with two scanners yield a close to 2x improvement. So there's still some internal friction to be removed.
        James, let's run this through the profiler tomorrow to see whether we can pinpoint that friction.

        Show
        Lars Hofhansl added a comment - If the data is in cache and we have a multi core machine I would expect that scanning 1/2 the rows with two scanners yield a close to 2x improvement. So there's still some internal friction to be removed. James, let's run this through the profiler tomorrow to see whether we can pinpoint that friction.
        Hide
        James Taylor added a comment -

        The coprocessor time will be much faster - they're running the scan completely on the server side and only returning a single row back to the client (mimicing what Phoenix does for an ungrouped aggregate query). Still not using the enhancements that Lars added, so the number will get better after that.

        The 0.94.2 numbers are fine, but my coprocessor wasn't being used for the 0.94.5 run. The jar path needs to be specified as null or else the coprocessor is silently ignored. The updated number are below (nice improvement on the non coprocessor case for 0.94.5):

        10,000,000 rows
        ===============
        v 0.94.2 (@1395367)
        -------------------
        With coprocessors
        Serial time: 5352, Parallel time: 3548 (66%)
        Without coprocessors
        Serial time: 13442, Parallel time: 7456 (55%)

        v 0.94.5 (latest)
        -----------------
        With coprocessors
        Serial time: 5089, Parallel time: 3604 (71%)
        Without coprocessors
        Serial time: 9711, Parallel time: 6226 (64%)

        Show
        James Taylor added a comment - The coprocessor time will be much faster - they're running the scan completely on the server side and only returning a single row back to the client (mimicing what Phoenix does for an ungrouped aggregate query). Still not using the enhancements that Lars added, so the number will get better after that. The 0.94.2 numbers are fine, but my coprocessor wasn't being used for the 0.94.5 run. The jar path needs to be specified as null or else the coprocessor is silently ignored. The updated number are below (nice improvement on the non coprocessor case for 0.94.5): 10,000,000 rows =============== v 0.94.2 (@1395367) ------------------- With coprocessors Serial time: 5352, Parallel time: 3548 (66%) Without coprocessors Serial time: 13442, Parallel time: 7456 (55%) v 0.94.5 (latest) ----------------- With coprocessors Serial time: 5089, Parallel time: 3604 (71%) Without coprocessors Serial time: 9711, Parallel time: 6226 (64%)
        Hide
        Ted Yu added a comment -

        @James:
        Can you confirm that the labels for 0.94.2 statistics are right ?
        I thought performance with coprocessors should be slower.

        Thanks

        Show
        Ted Yu added a comment - @James: Can you confirm that the labels for 0.94.2 statistics are right ? I thought performance with coprocessors should be slower. Thanks
        Hide
        James Taylor added a comment -

        Ted is right - the start time should have been before the exec.submit() call. With this change, I'm not seeing a significant difference between 0.94.2 and 0.94.5 - both are fine. Something else is going on - might be in the Phoenix layer. I'll try to get to the bottom of it on Monday.

        10,000,000 rows
        ===============
        v 0.94.2 (@1395367)
        -------------------
        With coprocessors
        Serial time: 5352, Parallel time: 3548 (66%)

        Without coprocessors
        Serial time: 13442, Parallel time: 7456 (55%)

        v 0.94.5 (latest)
        -----------------
        With coprocessors
        Serial time: 9921, Parallel time: 6316 (64%)

        Without coprocessors
        Serial time: 9711, Parallel time: 6226 (64%)

        Show
        James Taylor added a comment - Ted is right - the start time should have been before the exec.submit() call. With this change, I'm not seeing a significant difference between 0.94.2 and 0.94.5 - both are fine. Something else is going on - might be in the Phoenix layer. I'll try to get to the bottom of it on Monday. 10,000,000 rows =============== v 0.94.2 (@1395367) ------------------- With coprocessors Serial time: 5352, Parallel time: 3548 (66%) Without coprocessors Serial time: 13442, Parallel time: 7456 (55%) v 0.94.5 (latest) ----------------- With coprocessors Serial time: 9921, Parallel time: 6316 (64%) Without coprocessors Serial time: 9711, Parallel time: 6226 (64%)
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568764/7805-trunk-v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568764/7805-trunk-v2.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4407//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568761/7805-0.94.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568761/7805-0.94.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4406//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        If 0.94 tests output both serial and parallel runtime statistics upon failure, that would help us gauge performance characteristics in various scenarios.
        By raising amplifier to 7/4 I could get the test to fail:

        Failed tests:   testParallelScanAgainstSameRegionWithCoProc(org.apache.hadoop.hbase.client.TestParallelScan): serial 305, parallel 186
          testParallelScanAgainstSameRegion(org.apache.hadoop.hbase.client.TestParallelScan): serial 223, parallel 133
        

        Good news is that parallel scanning is faster than serial.
        But as James found out, the presence of region observer does slow down the overall performance.

        Show
        Ted Yu added a comment - If 0.94 tests output both serial and parallel runtime statistics upon failure, that would help us gauge performance characteristics in various scenarios. By raising amplifier to 7/4 I could get the test to fail: Failed tests: testParallelScanAgainstSameRegionWithCoProc(org.apache.hadoop.hbase.client.TestParallelScan): serial 305, parallel 186 testParallelScanAgainstSameRegion(org.apache.hadoop.hbase.client.TestParallelScan): serial 223, parallel 133 Good news is that parallel scanning is faster than serial. But as James found out, the presence of region observer does slow down the overall performance.
        Hide
        Andrew Purtell added a comment -

        With the 0.94 patch adjusted with Ted's v2, both tests fail reliably, so I think we need to actually check if the scans are running in parallel as opposed to relying on wall clock time. I was running a find command in the background but tried it one more time with a quiesced system and had the same failure.

        Running org.apache.hadoop.hbase.client.TestParallelScan
        Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 47.608 sec <<< FAILURE!
        
        Results :
        
        Failed tests:   testParallelScanAgainstSameRegion(org.apache.hadoop.hbase.client.TestParallelScan)
          testParallelScanAgainstSameRegionWithCoProc(org.apache.hadoop.hbase.client.TestParallelScan)
        
        Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
        
        testParallelScanAgainstSameRegion(org.apache.hadoop.hbase.client.TestParallelScan)  Time elapsed: 31.118 sec  <<< FAILURE!
        java.lang.AssertionError
                at org.junit.Assert.fail(Assert.java:92)
                at org.junit.Assert.assertTrue(Assert.java:43)
                at org.junit.Assert.assertTrue(Assert.java:54)
                at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegion(TestParallelScan.java:121)
                at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegion(TestParallelScan.java:53)
        
        testParallelScanAgainstSameRegionWithCoProc(org.apache.hadoop.hbase.client.TestParallelScan)  Time elapsed: 16.411 sec  <<< FAILURE!
        java.lang.AssertionError
                at org.junit.Assert.fail(Assert.java:92)
                at org.junit.Assert.assertTrue(Assert.java:43)
                at org.junit.Assert.assertTrue(Assert.java:54)
                at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegion(TestParallelScan.java:121)
                at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegionWithCoProc(TestParallelScan.java:60)
        
        Show
        Andrew Purtell added a comment - With the 0.94 patch adjusted with Ted's v2, both tests fail reliably, so I think we need to actually check if the scans are running in parallel as opposed to relying on wall clock time. I was running a find command in the background but tried it one more time with a quiesced system and had the same failure. Running org.apache.hadoop.hbase.client.TestParallelScan Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 47.608 sec <<< FAILURE! Results : Failed tests: testParallelScanAgainstSameRegion(org.apache.hadoop.hbase.client.TestParallelScan) testParallelScanAgainstSameRegionWithCoProc(org.apache.hadoop.hbase.client.TestParallelScan) Tests run: 2, Failures: 2, Errors: 0, Skipped: 0 testParallelScanAgainstSameRegion(org.apache.hadoop.hbase.client.TestParallelScan) Time elapsed: 31.118 sec <<< FAILURE! java.lang.AssertionError at org.junit.Assert.fail(Assert.java:92) at org.junit.Assert.assertTrue(Assert.java:43) at org.junit.Assert.assertTrue(Assert.java:54) at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegion(TestParallelScan.java:121) at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegion(TestParallelScan.java:53) testParallelScanAgainstSameRegionWithCoProc(org.apache.hadoop.hbase.client.TestParallelScan) Time elapsed: 16.411 sec <<< FAILURE! java.lang.AssertionError at org.junit.Assert.fail(Assert.java:92) at org.junit.Assert.assertTrue(Assert.java:43) at org.junit.Assert.assertTrue(Assert.java:54) at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegion(TestParallelScan.java:121) at org.apache.hadoop.hbase.client.TestParallelScan.testParallelScanAgainstSameRegionWithCoProc(TestParallelScan.java:60)
        Hide
        Ted Yu added a comment -

        Trunk patch v2 replaces System.out with LOG.
        Also moved the position of starting time recording to before exec.submit() call.

        Show
        Ted Yu added a comment - Trunk patch v2 replaces System.out with LOG. Also moved the position of starting time recording to before exec.submit() call.
        Hide
        Andrew Purtell added a comment - - edited
            // Somewhat arbitrary, but parallel time must be at least 25% less than serial time
            assertTrue(parallelTime * 5 / 4 < serialTime);
        

        Try replacing this assertion with something that doesn't rely on wall clock time?

        Show
        Andrew Purtell added a comment - - edited // Somewhat arbitrary, but parallel time must be at least 25% less than serial time assertTrue(parallelTime * 5 / 4 < serialTime); Try replacing this assertion with something that doesn't rely on wall clock time?
        Hide
        Ted Yu added a comment -

        Here was runtime statistics from one local run (without additional load):
        testParallelScanAgainstSameRegionWithCoProc - serial: 285ms, parallel: 157ms
        testParallelScanAgainstSameRegion - serial: 222ms, parallel: 135ms

        Meaning the amplifier can be as high as ~1.8

        Show
        Ted Yu added a comment - Here was runtime statistics from one local run (without additional load): testParallelScanAgainstSameRegionWithCoProc - serial: 285ms, parallel: 157ms testParallelScanAgainstSameRegion - serial: 222ms, parallel: 135ms Meaning the amplifier can be as high as ~1.8
        Hide
        Andrew Purtell added a comment -

        Yes, after introducing some additional load on my laptop I can get TestParallelScan to fail occasionally.

        Show
        Andrew Purtell added a comment - Yes, after introducing some additional load on my laptop I can get TestParallelScan to fail occasionally.
        Hide
        Andrew Purtell added a comment -

        Hang on. As soon as I said that something odd happened. Maybe Eclipse stomped on Surefire. Let me check it out.

        Show
        Andrew Purtell added a comment - Hang on. As soon as I said that something odd happened. Maybe Eclipse stomped on Surefire. Let me check it out.
        Hide
        Andrew Purtell added a comment -

        Patch against 0.94 r1444578 too. Test passes locally over 100 invocations.

        Let's commit the new tests.

        Show
        Andrew Purtell added a comment - Patch against 0.94 r1444578 too. Test passes locally over 100 invocations. Let's commit the new tests.
        Hide
        Lars Hofhansl added a comment -

        I am happy to claim that my change fixed this problem But it won't have an effect if all data is in the blockcache. You might have run into HBASE-5898.

        Would be good if HBase had a base impl class that implementors of coprocessors could derive from to shield (at least partially) interface changes like the one to RegionScanner between 0.94.2 and 0.94.4.

        We could a BaseRegionScanner with reasonable defaults. In a coprocessor you'd subclass that.

        Show
        Lars Hofhansl added a comment - I am happy to claim that my change fixed this problem But it won't have an effect if all data is in the blockcache. You might have run into HBASE-5898 . Would be good if HBase had a base impl class that implementors of coprocessors could derive from to shield (at least partially) interface changes like the one to RegionScanner between 0.94.2 and 0.94.4. We could a BaseRegionScanner with reasonable defaults. In a coprocessor you'd subclass that.
        Hide
        Ted Yu added a comment -

        HRegion has the following:

          class RegionScannerImpl implements RegionScanner {
        

        It is package private. Can you utilize the above ?

        Show
        Ted Yu added a comment - HRegion has the following: class RegionScannerImpl implements RegionScanner { It is package private. Can you utilize the above ?
        Hide
        James Taylor added a comment -

        I had compiled against 94.2 - sorry about that. I can't get it to fail either on the latest 0.94, though the test does ensure that the rows are in the block cache, maybe HBASE-7336 fixed more than Lars thought. Good news. Will do some more testing on Monday and upgrade Phoenix to run on 0.94.4.

        Would be good if HBase had a base impl class that implementors of coprocessors could derive from to shield (at least partially) interface changes like the one to RegionScanner between 0.94.2 and 0.94.4.

        Show
        James Taylor added a comment - I had compiled against 94.2 - sorry about that. I can't get it to fail either on the latest 0.94, though the test does ensure that the rows are in the block cache, maybe HBASE-7336 fixed more than Lars thought. Good news. Will do some more testing on Monday and upgrade Phoenix to run on 0.94.4. Would be good if HBase had a base impl class that implementors of coprocessors could derive from to shield (at least partially) interface changes like the one to RegionScanner between 0.94.2 and 0.94.4.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568754/7805-trunk.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568754/7805-trunk.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4405//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568752/7805-trunk.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestCheckTestClasses

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568752/7805-trunk.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestCheckTestClasses Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4404//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Trunk patch that compiles.

        I couldn't get it to fail.

        Show
        Ted Yu added a comment - Trunk patch that compiles. I couldn't get it to fail.
        Hide
        Ted Yu added a comment -

        I got the following compilation error when putting the 2 attached files in trunk or 0.94:

        [ERROR] /Users/tyu/94-hbase/src/test/java/org/apache/hadoop/hbase/client/ParallelScanTestCoProc.java:[29,52] <anonymous org.apache.hadoop.hbase.client.ParallelScanTestCoProc$1> is not abstract and does not override abstract method nextRaw(java.util.List<org.apache.hadoop.hbase.KeyValue>,int,java.lang.String) in org.apache.hadoop.hbase.regionserver.RegionScanner

        Show
        Ted Yu added a comment - I got the following compilation error when putting the 2 attached files in trunk or 0.94: [ERROR] /Users/tyu/94-hbase/src/test/java/org/apache/hadoop/hbase/client/ParallelScanTestCoProc.java: [29,52] <anonymous org.apache.hadoop.hbase.client.ParallelScanTestCoProc$1> is not abstract and does not override abstract method nextRaw(java.util.List<org.apache.hadoop.hbase.KeyValue>,int,java.lang.String) in org.apache.hadoop.hbase.regionserver.RegionScanner

          People

          • Assignee:
            Unassigned
            Reporter:
            James Taylor
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development