HBase
  1. HBase
  2. HBASE-7785

rolling-restart.sh script unable to check expiration of master znode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.4
    • Fix Version/s: 0.94.5, 0.95.0
    • Component/s: scripts
    • Labels:
      None
    • Environment:

      Linux CentOS release 5.8

      Description

      When rolling-restart.sh script stop master it enters loop trying to detect that master znode is deleted. Since it is unable to execute check command script hangs in infinite loop. Problematic line of script is:

      while ! bin/hbase zkcli stat $zmaster 2>&1 | grep "Node does not exist"; do

      "bin/hbase zkcli stat" can not be executed since script is run from bin directory. My suggestion is that this line should be like this in order to work:

      while ! "$bin"/hbase zkcli stat $zmaster 2>&1 | grep "Node does not exist"; do

      After i made this change i was able to execute rolling restart.

      1. HBASE-7785.txt
        0.4 kB
        Samir Ahmic

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #12 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/12/)
        HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443660)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/bin/rolling-restart.sh
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #12 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/12/ ) HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443660) Result = FAILURE larsh : Files : /hbase/branches/0.94/bin/rolling-restart.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #109 (See https://builds.apache.org/job/HBase-0.94-security/109/)
        HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443660)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/bin/rolling-restart.sh
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #109 (See https://builds.apache.org/job/HBase-0.94-security/109/ ) HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443660) Result = SUCCESS larsh : Files : /hbase/branches/0.94/bin/rolling-restart.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #397 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/397/)
        HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443659)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/bin/rolling-restart.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #397 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/397/ ) HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443659) Result = FAILURE larsh : Files : /hbase/trunk/bin/rolling-restart.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3862 (See https://builds.apache.org/job/HBase-TRUNK/3862/)
        HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443659)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/bin/rolling-restart.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3862 (See https://builds.apache.org/job/HBase-TRUNK/3862/ ) HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443659) Result = FAILURE larsh : Files : /hbase/trunk/bin/rolling-restart.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #832 (See https://builds.apache.org/job/HBase-0.94/832/)
        HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443660)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/bin/rolling-restart.sh
        Show
        Hudson added a comment - Integrated in HBase-0.94 #832 (See https://builds.apache.org/job/HBase-0.94/832/ ) HBASE-7785 rolling-restart.sh script unable to check expiration of master znode (Samir Ahmic) (Revision 1443660) Result = SUCCESS larsh : Files : /hbase/branches/0.94/bin/rolling-restart.sh
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 and 0.96. Thanks for the patch.

        Show
        Lars Hofhansl added a comment - Committed to 0.94 and 0.96. Thanks for the patch.
        Hide
        Lars Hofhansl added a comment -

        Yep. We do this everywhere else in this script. This is the only exception.
        Going to commit in a few.

        Show
        Lars Hofhansl added a comment - Yep. We do this everywhere else in this script. This is the only exception. Going to commit in a few.
        Hide
        Samir Ahmic added a comment -

        Here is diff for change

        Show
        Samir Ahmic added a comment - Here is diff for change

          People

          • Assignee:
            Samir Ahmic
            Reporter:
            Samir Ahmic
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development