HBase
  1. HBase
  2. HBASE-7601

Fix 8 remaining EQ findbug warnings from hbase-server.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-7601-v0-trunk.patch
      7 kB
      Jean-Marc Spaggiari
    2. HBASE-7601-v1-trunk.patch
      7 kB
      Jean-Marc Spaggiari
    3. HBASE-7601-v2-trunk.patch
      7 kB
      Jean-Marc Spaggiari
    4. HBASE-7601-v3-trunk.patch
      6 kB
      Jean-Marc Spaggiari

      Activity

      Hide
      Jean-Marc Spaggiari added a comment -

      Some small fixed to avoid FindBugs EQ warnings on hbase-server.

      Show
      Jean-Marc Spaggiari added a comment - Some small fixed to avoid FindBugs EQ warnings on hbase-server.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565230/HBASE-7601-v0-trunk.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.regionserver.TestJoinedScanners
      org.apache.hadoop.hbase.regionserver.TestCompactionState
      org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk

      -1 core zombie tests. There are 4 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:321)
      at org.apache.hadoop.hbase.client.TestAdmin.testDisableAndEnableTable(TestAdmin.java:228)
      at org.apache.hadoop.hbase.TestAcidGuarantees.testScanAtomicity(TestAcidGuarantees.java:332)
      at org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:321)

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565230/HBASE-7601-v0-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestJoinedScanners org.apache.hadoop.hbase.regionserver.TestCompactionState org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk -1 core zombie tests . There are 4 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:321) at org.apache.hadoop.hbase.client.TestAdmin.testDisableAndEnableTable(TestAdmin.java:228) at org.apache.hadoop.hbase.TestAcidGuarantees.testScanAtomicity(TestAcidGuarantees.java:332) at org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:321) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4062//console This message is automatically generated.
      Hide
      Jean-Marc Spaggiari added a comment -

      Failing on the mvn tests because of loops between CompactionRequest.equals ans CompactionRequest.compareTo...

      Show
      Jean-Marc Spaggiari added a comment - Failing on the mvn tests because of loops between CompactionRequest.equals ans CompactionRequest.compareTo...
      Hide
      Jean-Marc Spaggiari added a comment -

      Loops between CompactionRequest.equals and CompactionRequest.compareTo fixed. Fixing 8 findbug warnings.

      Show
      Jean-Marc Spaggiari added a comment - Loops between CompactionRequest.equals and CompactionRequest.compareTo fixed. Fixing 8 findbug warnings.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565368/HBASE-7601-v1-trunk.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      -1 core tests. The patch failed these unit tests:

      -1 core zombie tests. There are 1 zombie test(s):

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565368/HBASE-7601-v1-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//console This message is automatically generated.
      Hide
      Jean-Marc Spaggiari added a comment -

      Working fine for me with the last trunk version and my patch applied to it:
      [INFO] ------------------------------------------------------------------------
      [INFO] Reactor Summary:
      [INFO]
      [INFO] HBase ............................................. SUCCESS [1.728s]
      [INFO] HBase - Common .................................... SUCCESS [11.548s]
      [INFO] HBase - Protocol .................................. SUCCESS [10.042s]
      [INFO] HBase - Client .................................... SUCCESS [0.549s]
      [INFO] HBase - Hadoop Compatibility ...................... SUCCESS [0.428s]
      [INFO] HBase - Hadoop One Compatibility .................. SUCCESS [0.973s]
      [INFO] HBase - Server .................................... SUCCESS [55:13.963s]
      [INFO] HBase - Hadoop Two Compatibility .................. SUCCESS [2.663s]
      [INFO] HBase - Integration Tests ......................... SUCCESS [1.536s]
      [INFO] HBase - Examples .................................. SUCCESS [40.433s]
      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD SUCCESS
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 56:24.466s
      [INFO] Finished at: Fri Jan 18 11:38:48 EST 2013
      [INFO] Final Memory: 88M/1294M
      [INFO] ------------------------------------------------------------------------

      Also, this is correctly fixing the EQ issues: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html#Warnings_BAD_PRACTICE

      When patch will applied I will start to work on the HE issuies, and so on. Goal is to get findbug warnings down to 0.

      Show
      Jean-Marc Spaggiari added a comment - Working fine for me with the last trunk version and my patch applied to it: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] HBase ............................................. SUCCESS [1.728s] [INFO] HBase - Common .................................... SUCCESS [11.548s] [INFO] HBase - Protocol .................................. SUCCESS [10.042s] [INFO] HBase - Client .................................... SUCCESS [0.549s] [INFO] HBase - Hadoop Compatibility ...................... SUCCESS [0.428s] [INFO] HBase - Hadoop One Compatibility .................. SUCCESS [0.973s] [INFO] HBase - Server .................................... SUCCESS [55:13.963s] [INFO] HBase - Hadoop Two Compatibility .................. SUCCESS [2.663s] [INFO] HBase - Integration Tests ......................... SUCCESS [1.536s] [INFO] HBase - Examples .................................. SUCCESS [40.433s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 56:24.466s [INFO] Finished at: Fri Jan 18 11:38:48 EST 2013 [INFO] Final Memory: 88M/1294M [INFO] ------------------------------------------------------------------------ Also, this is correctly fixing the EQ issues: https://builds.apache.org/job/PreCommit-HBASE-Build/4076//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html#Warnings_BAD_PRACTICE When patch will applied I will start to work on the HE issuies, and so on. Goal is to get findbug warnings down to 0.
      Hide
      Jean-Marc Spaggiari added a comment -

      Update patch attached addressing all Ted's comments but one. Also removed many extra spaces.

      https://reviews.apache.org/r/9018/

      Show
      Jean-Marc Spaggiari added a comment - Update patch attached addressing all Ted's comments but one. Also removed many extra spaces. https://reviews.apache.org/r/9018/
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565518/HBASE-7601-v2-trunk.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565518/HBASE-7601-v2-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4085//console This message is automatically generated.
      Hide
      Ted Yu added a comment -

      +1 on latest patch.

      Show
      Ted Yu added a comment - +1 on latest patch.
      Hide
      stack added a comment -

      JM, mind fixing the likes of the below. In hbase codebase, the 'false' gets curly braces around it.

       12 +    if (obj == null || getClass() != obj.getClass())
       13 +      return false;
      

      Also, you seem to add some imports though they are not used 'Delayed' and 'Row'.

      Is this right in NullComparator?

      16 +  public boolean equals(Object obj) {
       17 +    return obj == null;
       18 +  }
      

      Thanks for doing these findbug issues. I'll update our tolerated findbugs count after this goes in. It is falling fast.

      Show
      stack added a comment - JM, mind fixing the likes of the below. In hbase codebase, the 'false' gets curly braces around it. 12 + if (obj == null || getClass() != obj.getClass()) 13 + return false ; Also, you seem to add some imports though they are not used 'Delayed' and 'Row'. Is this right in NullComparator? 16 + public boolean equals( Object obj) { 17 + return obj == null ; 18 + } Thanks for doing these findbug issues. I'll update our tolerated findbugs count after this goes in. It is falling fast.
      Hide
      Jean-Marc Spaggiari added a comment -

      Update version with additionnal brackets attached.

      Regarding the NullComparator, here is the compareTo code:

        @Override
        public int compareTo(byte[] value) {
          return value != null ? 1 : 0;
        }
      

      It's return equels only if the given byte array is null. So I have replicated the same behaviour on the equalsTo methode.

      I have more modifications coming to fix other findbug issues. I will try to get them down one by one...

      Show
      Jean-Marc Spaggiari added a comment - Update version with additionnal brackets attached. Regarding the NullComparator, here is the compareTo code: @Override public int compareTo( byte [] value) { return value != null ? 1 : 0; } It's return equels only if the given byte array is null. So I have replicated the same behaviour on the equalsTo methode. I have more modifications coming to fix other findbug issues. I will try to get them down one by one...
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565623/HBASE-7601-v3-trunk.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.TestLocalHBaseCluster

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565623/HBASE-7601-v3-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4100//console This message is automatically generated.
      Hide
      stack added a comment -

      Committed to trunk. Thanks for the patch JM. Hadoopqa says this patch introduces one findbugs issue which I guess means we are over the limit because of some other patch added recently ... since this patch squashes findbugs warnings. Thanks JM.

      Show
      stack added a comment - Committed to trunk. Thanks for the patch JM. Hadoopqa says this patch introduces one findbugs issue which I guess means we are over the limit because of some other patch added recently ... since this patch squashes findbugs warnings. Thanks JM.
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #3769 (See https://builds.apache.org/job/HBase-TRUNK/3769/)
      HBASE-7601 Fix 8 remaining EQ findbug warnings from hbase-server. (Revision 1435487)

      Result = FAILURE
      stack :
      Files :

      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Action.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlan.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #3769 (See https://builds.apache.org/job/HBase-TRUNK/3769/ ) HBASE-7601 Fix 8 remaining EQ findbug warnings from hbase-server. (Revision 1435487) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Action.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlan.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #361 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/361/)
      HBASE-7601 Fix 8 remaining EQ findbug warnings from hbase-server. (Revision 1435487)

      Result = FAILURE
      stack :
      Files :

      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Action.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlan.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #361 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/361/ ) HBASE-7601 Fix 8 remaining EQ findbug warnings from hbase-server. (Revision 1435487) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Action.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlan.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
      Hide
      stack added a comment -

      Marking closed.

      Show
      stack added a comment - Marking closed.

        People

        • Assignee:
          Jean-Marc Spaggiari
          Reporter:
          Jean-Marc Spaggiari
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development