HBase
  1. HBase
  2. HBASE-7553

TestServerCustomProtocol depends on the test methods execution order

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: test
    • Labels:
      None

      Description

      This breaks with JUnit 4.11 and could break the test JDK 1.7

      1. 7553.v1.patch
        2 kB
        Nicolas Liochon

        Issue Links

          Activity

          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.
          Hide
          Andrew Purtell added a comment -

          I withdraw the suggestion then

          Fair enough. Wasn't my intent to go all process on you, just to say I wouldn't mind commits like on this jira without review. Like you say, Jenkins is the reviewer that matters when dealing with test failures.

          Show
          Andrew Purtell added a comment - I withdraw the suggestion then Fair enough. Wasn't my intent to go all process on you, just to say I wouldn't mind commits like on this jira without review. Like you say, Jenkins is the reviewer that matters when dealing with test failures.
          Hide
          stack added a comment -

          Andrew Purtell I withdraw the suggestion then. I was thinking that nkeywal on this test task could just go ahead and commit... didn't mean to institute new policy I can see how it would get out of hand so would rather withdraw my suggestion.

          Show
          stack added a comment - Andrew Purtell I withdraw the suggestion then. I was thinking that nkeywal on this test task could just go ahead and commit... didn't mean to institute new policy I can see how it would get out of hand so would rather withdraw my suggestion.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #347 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/347/)
          HBASE-7553 TestServerCustomProtocol depends on the test methods execution order (Revision 1433014)

          Result = FAILURE
          nkeywal :
          Files :

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #347 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/347/ ) HBASE-7553 TestServerCustomProtocol depends on the test methods execution order (Revision 1433014) Result = FAILURE nkeywal : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
          Hide
          Andrew Purtell added a comment -

          +1 on CTR for test only fixes. Does that need discussion?

          Show
          Andrew Purtell added a comment - +1 on CTR for test only fixes. Does that need discussion?
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3742 (See https://builds.apache.org/job/HBase-TRUNK/3742/)
          HBASE-7553 TestServerCustomProtocol depends on the test methods execution order (Revision 1433014)

          Result = FAILURE
          nkeywal :
          Files :

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3742 (See https://builds.apache.org/job/HBase-TRUNK/3742/ ) HBASE-7553 TestServerCustomProtocol depends on the test methods execution order (Revision 1433014) Result = FAILURE nkeywal : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
          Hide
          Nicolas Liochon added a comment -

          Ok. Committed.

          Thanks for the review!

          Show
          Nicolas Liochon added a comment - Ok. Committed. Thanks for the review!
          Hide
          stack added a comment -

          +1

          I'd say just go ahead and commit test changes w/o waiting on +1s. Its easy to see if you have messed up (smile).

          Show
          stack added a comment - +1 I'd say just go ahead and commit test changes w/o waiting on +1s. Its easy to see if you have messed up (smile).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12564705/7553.v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564705/7553.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4000//console This message is automatically generated.
          Hide
          Nicolas Liochon added a comment -

          trivial, worked locally 10 times, I will commit it is precommit is ok and there is no objection.

          Show
          Nicolas Liochon added a comment - trivial, worked locally 10 times, I will commit it is precommit is ok and there is no objection.

            People

            • Assignee:
              Nicolas Liochon
              Reporter:
              Nicolas Liochon
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development