Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7545

[replication] Break out TestReplication into manageable classes

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.5, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This has been discussed before but after trying to debug the last failure on Jenkins where I saw the time go back and forth (if you don't care about your own sanity do checkout https://builds.apache.org/job/HBase-TRUNK/3726/testReport/junit/org.apache.hadoop.hbase.replication/TestReplicationWithCompression/testDeleteTypes/) I think it is time to break out TestReplication.

      The difficulty is that the setup for the 2 clusters is a lot of code I don't want to duplicate. I'm thinking that we can keep setUpBeforeClass there and have the other classes extend TestReplication (which should also change name). I'm thinking of the following new classes:

      • TestReplicationSmallTests, contains the easy methods that don't mess around too much.
      • TestReplicationQueueFailover, contains one test of the same name
      • TestReplicationDisableInactivePeer, contains one test of the same name
      • Rename TestReplicationWithCompression TestReplicationQueueFailoverWithCompression and make it extends TestReplicationQueueFailover.

        Attachments

        1. 7545-0.94.txt
          62 kB
          Lars Hofhansl
        2. 7545-0.94-v1.txt
          62 kB
          Lars Hofhansl
        3. better_retries.patch
          1 kB
          Jean-Daniel Cryans
        4. HBASE-7545.patch
          63 kB
          Jean-Daniel Cryans

          Activity

            People

            • Assignee:
              jdcryans Jean-Daniel Cryans
              Reporter:
              jdcryans Jean-Daniel Cryans
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: