HBase
  1. HBase
  2. HBASE-7490

dev-support script to generate protobuf code.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a helper script that I've been using for a while to generate the protobuf code.

      1. hbase-7490.v2.patch
        1 kB
        Jonathan Hsieh
      2. hbase-7490.patch
        1 kB
        Jonathan Hsieh

        Activity

        Hide
        Jonathan Hsieh added a comment -

        ran the script from various directories

        ~/proj/hbase
        ~/proj/hbase/dev-support
        ~/

        Also faked removing protoc from the path and it reports nice message.

        Show
        Jonathan Hsieh added a comment - ran the script from various directories ~/proj/hbase ~/proj/hbase/dev-support ~/ Also faked removing protoc from the path and it reports nice message.
        Hide
        Jonathan Hsieh added a comment -

        fixed comment bug

        Show
        Jonathan Hsieh added a comment - fixed comment bug
        Hide
        Andrew Purtell added a comment -

        +1

        Show
        Andrew Purtell added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563148/hbase-7490.v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563148/hbase-7490.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3834//console This message is automatically generated.
        Hide
        Jonathan Hsieh added a comment -

        thanks for the quick looksee andrew. committed to trunk.

        Show
        Jonathan Hsieh added a comment - thanks for the quick looksee andrew. committed to trunk.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #328 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/328/)
        HBASE-7490 dev-support script to generate protobuf code (Revision 1428628)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/dev-support/build-proto.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #328 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/328/ ) HBASE-7490 dev-support script to generate protobuf code (Revision 1428628) Result = FAILURE jmhsieh : Files : /hbase/trunk/dev-support/build-proto.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3693 (See https://builds.apache.org/job/HBase-TRUNK/3693/)
        HBASE-7490 dev-support script to generate protobuf code (Revision 1428628)

        Result = FAILURE
        jmhsieh :
        Files :

        • /hbase/trunk/dev-support/build-proto.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3693 (See https://builds.apache.org/job/HBase-TRUNK/3693/ ) HBASE-7490 dev-support script to generate protobuf code (Revision 1428628) Result = FAILURE jmhsieh : Files : /hbase/trunk/dev-support/build-proto.sh
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.

          People

          • Assignee:
            Jonathan Hsieh
            Reporter:
            Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development