[HBASE-7430] TestSnapshotDescriptionUtils break compaction/scanner tests (EnvironmentEdge issue)

• Type: Sub-task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: hbase-6055
• Fix Version/s: 0.95.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Matteo Bertozzi
• Reporter: Matteo Bertozzi
• Created: 23/Dec/12 21:34
• Updated: 23/Sep/13 18:30
• Resolved: 24/Dec/12 03:54

Description

I've some tests failing due to TestSnapshotDescriptionUtils.testValidateDescriptor()
the problem is related to the EnvironmentEdgeManager.injectEdge() that is not restored, at the end of the test.

I think that the main problem is (HBASE-5048) that we're still mixing System.currentTimeMillis() and EnvironmentEdgeManager.currentTimeMillis()

so, using EnvEdge.reset() can still have some problem ~1ms skew with the timeMillis()

All the tests that uses EnvEdge.injectEdge() are MediumTest, so they are running in a different JVM, and everything is fine. This one is SmallTest as the other one playing with compaction and scanner.

org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[0]
org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[1]
org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[2]
org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[3]
org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[4]
org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[5]
org.apache.hadoop.hbase.regionserver.TestCompaction.testMajorCompaction
org.apache.hadoop.hbase.regionserver.TestCompaction.testDataBlockEncodingInCacheOnly
org.apache.hadoop.hbase.regionserver.TestCompaction.testDataBlockEncodingEverywhere
org.apache.hadoop.hbase.regionserver.TestCompaction.testMinorCompactionWithDeleteRow
org.apache.hadoop.hbase.regionserver.TestCompaction.testMinorCompactionWithDeleteColumn1
org.apache.hadoop.hbase.regionserver.TestCompaction.testMinorCompactionWithDeleteColumnFamily
org.apache.hadoop.hbase.regionserver.TestCompaction.testInterruptCompaction
org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testBasicScenario
org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testRawScanWithoutKeepingDeletes
org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testWithoutKeepingDeletes
org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testDeleteMarkerExpirationEmptyStore
org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testDeleteMarkerExpiration
org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testWithMinVersions
org.apache.hadoop.hbase.regionserver.TestMinVersions.testDelete
org.apache.hadoop.hbase.regionserver.TestMinVersions.testGetClosestBefore
org.apache.hadoop.hbase.regionserver.TestMinVersions.testStoreMemStore
org.apache.hadoop.hbase.regionserver.TestMinVersions.testMemStore
org.apache.hadoop.hbase.regionserver.TestMinVersions.testBaseCase
org.apache.hadoop.hbase.regionserver.TestMinVersions.testFilters
org.apache.hadoop.hbase.regionserver.TestQueryMatcher.testMatch_ExpiredExplicit
org.apache.hadoop.hbase.regionserver.TestQueryMatcher.testMatch_ExpiredWildcard