HBase
  1. HBase
  2. HBASE-7427

Check line lenghts in the test-patch script

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None

      Description

      Checkstyle is disabled in test-patch, and it is not very easy to make it work. We can just add some check for the line lengths in the mean time.

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        stack added a comment -

        Reresolving. That seems to be what you fellas want (Jon and Enis).

        Show
        stack added a comment - Reresolving. That seems to be what you fellas want (Jon and Enis).
        Hide
        Enis Soztutar added a comment -

        Sure, np. If it comes to pass that we need a new patch, I'll open another one.

        Show
        Enis Soztutar added a comment - Sure, np. If it comes to pass that we need a new patch, I'll open another one.
        Hide
        Jonathan Hsieh added a comment -

        nit: Enis Soztutar, since it was initially closed two weeks ago, mind closing this and creating a new jira for mac/bsd? If the new fix creates a new patch it'll be confusing to see two separated by that amount of time!

        Show
        Jonathan Hsieh added a comment - nit: Enis Soztutar , since it was initially closed two weeks ago, mind closing this and creating a new jira for mac/bsd? If the new fix creates a new patch it'll be confusing to see two separated by that amount of time!
        Hide
        Enis Soztutar added a comment -

        We can alternatively just disable line checking if wc -L is not available.

        Show
        Enis Soztutar added a comment - We can alternatively just disable line checking if wc -L is not available.
        Hide
        Enis Soztutar added a comment -

        Reopening, since this breaks in mac os.

        Show
        Enis Soztutar added a comment - Reopening, since this breaks in mac os.
        Hide
        Nicolas Liochon added a comment -

        Would that work on a mac?

         
        function f100 { grep  '.\{101,\}' "$1" |grep  -e "^+"  |grep -v -e "^+++";}
        
        Show
        Nicolas Liochon added a comment - Would that work on a mac? function f100 { grep '.\{101,\}' "$1" |grep -e "^+" |grep -v -e "^+++" ;}
        Hide
        Devaraj Das added a comment -

        FYI, the 'wc' command on my mac laptop doesn't support the '-L' option (that's the BSD impl of wc). In order for the line-length wc command to work, we need to ensure that the GNU version of wc or some equivalent is used...

        Show
        Devaraj Das added a comment - FYI, the 'wc' command on my mac laptop doesn't support the '-L' option (that's the BSD impl of wc). In order for the line-length wc command to work, we need to ensure that the GNU version of wc or some equivalent is used...
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #314 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/314/)
        HBASE-7427. Check line lenghts in the test-patch script (Revision 1426040)

        Result = FAILURE
        enis :
        Files :

        • /hbase/trunk/dev-support/test-patch.properties
        • /hbase/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #314 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/314/ ) HBASE-7427 . Check line lenghts in the test-patch script (Revision 1426040) Result = FAILURE enis : Files : /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3657 (See https://builds.apache.org/job/HBase-TRUNK/3657/)
        HBASE-7427. Check line lenghts in the test-patch script (Revision 1426040)

        Result = FAILURE
        enis :
        Files :

        • /hbase/trunk/dev-support/test-patch.properties
        • /hbase/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3657 (See https://builds.apache.org/job/HBase-TRUNK/3657/ ) HBASE-7427 . Check line lenghts in the test-patch script (Revision 1426040) Result = FAILURE enis : Files : /hbase/trunk/dev-support/test-patch.properties /hbase/trunk/dev-support/test-patch.sh
        Hide
        Enis Soztutar added a comment -

        Committed this. Let's see whether if it is useful. Feel free to revert otherwise.
        Thanks Stack for review.

        Show
        Enis Soztutar added a comment - Committed this. Let's see whether if it is useful. Feel free to revert otherwise. Thanks Stack for review.
        Hide
        stack added a comment -

        Looks useful. Try committing it Enis to see how it does. We can revert or fixup if it messes up.

        Show
        stack added a comment - Looks useful. Try committing it Enis to see how it does. We can revert or fixup if it messes up.
        Hide
        Enis Soztutar added a comment -

        Something like this

        Show
        Enis Soztutar added a comment - Something like this

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development