HBase
  1. HBase
  2. HBASE-7415

[snapshots] Add task information to snapshot operation

    Details

      Description

      Snapshot operations should have some sort of progresss information available via the WebUI so admins can track progress of operations. This should go a long way to enable 'good' admins to not hose their clusters by running concurrent snapshot operations (e.g. rename while a clone is in progress).

      1. HBASE-7415-v4.patch
        23 kB
        Matteo Bertozzi
      2. HBASE-7415-v4.patch
        23 kB
        Matteo Bertozzi
      3. HBASE-7415-v3.patch
        23 kB
        Matteo Bertozzi
      4. HBASE-7415-v2.patch
        23 kB
        Matteo Bertozzi
      5. HBASE-7415-v1-rebase.patch
        20 kB
        Matteo Bertozzi
      6. hbase-7415-v1.patch
        17 kB
        Jesse Yates
      7. hbase-7415-v0.patch
        17 kB
        Jesse Yates
      8. HBASE-7415-0.94-v1.patch
        20 kB
        Matteo Bertozzi
      9. HBASE-7415-0.94.patch
        20 kB
        Matteo Bertozzi
      10. HBase_Snapshot_Task_UI.png
        92 kB
        Jesse Yates

        Activity

        Hide
        Jesse Yates added a comment -

        Simple patch that just adds a MonitoredTask to offline, restore and clone operations. Tested locally and nicely shows info the in the master status info.

        This should be helpful for debugging later if things hang in certain states.

        Show
        Jesse Yates added a comment - Simple patch that just adds a MonitoredTask to offline, restore and clone operations. Tested locally and nicely shows info the in the master status info. This should be helpful for debugging later if things hang in certain states.
        Hide
        Jesse Yates added a comment -

        It would be nice to tie this into ExportSnapshot too, but as a M/R tool, its on the admin to make sure that that Tool finishes before running other snapshot DDL operations.

        Show
        Jesse Yates added a comment - It would be nice to tie this into ExportSnapshot too, but as a M/R tool, its on the admin to make sure that that Tool finishes before running other snapshot DDL operations.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562006/hbase-7415-v0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3636//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562006/hbase-7415-v0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3636//console This message is automatically generated.
        Hide
        Jonathan Hsieh added a comment -

        Nice. a quick screenshot to show where this shows up in the ui?

        Why not put the status monitor into CreateTableHandler? (oh the joys of inheritance, it feels like it should there).

        Put a pre process status update?

        +
        +  @Override
        +  public void process() {
        +    super.process();
        +    status.markComplete("Snapshot clone complete and table enabling!");
           }
        

        nit: this constructor seems to be getting a bit excessive. we should follow up and see if we really needed this in a helper instead of just folding into the restore handler.

           public RestoreSnapshotHelper(final Configuration conf, final FileSystem fs,
               final CatalogTracker catalogTracker,
               final SnapshotDescription snapshotDescription, final Path snapshotDir,
               final HTableDescriptor tableDescriptor, final Path tableDir,
        -      final SnapshotExceptionSnare monitor)
        +      final SnapshotExceptionSnare monitor, final MonitoredTask status)
           {
        
        Show
        Jonathan Hsieh added a comment - Nice. a quick screenshot to show where this shows up in the ui? Why not put the status monitor into CreateTableHandler? (oh the joys of inheritance, it feels like it should there). Put a pre process status update? + + @Override + public void process() { + super .process(); + status.markComplete( "Snapshot clone complete and table enabling!" ); } nit: this constructor seems to be getting a bit excessive. we should follow up and see if we really needed this in a helper instead of just folding into the restore handler. public RestoreSnapshotHelper( final Configuration conf, final FileSystem fs, final CatalogTracker catalogTracker, final SnapshotDescription snapshotDescription, final Path snapshotDir, final HTableDescriptor tableDescriptor, final Path tableDir, - final SnapshotExceptionSnare monitor) + final SnapshotExceptionSnare monitor, final MonitoredTask status) {
        Hide
        Jesse Yates added a comment -

        Why not put the status monitor into CreateTableHandler?

        I didn't want to change the existing functionality, so left it down a level

        nit: this constructor seems to be getting a bit excessive we should follow up and see if we really needed this in a helper instead of just folding into the restore handler.

        I was thinking the exact same thing. Meh.

        Show
        Jesse Yates added a comment - Why not put the status monitor into CreateTableHandler? I didn't want to change the existing functionality, so left it down a level nit: this constructor seems to be getting a bit excessive we should follow up and see if we really needed this in a helper instead of just folding into the restore handler. I was thinking the exact same thing. Meh.
        Hide
        Jonathan Hsieh added a comment -

        Let's get a screen shot up in lieu of a test, and if it looks sane, I'll +1.

        Show
        Jonathan Hsieh added a comment - Let's get a screen shot up in lieu of a test, and if it looks sane, I'll +1.
        Hide
        Jesse Yates added a comment -

        Screenshot of taking an offline snapshot and then cloning to a new table

        Show
        Jesse Yates added a comment - Screenshot of taking an offline snapshot and then cloning to a new table
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562205/HBase_Snapshot_Task_UI.png
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3662//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562205/HBase_Snapshot_Task_UI.png against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3662//console This message is automatically generated.
        Hide
        Jonathan Hsieh added a comment -

        lgtm +1.

        Show
        Jonathan Hsieh added a comment - lgtm +1.
        Hide
        Matteo Bertozzi added a comment -

        +1, nice stuff

        just a minor nit: the "Restore x/y regions" is not really useful since a restore is composed by: regions to restore (this one below), regions to remove and regions to add.

        -    for (HRegionInfo hri: regions) restoreRegion(hri);
        +    for (int i = 0; i < regions.size(); i++) {
        +      HRegionInfo hri = regions.get(i);
        +      restoreRegion(hri);
        +      status.setStatus("Restored " + i + "/" + regions.size() + " regions");
        +    }
        
        Show
        Matteo Bertozzi added a comment - +1, nice stuff just a minor nit: the "Restore x/y regions" is not really useful since a restore is composed by: regions to restore (this one below), regions to remove and regions to add. - for (HRegionInfo hri: regions) restoreRegion(hri); + for ( int i = 0; i < regions.size(); i++) { + HRegionInfo hri = regions.get(i); + restoreRegion(hri); + status.setStatus( "Restored " + i + "/" + regions.size() + " regions" ); + }
        Hide
        Jesse Yates added a comment -

        Attaching updated version on top latest snapshot branch. Also removed the HRI processing from Matteo's comment. I'd like to commit tomorrow, unless there is an objection.

        thanks for the poke Ted Yu

        Show
        Jesse Yates added a comment - Attaching updated version on top latest snapshot branch. Also removed the HRI processing from Matteo's comment. I'd like to commit tomorrow, unless there is an objection. thanks for the poke Ted Yu
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12564586/hbase-7415-v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3990//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564586/hbase-7415-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3990//console This message is automatically generated.
        Hide
        Jonathan Hsieh added a comment -

        +1 lgtm. Please to commit the hbase-7290 branch (https://github.com/jmhsieh/hbase/tree/snapshots) as well as the hbase-6055 branch (https://github.com/jyates/hbase/tree/snapshots, if you choose to).

        Show
        Jonathan Hsieh added a comment - +1 lgtm. Please to commit the hbase-7290 branch ( https://github.com/jmhsieh/hbase/tree/snapshots ) as well as the hbase-6055 branch ( https://github.com/jyates/hbase/tree/snapshots , if you choose to).
        Hide
        Jesse Yates added a comment -

        commited to offline (hbase-6055), but need to refactor for the hbase-7290 branch.

        Show
        Jesse Yates added a comment - commited to offline (hbase-6055), but need to refactor for the hbase-7290 branch.
        Hide
        Jesse Yates added a comment -

        I've been caught up in other work and haven't had a chance to do the refactor for online snapshots. Thinking about holding off until Jonathan Hsieh, Matteo Bertozzi, and co. get the tests passing consistently (I'd rather not make things more difficult for you fellas). Sound reasonable?

        Show
        Jesse Yates added a comment - I've been caught up in other work and haven't had a chance to do the refactor for online snapshots. Thinking about holding off until Jonathan Hsieh , Matteo Bertozzi , and co. get the tests passing consistently (I'd rather not make things more difficult for you fellas). Sound reasonable?
        Hide
        Jonathan Hsieh added a comment -

        Jesse Yates sounds reasonable. when we get tests passing, depending on if the merge happens we'll promote this (and any other subtasks) to a fully fledged issues as opposed to a subtask.

        Show
        Jonathan Hsieh added a comment - Jesse Yates sounds reasonable. when we get tests passing, depending on if the merge happens we'll promote this (and any other subtasks) to a fully fledged issues as opposed to a subtask.
        Hide
        Matteo Bertozzi added a comment -

        attached a rebased version of the patch to work against trunk.

        Hey Jason Yates do you have other changes/ideas for this jira?

        Show
        Matteo Bertozzi added a comment - attached a rebased version of the patch to work against trunk. Hey Jason Yates do you have other changes/ideas for this jira?
        Hide
        Jesse Yates added a comment -

        It might be cool to update the monitor with how many regions have reported for each step in the online case. But that might be a bit more work than is worth it.

        One comment, looks like an extra whitespace crept in here:

        @@ -66,6 +68,7 @@ public class DisabledTableSnapshotHandler extends TakeSnapshotHandler {
             super(snapshot, masterServices);
         
             // setup the timer
        +
             timeoutInjector = TakeSnapshotUtils.getMasterTimerAndBindToMonitor(snapshot, conf, monitor);
           }
        

        Otherwise, +1

        Show
        Jesse Yates added a comment - It might be cool to update the monitor with how many regions have reported for each step in the online case. But that might be a bit more work than is worth it. One comment, looks like an extra whitespace crept in here: @@ -66,6 +68,7 @@ public class DisabledTableSnapshotHandler extends TakeSnapshotHandler { super (snapshot, masterServices); // setup the timer + timeoutInjector = TakeSnapshotUtils.getMasterTimerAndBindToMonitor(snapshot, conf, monitor); } Otherwise, +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12572119/HBASE-7415-v1-rebase.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed
        org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572119/HBASE-7415-v1-rebase.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4675//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Patch looks good overall.

        +      status.setStatus(msg + " Waiting to table enabling...");
        

        Please correct syntax for second part of the message.

        In CloneSnapshotHandler.java, I don't see call to status.markComplete().

        Show
        Ted Yu added a comment - Patch looks good overall. + status.setStatus(msg + " Waiting to table enabling..." ); Please correct syntax for second part of the message. In CloneSnapshotHandler.java, I don't see call to status.markComplete().
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12572312/HBASE-7415-v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
        org.apache.hadoop.hbase.replication.TestReplicationQueueFailover
        org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572312/HBASE-7415-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster org.apache.hadoop.hbase.replication.TestReplicationQueueFailover org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4697//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        attached v3, is just a rebase against current trunk

        Show
        Matteo Bertozzi added a comment - attached v3, is just a rebase against current trunk
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12575727/HBASE-7415-v3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.io.encoding.TestChangingEncoding

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575727/HBASE-7415-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.encoding.TestChangingEncoding Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5030//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12576088/HBASE-7415-0.94.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5045//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576088/HBASE-7415-0.94.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5045//console This message is automatically generated.
        Hide
        Jonathan Hsieh added a comment -

        Reviewed trunk version, lgtm. fix nit on commit?

        minor spacing nit:

        @@ -115,7 +117,7 @@ public class RestoreSnapshotHelper {
           public RestoreSnapshotHelper(final Configuration conf, final FileSystem fs,
               final SnapshotDescription snapshotDescription, final Path snapshotDir,
               final HTableDescriptor tableDescriptor, final Path tableDir,
        -      final ForeignExceptionDispatcher monitor)
        +      final ForeignExceptionDispatcher monitor,final MonitoredTask status)
        
        
        Show
        Jonathan Hsieh added a comment - Reviewed trunk version, lgtm. fix nit on commit? minor spacing nit: @@ -115,7 +117,7 @@ public class RestoreSnapshotHelper { public RestoreSnapshotHelper( final Configuration conf, final FileSystem fs, final SnapshotDescription snapshotDescription, final Path snapshotDir, final HTableDescriptor tableDescriptor, final Path tableDir, - final ForeignExceptionDispatcher monitor) + final ForeignExceptionDispatcher monitor, final MonitoredTask status)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12576381/HBASE-7415-v4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.backup.TestHFileArchiving
        org.apache.hadoop.hbase.master.TestTableLockManager

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576381/HBASE-7415-v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.backup.TestHFileArchiving org.apache.hadoop.hbase.master.TestTableLockManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5085//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        I'm planning to commit this one today, any other comments on the patch?

        Show
        Matteo Bertozzi added a comment - I'm planning to commit this one today, any other comments on the patch?
        Hide
        Jonathan Hsieh added a comment -

        lgtm +1.

        Show
        Jonathan Hsieh added a comment - lgtm +1.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12576590/HBASE-7415-v4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576590/HBASE-7415-v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5095//console This message is automatically generated.
        Hide
        stack added a comment -

        Skimmed patch. LGTM. +1 on commit to trunk and 0.95 if looks good in UI.

        Show
        stack added a comment - Skimmed patch. LGTM. +1 on commit to trunk and 0.95 if looks good in UI.
        Hide
        Matteo Bertozzi added a comment -

        committed to 0.95 and trunk, thanks guys for the review and Jesse for the patch.

        anyone wants it in 94?

        Show
        Matteo Bertozzi added a comment - committed to 0.95 and trunk, thanks guys for the review and Jesse for the patch. anyone wants it in 94?
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #4012 (See https://builds.apache.org/job/HBase-TRUNK/4012/)
        HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464427)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #4012 (See https://builds.apache.org/job/HBase-TRUNK/4012/ ) HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464427) Result = FAILURE mbertozzi : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95 #123 (See https://builds.apache.org/job/hbase-0.95/123/)
        HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464429)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Show
        Hudson added a comment - Integrated in hbase-0.95 #123 (See https://builds.apache.org/job/hbase-0.95/123/ ) HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464429) Result = FAILURE mbertozzi : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #476 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/476/)
        HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464427)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #476 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/476/ ) HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464427) Result = FAILURE mbertozzi : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Hide
        Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #54 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/54/)
        HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464429)

        Result = FAILURE
        mbertozzi :
        Files :

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Show
        Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #54 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/54/ ) HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464429) Result = FAILURE mbertozzi : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Hide
        Jesse Yates added a comment -

        Yeah, if you wouldn't mind putting it into 0.94 Matteo Bertozzi, that would be sweet!

        Show
        Jesse Yates added a comment - Yeah, if you wouldn't mind putting it into 0.94 Matteo Bertozzi , that would be sweet!
        Hide
        Matteo Bertozzi added a comment -

        Committed to 0.94

        Show
        Matteo Bertozzi added a comment - Committed to 0.94
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #947 (See https://builds.apache.org/job/HBase-0.94/947/)
        HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464928)

        Result = SUCCESS
        mbertozzi :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #947 (See https://builds.apache.org/job/HBase-0.94/947/ ) HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464928) Result = SUCCESS mbertozzi : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #133 (See https://builds.apache.org/job/HBase-0.94-security/133/)
        HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464928)

        Result = SUCCESS
        mbertozzi :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #133 (See https://builds.apache.org/job/HBase-0.94-security/133/ ) HBASE-7415 Add task information to snapshot operation (Jesse Yates) (Revision 1464928) Result = SUCCESS mbertozzi : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java

          People

          • Assignee:
            Jesse Yates
            Reporter:
            Jesse Yates
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development