HBase
  1. HBase
  2. HBASE-73

[hbase] Cleanup: All generated code should go into the o.a.h.h.generated package

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      As is, generated code goes into o.a.h.h.thrift.generated, o.a.h.h.hql.generated, etc. Rather, have it all go into the one package, o.a.h.h.generated.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        206d 6h 22m 1 stack 13/Aug/08 00:44
        Resolved Resolved Closed Closed
        9d 21h 50m 1 Jim Kellerman 22/Aug/08 22:34
        Jim Kellerman made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        stack made changes -
        Resolution Won't Fix [ 2 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        stack added a comment -

        Lets go w/ Bryans opinion on this one.

        Show
        stack added a comment - Lets go w/ Bryans opinion on this one.
        Hide
        Bryan Duxbury added a comment -

        I was thinking that o.a.h.h.thrift.generated makes more sense. It's code that was generated for thrift. It's cosmetic in any case but it keeps all the code for a package in the same tree.

        Show
        Bryan Duxbury added a comment - I was thinking that o.a.h.h.thrift.generated makes more sense. It's code that was generated for thrift. It's cosmetic in any case but it keeps all the code for a package in the same tree.
        Owen O'Malley made changes -
        Field Original Value New Value
        Project Hadoop Core [ 12310240 ] Hadoop HBase [ 12310753 ]
        Component/s contrib/hbase [ 12311752 ]
        Key HADOOP-2666 HBASE-73
        Hide
        stack added a comment -

        I should have been more explicit. Thrift generated code would go into o.a.h.h.generated.thrift and so on. Within the generated package there would be subpackages. You still -1?

        Show
        stack added a comment - I should have been more explicit. Thrift generated code would go into o.a.h.h.generated.thrift and so on. Within the generated package there would be subpackages. You still -1?
        Hide
        Bryan Duxbury added a comment -

        -1 on this one. It seems like it would be a little confusing. If there's a thrift package, then the generated code for thrift should probably be under it.

        Show
        Bryan Duxbury added a comment - -1 on this one. It seems like it would be a little confusing. If there's a thrift package, then the generated code for thrift should probably be under it.
        stack created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development