[HBASE-7371] Blocksize in TestHFileBlock is unintentionally small

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.94.4, 0.95.0
• Hadoop Flags: Reviewed
• Assignee: Lars Hofhansl
• Reporter: Lars Hofhansl
• Created: 17/Dec/12 22:12
• Updated: 26/Feb/13 08:22
• Resolved: 18/Dec/12 06:26

Description

Looking at TestHFileBlock.writeBlocks I see this:

      for (int j = 0; j < rand.nextInt(500); ++j) {
        // This might compress well.
        dos.writeShort(i + 1);
        dos.writeInt(j + 1);
      }

The result is probably not what the author intended. rand.nextInt(500) is evaluated during each iterations and that leads to very small blocks size mostly between ~100 and 300 bytes or so.

The author probably intended this:

      int size = rand.nextInt(500);
      for (int j = 0; j < size; ++j) {
        // This might compress well.
        dos.writeShort(i + 1);
        dos.writeInt(j + 1);
      }

This leads to more reasonable block sizes between ~200 and 3000 bytes