HBase
  1. HBase
  2. HBASE-6201 HBase integration/system tests
  3. HBASE-7109

integration tests on cluster are not getting picked up from distribution

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The method of finding test classes only works on local build (or its full copy), not if the distribution is used.

      1. HBASE-7109-fix.patch
        15 kB
        Sergey Shelukhin
      2. HBASE-7109-fix-v2.patch
        15 kB
        Sergey Shelukhin
      3. HBASE-7109-squashed.patch
        18 kB
        Sergey Shelukhin
      4. HBASE-7109-v2-squashed.patch
        19 kB
        Sergey Shelukhin
      5. HBASE-7109-v3-squashed.patch
        19 kB
        Sergey Shelukhin
      6. HBASE-7109-v4-squashed.patch
        19 kB
        Sergey Shelukhin
      7. HBASE-7109-v5.patch
        34 kB
        Sergey Shelukhin
      8. HBASE-7109-v5.patch
        34 kB
        Sergey Shelukhin
      9. HBASE-7109-v6.patch
        51 kB
        Sergey Shelukhin
      10. HBASE-7109-v6-0.94.patch
        34 kB
        Sergey Shelukhin

        Issue Links

          Activity

          Hide
          Sergey Shelukhin added a comment -

          Initial patch

          Show
          Sergey Shelukhin added a comment - Initial patch
          Hide
          Ted Yu added a comment -
          +  private Class<?> makeClass(String className, boolean optimistic)
          

          optimistic is governing how exception is handled. Would failOnException be a better name ?

          +
          +public class TestClassFinder extends ClassFinder {
          

          The above test is missing test category.

          Show
          Ted Yu added a comment - + private Class <?> makeClass( String className, boolean optimistic) optimistic is governing how exception is handled. Would failOnException be a better name ? + + public class TestClassFinder extends ClassFinder { The above test is missing test category.
          Hide
          Sergey Shelukhin added a comment -

          testclassfinder is not a test, it's a finder of test classes... will rename to avoid confusion

          Show
          Sergey Shelukhin added a comment - testclassfinder is not a test, it's a finder of test classes... will rename to avoid confusion
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552378/HBASE-7109-squashed.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 87 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 15 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552378/HBASE-7109-squashed.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 87 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 15 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3242//console This message is automatically generated.
          Hide
          Sergey Shelukhin added a comment -

          renamed class and parameter, added some javadocs

          Show
          Sergey Shelukhin added a comment - renamed class and parameter, added some javadocs
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552708/HBASE-7109-v2-squashed.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 87 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552708/HBASE-7109-v2-squashed.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 87 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3273//console This message is automatically generated.
          Hide
          Ted Yu added a comment -
          +public class ClassFinder {
          

          Please add annotation for audience and stability.

          +  public List<Class<?>> findClasses(String packageName, boolean proceedOnExceptions)
          

          The above method calls findTestClassesFromFiles() and findTestClassesFromJar(). This gives me impression that ClassFinder is already geared towards finding test classes.
          Can ClassFinder and ClassTestFinder be merged ?

          Show
          Ted Yu added a comment - + public class ClassFinder { Please add annotation for audience and stability. + public List< Class <?>> findClasses( String packageName, boolean proceedOnExceptions) The above method calls findTestClassesFromFiles() and findTestClassesFromJar(). This gives me impression that ClassFinder is already geared towards finding test classes. Can ClassFinder and ClassTestFinder be merged ?
          Hide
          Sergey Shelukhin added a comment -

          forgot to rename when splitting them will rename. These are different responsibilities, I think it's a good idea to split them.

          Show
          Sergey Shelukhin added a comment - forgot to rename when splitting them will rename. These are different responsibilities, I think it's a good idea to split them.
          Hide
          Sergey Shelukhin added a comment -

          ClassFinder can be used to find classes according to different rules, etc.

          Show
          Sergey Shelukhin added a comment - ClassFinder can be used to find classes according to different rules, etc.
          Hide
          Sergey Shelukhin added a comment -

          renamed the methods

          Show
          Sergey Shelukhin added a comment - renamed the methods
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552891/HBASE-7109-v3-squashed.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 87 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552891/HBASE-7109-v3-squashed.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 87 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3293//console This message is automatically generated.
          Hide
          Ted Yu added a comment -
          +  private List<Class<?>> findClassesFromJar(String jarFileName, String packageName, boolean proceedOnExceptions)
          

          The above line is too long (> 100 chars).

          +        String className = packageName + '.' + fileName.substring(0, fileName.length() - ".class".length());
          

          The above line is long. Consider introducing a constant for ".class".length() which appears in two places.

          ClassFinder is in src/test. People would think that it is used to find test classes.

          +public class ClassTestFinder extends ClassFinder {
          

          ClassTestFinder is the class that gets instantiated in the patch. Is it possible to unify the two classes ?

          Show
          Ted Yu added a comment - + private List< Class <?>> findClassesFromJar( String jarFileName, String packageName, boolean proceedOnExceptions) The above line is too long (> 100 chars). + String className = packageName + '.' + fileName.substring(0, fileName.length() - ".class" .length()); The above line is long. Consider introducing a constant for ".class".length() which appears in two places. ClassFinder is in src/test. People would think that it is used to find test classes. + public class ClassTestFinder extends ClassFinder { ClassTestFinder is the class that gets instantiated in the patch. Is it possible to unify the two classes ?
          Hide
          Sergey Shelukhin added a comment -

          Split the lines, these and similar.
          As for classes - there's javadoc on ClassFinder, plus its API is such that it cannot be used without explicitly making decisions on how to filter classes (due to ctor), so there should be no confusion.
          ClassTestFinder only exists to contain the filters, initially ClassFinder was separate and filters separate (because they do separate things), but I encapsulated the filters into ClassTestFinder for convenience.

          Show
          Sergey Shelukhin added a comment - Split the lines, these and similar. As for classes - there's javadoc on ClassFinder, plus its API is such that it cannot be used without explicitly making decisions on how to filter classes (due to ctor), so there should be no confusion. ClassTestFinder only exists to contain the filters, initially ClassFinder was separate and filters separate (because they do separate things), but I encapsulated the filters into ClassTestFinder for convenience.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552934/HBASE-7109-v4-squashed.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 87 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 18 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552934/HBASE-7109-v4-squashed.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 87 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 18 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3298//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          This looks good overall, just a nit:

          • Lets rename ClassTestFinder -> ClassFinderForTests. Please add a @see ClassFinderForTests javadoc in class ClassFinder. It seems fine to have two classes, since ClassFinder is a generic utility, and the other is for finding Test classes.
          Show
          Enis Soztutar added a comment - This looks good overall, just a nit: Lets rename ClassTestFinder -> ClassFinderForTests. Please add a @see ClassFinderForTests javadoc in class ClassFinder. It seems fine to have two classes, since ClassFinder is a generic utility, and the other is for finding Test classes.
          Hide
          Sergey Shelukhin added a comment -

          Added tests... unfortunately I didn't realize when I started how tedious mucking with jar files and ClassLoader is... But now it's there

          Show
          Sergey Shelukhin added a comment - Added tests... unfortunately I didn't realize when I started how tedious mucking with jar files and ClassLoader is... But now it's there
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554426/HBASE-7109-v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 13 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 99 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554426/HBASE-7109-v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 13 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 99 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3380//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554426/HBASE-7109-v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 13 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 99 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554426/HBASE-7109-v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 13 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 99 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3381//console This message is automatically generated.
          Hide
          Ted Yu added a comment -
          +  * A class is considered as a test class if:
          +   *  - it's not Abstract AND
          +   *  - one or more of its methods is annotated with org.junit.Test OR
          +   *  - the class is annotated with Suite.SuiteClasses
          +  * */
          +  private static class TestClassFilter implements ClassFilter {
          

          Do we need to consider tests that extend junit.framework.TestCase ?
          A few examples: TestCompare, TestBase64.
          There is also:

          public abstract class HBaseTestCase extends TestCase {
          

          We have:

          public class TestHRegion extends HBaseTestCase {
          
          +    public boolean isCandidateClass(Class<?> c) {
          +      return isTestClass(c) && isCategorizedClass(c);
          

          Some test classes don't satisfy both conditions above (methods aren't annotated with @Test in TestBase64).

          Show
          Ted Yu added a comment - + * A class is considered as a test class if : + * - it's not Abstract AND + * - one or more of its methods is annotated with org.junit.Test OR + * - the class is annotated with Suite.SuiteClasses + * */ + private static class TestClassFilter implements ClassFilter { Do we need to consider tests that extend junit.framework.TestCase ? A few examples: TestCompare, TestBase64. There is also: public abstract class HBaseTestCase extends TestCase { We have: public class TestHRegion extends HBaseTestCase { + public boolean isCandidateClass( Class <?> c) { + return isTestClass(c) && isCategorizedClass(c); Some test classes don't satisfy both conditions above (methods aren't annotated with @Test in TestBase64).
          Hide
          Sergey Shelukhin added a comment -

          The behavior is identical to previous code, I will revise tomorrow.

          Show
          Sergey Shelukhin added a comment - The behavior is identical to previous code, I will revise tomorrow.
          Hide
          Enis Soztutar added a comment -
          private static final String BASEPATH = "/tmp/testclassfinderjars/";
          

          Please do not assume that we are on a *nix system. Plus, all tests should only write data under target/. You can use

          HBaseTestingUtility.getDataTestDir("the_name_of_the_test") for getting a proper test dir for scratch.  
          
          Show
          Enis Soztutar added a comment - private static final String BASEPATH = "/tmp/testclassfinderjars/" ; Please do not assume that we are on a *nix system. Plus, all tests should only write data under target/. You can use HBaseTestingUtility.getDataTestDir( "the_name_of_the_test" ) for getting a proper test dir for scratch.
          Hide
          Enis Soztutar added a comment -
          +    URLClassLoader urlClassLoader = (URLClassLoader)ClassLoader.getSystemClassLoader();
          +    Method method = URLClassLoader.class
          +        .getDeclaredMethod("addURL", new Class[] { URL.class });
          +    method.setAccessible(true);
          +    method.invoke(urlClassLoader, new Object[] { jarFile.toURI().toURL() });
          

          This part seems scary. Did you test it with JDK7? Can we do smt like use an already known class, which comes from a jar in the classpath anyway. For example, all the zookeeper classes should be coming from the zk jar, can we just search for the Zookeeper.class? wdyt?

          Show
          Enis Soztutar added a comment - + URLClassLoader urlClassLoader = (URLClassLoader) ClassLoader .getSystemClassLoader(); + Method method = URLClassLoader.class + .getDeclaredMethod( "addURL" , new Class [] { URL.class }); + method.setAccessible( true ); + method.invoke(urlClassLoader, new Object [] { jarFile.toURI().toURL() }); This part seems scary. Did you test it with JDK7? Can we do smt like use an already known class, which comes from a jar in the classpath anyway. For example, all the zookeeper classes should be coming from the zk jar, can we just search for the Zookeeper.class? wdyt?
          Hide
          Sergey Shelukhin added a comment -

          Plus, all tests should only write data under target/. You can use

          HBaseTestingUtility is in server project. I will move part of it under package and replace.

          This part seems scary.

          The method is actually protected; thus it should be part of exposed interface, so it should be no scarier than deriving a custom ClassLoader in terms of potential breakage. Relying on existing classes from some dependency jar, esp. verifying what exactly we get from "find", seems brittle, and not all scenarios are possible.

          Show
          Sergey Shelukhin added a comment - Plus, all tests should only write data under target/. You can use HBaseTestingUtility is in server project. I will move part of it under package and replace. This part seems scary. The method is actually protected; thus it should be part of exposed interface, so it should be no scarier than deriving a custom ClassLoader in terms of potential breakage. Relying on existing classes from some dependency jar, esp. verifying what exactly we get from "find", seems brittle, and not all scenarios are possible.
          Hide
          stack added a comment -

          Do we need to consider tests that extend junit.framework.TestCase ?

          No. These should be deprecated. As are HBaseTestCase. Rather, we should be working to get these tests out of our codebase.

          Show
          stack added a comment - Do we need to consider tests that extend junit.framework.TestCase ? No. These should be deprecated. As are HBaseTestCase. Rather, we should be working to get these tests out of our codebase.
          Hide
          stack added a comment -

          Sergey Shelukhin You are doing some pretty fancy dancing in this patch. Nice set of tests. I'd say address Enis comments and then I'd be +1 on commit.

          Show
          stack added a comment - Sergey Shelukhin You are doing some pretty fancy dancing in this patch. Nice set of tests. I'd say address Enis comments and then I'd be +1 on commit.
          Hide
          stack added a comment -

          Committed to trunk. I like how you refactored out the HBaseTestingUtility you needed up in hbase-common Sergey. I'm resolving this issue. Make a 0.94 to backport it.

          Show
          stack added a comment - Committed to trunk. I like how you refactored out the HBaseTestingUtility you needed up in hbase-common Sergey. I'm resolving this issue. Make a 0.94 to backport it.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554567/HBASE-7109-v6.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 19 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 99 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554567/HBASE-7109-v6.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 19 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 99 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3391//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3557 (See https://builds.apache.org/job/HBase-TRUNK/3557/)
          HBASE-7109 integration tests on cluster are not getting picked up from distribution (Revision 1412348)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3557 (See https://builds.apache.org/job/HBase-TRUNK/3557/ ) HBASE-7109 integration tests on cluster are not getting picked up from distribution (Revision 1412348) Result = FAILURE stack : Files : /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #269 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/269/)
          HBASE-7109 integration tests on cluster are not getting picked up from distribution (Revision 1412348)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #269 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/269/ ) HBASE-7109 integration tests on cluster are not getting picked up from distribution (Revision 1412348) Result = FAILURE stack : Files : /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          Hide
          Ted Yu added a comment -

          Trunk build has failed twice since this went in: #3558 and #3559

          Failed tests:   checkClasses(org.apache.hadoop.hbase.TestCheckTestClasses): There are 14 test classes without category: [class org.apache.hadoop.hbase.thrift.TestMetricsThriftServerSourceFactory, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionSourceImpl, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceImpl, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceFactory, class org.apache.hadoop.hbase.rest.TestMetricsRESTSource, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsHLogSource, class org.apache.hadoop.hbase.thrift.TestThriftServerMetricsSourceFactoryImpl, class org.apache.hadoop.hbase.metrics.TestBaseSourceImpl, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsWALSourceImpl, class org.apache.hadoop.hbase.rest.TestRESTMetricsSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestReplicationMetricsSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceFactory, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceFactory]
          
          Show
          Ted Yu added a comment - Trunk build has failed twice since this went in: #3558 and #3559 Failed tests: checkClasses(org.apache.hadoop.hbase.TestCheckTestClasses): There are 14 test classes without category: [class org.apache.hadoop.hbase.thrift.TestMetricsThriftServerSourceFactory, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionSourceImpl, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceImpl, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceFactory, class org.apache.hadoop.hbase. rest .TestMetricsRESTSource, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsHLogSource, class org.apache.hadoop.hbase.thrift.TestThriftServerMetricsSourceFactoryImpl, class org.apache.hadoop.hbase.metrics.TestBaseSourceImpl, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsWALSourceImpl, class org.apache.hadoop.hbase. rest .TestRESTMetricsSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestReplicationMetricsSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceFactory, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceFactory]
          Hide
          Elliott Clark added a comment -

          When running mvn test the tests pass. When running mvn package this fails. On looking at it, it appears this happens because the classes without an annotation are coming in from a jar. These jar names are not sent through the TestFileNameFilter.

          Show
          Elliott Clark added a comment - When running mvn test the tests pass. When running mvn package this fails. On looking at it, it appears this happens because the classes without an annotation are coming in from a jar. These jar names are not sent through the TestFileNameFilter.
          Hide
          Ted Yu added a comment -

          I logged HBASE-7209: Enhance dev-support/test-patch.sh with running test suite using 'mvn package'

          Show
          Ted Yu added a comment - I logged HBASE-7209 : Enhance dev-support/test-patch.sh with running test suite using 'mvn package'
          Hide
          Sergey Shelukhin added a comment -

          Looks like compat project exclusion checking is not working. I'll check why, probably issues with absolute path in the package. If it's that I'll add jar filter...
          Any reason why compat project tests shouldn't be categorized?

          Show
          Sergey Shelukhin added a comment - Looks like compat project exclusion checking is not working. I'll check why, probably issues with absolute path in the package. If it's that I'll add jar filter... Any reason why compat project tests shouldn't be categorized?
          Hide
          Elliott Clark added a comment -

          The compat modules don't depend on hbase-common so they don't have the annotations. I was worried about getting the dependency graph too complex.

          Show
          Elliott Clark added a comment - The compat modules don't depend on hbase-common so they don't have the annotations. I was worried about getting the dependency graph too complex.
          Hide
          Sergey Shelukhin added a comment -

          Jar absolute path is merely a package path... added filtering on actual jar path and c/p-ed tests.

          Show
          Sergey Shelukhin added a comment - Jar absolute path is merely a package path... added filtering on actual jar path and c/p-ed tests.
          Hide
          Sergey Shelukhin added a comment -

          breaks mvn package

          Show
          Sergey Shelukhin added a comment - breaks mvn package
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554917/HBASE-7109-fix.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 98 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554917/HBASE-7109-fix.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 98 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3405//console This message is automatically generated.
          Hide
          stack added a comment -

          Your patch breaks mvn package Sergey? What about the above failure? Thanks.

          Show
          stack added a comment - Your patch breaks mvn package Sergey? What about the above failure? Thanks.
          Hide
          Sergey Shelukhin added a comment -

          original patch breaks mvn package, as it finds compat tests in the jar and determines they have no annotation; that is due to there being no module path inside package; without path compat couldn't be filtered out.

          The above test passed on local run...

          Show
          Sergey Shelukhin added a comment - original patch breaks mvn package, as it finds compat tests in the jar and determines they have no annotation; that is due to there being no module path inside package; without path compat couldn't be filtered out. The above test passed on local run...
          Hide
          stack added a comment -

          Why make below protected?

          • private static final Log LOG = LogFactory.getLog(ClassFinder.class);
            + protected static final Log LOG = LogFactory.getLog(ClassFinder.class);

          So an Interface implementation has access? Make its own logger instead?

          For future, we usually write this kinda thing 'null == this.resourcePathFilter', the other way round.

          Otherwise +1 on commit

          Show
          stack added a comment - Why make below protected? private static final Log LOG = LogFactory.getLog(ClassFinder.class); + protected static final Log LOG = LogFactory.getLog(ClassFinder.class); So an Interface implementation has access? Make its own logger instead? For future, we usually write this kinda thing 'null == this.resourcePathFilter', the other way round. Otherwise +1 on commit
          Hide
          Enis Soztutar added a comment -

          For future, we usually write this kinda thing 'null == this.resourcePathFilter', the other way round.

          That's called Yoda Conditionals
          http://www.codinghorror.com/blog/2012/07/new-programming-jargon.html

          Show
          Enis Soztutar added a comment - For future, we usually write this kinda thing 'null == this.resourcePathFilter', the other way round. That's called Yoda Conditionals http://www.codinghorror.com/blog/2012/07/new-programming-jargon.html
          Hide
          stack added a comment -

          That is an excellent link Enis.

          Show
          stack added a comment - That is an excellent link Enis.
          Hide
          Sergey Shelukhin added a comment -

          Fixed the visibility; wrt conditionals - sure; C++ habit

          Show
          Sergey Shelukhin added a comment - Fixed the visibility; wrt conditionals - sure; C++ habit
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554943/HBASE-7109-fix-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 96 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 25 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.TestHeapSize

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554943/HBASE-7109-fix-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 96 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 25 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.TestHeapSize Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3408//console This message is automatically generated.
          Hide
          Sergey Shelukhin added a comment -

          test fails due to HBASE-7110

          Show
          Sergey Shelukhin added a comment - test fails due to HBASE-7110
          Hide
          Sergey Shelukhin added a comment -

          ping? thanks.

          Show
          Sergey Shelukhin added a comment - ping? thanks.
          Hide
          Sergey Shelukhin added a comment -

          stack Enis Soztutar can you guys please take a look at the patch? it's separate from previous patches, should fix mvn package compat-tests-are-not-annotated failures

          Show
          Sergey Shelukhin added a comment - stack Enis Soztutar can you guys please take a look at the patch? it's separate from previous patches, should fix mvn package compat-tests-are-not-annotated failures
          Hide
          stack added a comment -

          Sergey Shelukhin So apply the fix2? If so, I'll do it in a new issue. Just let me know. Patch looks good to me.

          Show
          stack added a comment - Sergey Shelukhin So apply the fix2? If so, I'll do it in a new issue. Just let me know. Patch looks good to me.
          Hide
          Sergey Shelukhin added a comment -

          Created HBASE-7229. I will probably also create separate JIRA for 0.94 port.

          Show
          Sergey Shelukhin added a comment - Created HBASE-7229 . I will probably also create separate JIRA for 0.94 port.
          Hide
          Sergey Shelukhin added a comment -

          Resolve comment: re-resolving since bug fix was moved to separate jira, and 0.94 port will be

          Show
          Sergey Shelukhin added a comment - Resolve comment: re-resolving since bug fix was moved to separate jira, and 0.94 port will be
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #606 (See https://builds.apache.org/job/HBase-0.94/606/)
          HBASE-7230 port HBASE-7109 integration tests on cluster are not getting picked up from distribution to 0.94 (Revision 1415054)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #606 (See https://builds.apache.org/job/HBase-0.94/606/ ) HBASE-7230 port HBASE-7109 integration tests on cluster are not getting picked up from distribution to 0.94 (Revision 1415054) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassFinder.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #86 (See https://builds.apache.org/job/HBase-0.94-security/86/)
          HBASE-7230 port HBASE-7109 integration tests on cluster are not getting picked up from distribution to 0.94 (Revision 1415054)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #86 (See https://builds.apache.org/job/HBase-0.94-security/86/ ) HBASE-7230 port HBASE-7109 integration tests on cluster are not getting picked up from distribution to 0.94 (Revision 1415054) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassFinder.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/)
          HBASE-7230 port HBASE-7109 integration tests on cluster are not getting picked up from distribution to 0.94 (Revision 1415054)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/ ) HBASE-7230 port HBASE-7109 integration tests on cluster are not getting picked up from distribution to 0.94 (Revision 1415054) Result = FAILURE stack : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassFinder.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClassTestFinder.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.

            People

            • Assignee:
              Sergey Shelukhin
              Reporter:
              Sergey Shelukhin
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development