HBase
  1. HBase
  2. HBASE-7095

Cannot set 'lenAsVal' for KeyOnlyFilter from shell

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.94.3, 0.95.0
    • Component/s: Filters
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Current implementation of createFilterFromArguments() in KeyOnlyFilter rejects the Boolean argument, effectively preventing from specifying this option from HBase shell.

        Activity

        Hide
        Aditya Kishore added a comment -

        Submitting patch for trunk. Now the option can be specified from shell using the filter language.

        scan 't1', {FILTER => "KeyOnlyFilter(true)"}
        
        Show
        Aditya Kishore added a comment - Submitting patch for trunk. Now the option can be specified from shell using the filter language. scan 't1', {FILTER => "KeyOnlyFilter( true )" }
        Hide
        Ted Yu added a comment -

        Patch looks good.
        Looks like Hadoop QA hasn't run test suite due to Jenkins issue.

        Show
        Ted Yu added a comment - Patch looks good. Looks like Hadoop QA hasn't run test suite due to Jenkins issue.
        Hide
        stack added a comment -

        +1 on patch

        Show
        stack added a comment - +1 on patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12552007/HBASE-7095_trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 85 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552007/HBASE-7095_trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 85 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3223//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Integrated to trunk.

        Thanks for the patch, Aditya.

        Thanks for the review, Stack.

        Show
        Ted Yu added a comment - Integrated to trunk. Thanks for the patch, Aditya. Thanks for the review, Stack.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3513 (See https://builds.apache.org/job/HBase-TRUNK/3513/)
        HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya) (Revision 1405657)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3513 (See https://builds.apache.org/job/HBase-TRUNK/3513/ ) HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya) (Revision 1405657) Result = SUCCESS tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Hide
        Lars Hofhansl added a comment -

        This as well as HBASE-7089 seem to be good fixes for 0.94 as well.

        Show
        Lars Hofhansl added a comment - This as well as HBASE-7089 seem to be good fixes for 0.94 as well.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #249 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/249/)
        HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya) (Revision 1405657)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #249 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/249/ ) HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya) (Revision 1405657) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Hide
        Aditya Kishore added a comment -

        Lars, I agree. The patches should apply easily on 94 branch with -p1.

        If not, please let me know and I'll attach them (already have them applied on my local 0.94 branch)

        Show
        Aditya Kishore added a comment - Lars, I agree. The patches should apply easily on 94 branch with -p1. If not, please let me know and I'll attach them (already have them applied on my local 0.94 branch)
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 as well. Thanks Aditya.

        Show
        Lars Hofhansl added a comment - Committed to 0.94 as well. Thanks Aditya.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/)
        HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya Kishore) (Revision 1405684)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/ ) HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya Kishore) (Revision 1405684) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #82 (See https://builds.apache.org/job/HBase-0.94-security/82/)
        HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya Kishore) (Revision 1405684)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #82 (See https://builds.apache.org/job/HBase-0.94-security/82/ ) HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya Kishore) (Revision 1405684) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #572 (See https://builds.apache.org/job/HBase-0.94/572/)
        HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya Kishore) (Revision 1405684)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #572 (See https://builds.apache.org/job/HBase-0.94/572/ ) HBASE-7095 Cannot set 'lenAsVal' for KeyOnlyFilter from shell (Aditya Kishore) (Revision 1405684) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java

          People

          • Assignee:
            Aditya Kishore
            Reporter:
            Aditya Kishore
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development