HBase
  1. HBase
  2. HBASE-7089

Allow filter to be specified for Get from HBase shell

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.94.3, 0.95.0
    • Component/s: shell
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Unlike scan, get in HBase shell does not accept FILTER as an argument.

      hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
      COLUMN                                                       CELL
      
      ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
      
      Here is some help for this command:
      ...
      
      1. HBASE-7089_94.patch
        3 kB
        Aditya Kishore
      2. HBASE-7089_trunk_v4.patch
        4 kB
        Aditya Kishore
      3. HBASE-7089_trunk_v3.patch
        4 kB
        Aditya Kishore
      4. HBASE-7089_trunk_v2.patch
        2 kB
        Aditya Kishore
      5. HBASE-7089_trunk.patch
        0.8 kB
        Aditya Kishore

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/)
        HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/ruby/hbase/table.rb
        • /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb
        • /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/ ) HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/ruby/hbase/table.rb /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #83 (See https://builds.apache.org/job/HBase-0.94-security/83/)
        HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/ruby/hbase/table.rb
        • /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb
        • /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #83 (See https://builds.apache.org/job/HBase-0.94-security/83/ ) HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/ruby/hbase/table.rb /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #573 (See https://builds.apache.org/job/HBase-0.94/573/)
        HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/ruby/hbase/table.rb
        • /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb
        • /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - Integrated in HBase-0.94 #573 (See https://builds.apache.org/job/HBase-0.94/573/ ) HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/ruby/hbase/table.rb /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
        Hide
        Lars Hofhansl added a comment -

        Thanks Aditya, committed to 0.94 as well.

        Show
        Lars Hofhansl added a comment - Thanks Aditya, committed to 0.94 as well.
        Hide
        Aditya Kishore added a comment -

        Oh forgot about the function rename! Here is the one for 0.94 branch.

        Show
        Aditya Kishore added a comment - Oh forgot about the function rename! Here is the one for 0.94 branch.
        Hide
        Lars Hofhansl added a comment -

        Tried to apply this to 0.94. Patch does not apply cleanly, I futzed around with it a few minutes.
        Table._get_internal and Table._scan_internal do not exist in 0.94.
        It's not super important to have this in 0.94. If somebody makes a patch for 0.94, I'll commit it

        Show
        Lars Hofhansl added a comment - Tried to apply this to 0.94. Patch does not apply cleanly, I futzed around with it a few minutes. Table._get_internal and Table._scan_internal do not exist in 0.94. It's not super important to have this in 0.94. If somebody makes a patch for 0.94, I'll commit it
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #249 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/249/)
        HBASE-7089 Allow filter to be specified for Get from HBase shell (Revision 1405640)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb
        • /hbase/trunk/hbase-server/src/main/ruby/shell/commands/get.rb
        • /hbase/trunk/hbase-server/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #249 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/249/ ) HBASE-7089 Allow filter to be specified for Get from HBase shell (Revision 1405640) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-server/src/main/ruby/shell/commands/get.rb /hbase/trunk/hbase-server/src/test/ruby/hbase/table_test.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3513 (See https://builds.apache.org/job/HBase-TRUNK/3513/)
        HBASE-7089 Allow filter to be specified for Get from HBase shell (Revision 1405640)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb
        • /hbase/trunk/hbase-server/src/main/ruby/shell/commands/get.rb
        • /hbase/trunk/hbase-server/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3513 (See https://builds.apache.org/job/HBase-TRUNK/3513/ ) HBASE-7089 Allow filter to be specified for Get from HBase shell (Revision 1405640) Result = SUCCESS stack : Files : /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-server/src/main/ruby/shell/commands/get.rb /hbase/trunk/hbase-server/src/test/ruby/hbase/table_test.rb
        Hide
        stack added a comment -

        Committed to trunk. Thanks for the patch Aditya.

        Show
        stack added a comment - Committed to trunk. Thanks for the patch Aditya.
        Hide
        Ted Yu added a comment -

        +1 on patch v4.

        Show
        Ted Yu added a comment - +1 on patch v4.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12551989/HBASE-7089_trunk_v4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 85 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551989/HBASE-7089_trunk_v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 85 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//console This message is automatically generated.
        Hide
        Aditya Kishore added a comment -

        Thanks for reviewing Ted.

        Why plural form is used above ?

        I used plural because a combination of filters could be specified but now I see that the convention in the test is to use the parameter verbatim.

        Attaching new patch with corrections.

        Show
        Aditya Kishore added a comment - Thanks for reviewing Ted. Why plural form is used above ? I used plural because a combination of filters could be specified but now I see that the convention in the test is to use the parameter verbatim. Attaching new patch with corrections.
        Hide
        Ted Yu added a comment -

        Tests look good.
        nit:

        +    define_test "get should support FILTERS" do
        

        Why plural form is used above ?

        Show
        Ted Yu added a comment - Tests look good. nit: + define_test "get should support FILTERS" do Why plural form is used above ?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12551972/HBASE-7089_trunk_v3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 85 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551972/HBASE-7089_trunk_v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 85 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//console This message is automatically generated.
        Hide
        Aditya Kishore added a comment -

        Updated patch with test cases

        Show
        Aditya Kishore added a comment - Updated patch with test cases
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12551942/HBASE-7089_trunk_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 85 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestMultiParallel

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551942/HBASE-7089_trunk_v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 85 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12551933/HBASE-7089_trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 85 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551933/HBASE-7089_trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 85 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//console This message is automatically generated.
        Hide
        Aditya Kishore added a comment -

        Trying to figure out how to run ruby tests. Will attach the updated patch with the tests (for both get and scan) soon.

        Show
        Aditya Kishore added a comment - Trying to figure out how to run ruby tests. Will attach the updated patch with the tests (for both get and scan) soon.
        Hide
        Ted Yu added a comment -

        I looked at hbase-server/src/test/ruby/hbase/table_test.rb where tests for scan don't cover Filter.
        Adding test for Filter would be nice.
        But I am fine without additional test(s).

        Show
        Ted Yu added a comment - I looked at hbase-server/src/test/ruby/hbase/table_test.rb where tests for scan don't cover Filter. Adding test for Filter would be nice. But I am fine without additional test(s).
        Hide
        Aditya Kishore added a comment -

        Thanks for catching that Stack. Missed while creating the patch.

        Show
        Aditya Kishore added a comment - Thanks for catching that Stack. Missed while creating the patch.
        Hide
        stack added a comment -

        Should you update the help for Get too Aditya?

        Show
        stack added a comment - Should you update the help for Get too Aditya?
        Hide
        Aditya Kishore added a comment -

        Submitting patch for trunk.

        With this, get now accept filters.

        hbase(main):004:0> get 't2', 'r1', {FILTER => "ValueFilter (=, 'binary:valueX')"}
        COLUMN                                                       CELL
         cf:c                                                        timestamp=1348831499385, value=valueX
         cf:t                                                        timestamp=1348831478941, value=valueX
        2 row(s) in 11.0770 seconds
        
        Show
        Aditya Kishore added a comment - Submitting patch for trunk. With this, get now accept filters. hbase(main):004:0> get 't2', 'r1', {FILTER => "ValueFilter (=, 'binary:valueX')"} COLUMN CELL cf:c timestamp=1348831499385, value=valueX cf:t timestamp=1348831478941, value=valueX 2 row(s) in 11.0770 seconds

          People

          • Assignee:
            Aditya Kishore
            Reporter:
            Aditya Kishore
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development