[HBASE-7073] OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.94.2
• Fix Version/s: 0.94.3
• Hadoop Flags: Reviewed
• Assignee: Elliott Neil Clark
• Reporter: Jean-Daniel Cryans
• Created: 30/Oct/12 19:00
• Updated: 03/Dec/12 21:47
• Resolved: 30/Oct/12 21:02

Description

Trying some increments on my local machine I was surprised to see this in my jstacks:

   java.lang.Thread.State: RUNNABLE
	at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
	- locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
	at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
	at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
	at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
	at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
	at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
	at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
	at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
	at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)

It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.

Assigning this to the master of metrics since he asked for it.