Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7072

HBase-5256 breaks 0.92-0.94 compatibility

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1, 0.92.2, 0.94.0
    • Fix Version/s: 0.92.3
    • Component/s: master, shell
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBase-5286 changes RegionLoad writable in 94.0, making it incompatible with 92. A fix was made in HBase-5795 where a 94 client can read response from a 92 server, but not vice versa. Currently, if a 92 client tries to do read RegionLoad (HBase shell "status" command, or, 92 master and 94 regionserver), it just hangs.

      1. HBase-7072-92.patch
        5 kB
        Himanshu Vashishtha
      2. HBase-7072-92-v2.patch
        5 kB
        Himanshu Vashishtha

        Activity

        Hide
        v.himanshu Himanshu Vashishtha added a comment -

        92 client can have a another read method in which it can understand the 94 server response (similar to 5795)

        Show
        v.himanshu Himanshu Vashishtha added a comment - 92 client can have a another read method in which it can understand the 94 server response (similar to 5795)
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        HBASE-5286 doesn't seem related.
        Can you clarify ?

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - HBASE-5286 doesn't seem related. Can you clarify ?
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        HBASE-5256 was the issue that started all this.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - HBASE-5256 was the issue that started all this.
        Hide
        v.himanshu Himanshu Vashishtha added a comment -

        Ted Yu Yes, that's correct. I messed up with the number. Thanks.

        Show
        v.himanshu Himanshu Vashishtha added a comment - Ted Yu Yes, that's correct. I messed up with the number. Thanks.
        Hide
        v.himanshu Himanshu Vashishtha added a comment -

        This patch provides a method to read 94 server response.
        I tested a
        a) 0.94.0 server with a patched 0.92.2 client
        b) patched 0.92.2 server against a 0.94.0 client.
        c) 0.92.1 server with a patched 0.92.2 client

        All of the above tests pass.

        Show
        v.himanshu Himanshu Vashishtha added a comment - This patch provides a method to read 94 server response. I tested a a) 0.94.0 server with a patched 0.92.2 client b) patched 0.92.2 server against a 0.94.0 client. c) 0.92.1 server with a patched 0.92.2 client All of the above tests pass.
        Hide
        enis Enis Soztutar added a comment -

        It is just unfortunate that we had HBASE-5256 committed to 0.94. At this point we cannot revert it since it is already released. It seems that the only thing we can do for 92 is to apply this patch.
        +1 on the patch. My only nit is to remove the line.

        +      // super.readFields(in);
        
        Show
        enis Enis Soztutar added a comment - It is just unfortunate that we had HBASE-5256 committed to 0.94. At this point we cannot revert it since it is already released. It seems that the only thing we can do for 92 is to apply this patch. +1 on the patch. My only nit is to remove the line. + // super .readFields(in);
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        Please fix the spelling for method name:

        +    public void readFiels94(DataInput in) throws IOException {
        

        Otherwise patch looks good.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - Please fix the spelling for method name: + public void readFiels94(DataInput in) throws IOException { Otherwise patch looks good.
        Hide
        v.himanshu Himanshu Vashishtha added a comment -

        Comments incorporated. Thanks for review.

        Show
        v.himanshu Himanshu Vashishtha added a comment - Comments incorporated. Thanks for review.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        Integrated to 0.92

        Thanks for the patch, Himanshu.

        Thanks for the review, Enis.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - Integrated to 0.92 Thanks for the patch, Himanshu. Thanks for the review, Enis.
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.92 #601 (See https://builds.apache.org/job/HBase-0.92/601/)
        HBASE-7072 HBase-5256 breaks 0.92-0.94 compatibility (Himanshu) (Revision 1404407)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
        Show
        hudson Hudson added a comment - Integrated in HBase-0.92 #601 (See https://builds.apache.org/job/HBase-0.92/601/ ) HBASE-7072 HBase-5256 breaks 0.92-0.94 compatibility (Himanshu) (Revision 1404407) Result = FAILURE tedyu : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.92-security #146 (See https://builds.apache.org/job/HBase-0.92-security/146/)
        HBASE-7072 HBase-5256 breaks 0.92-0.94 compatibility (Himanshu) (Revision 1404407)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
        Show
        hudson Hudson added a comment - Integrated in HBase-0.92-security #146 (See https://builds.apache.org/job/HBase-0.92-security/146/ ) HBASE-7072 HBase-5256 breaks 0.92-0.94 compatibility (Himanshu) (Revision 1404407) Result = FAILURE tedyu : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HServerLoad.java

          People

          • Assignee:
            v.himanshu Himanshu Vashishtha
            Reporter:
            v.himanshu Himanshu Vashishtha
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development