HBase
  1. HBase
  2. HBASE-7069

HTable.batch does not have to be synchronized

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.3
    • Component/s: Performance
    • Labels:
      None

      Description

      This was raised on the mailing list by Yousuf.
      HTable.batch(...) is synchronized and there appears to be no reason for it.

      (flushCommits makes the same call to connection.processBatch and it also is not synchronized)

      This is pretty bad actually marking critical.

      0.96 is fine BTW.

      1. 7069.txt
        1 kB
        Lars Hofhansl

        Activity

        Lars Hofhansl created issue -
        Lars Hofhansl made changes -
        Field Original Value New Value
        Component/s Performance [ 12314193 ]
        Hide
        Lars Hofhansl added a comment -

        Trivial patch.

        I looked through the code in HConnectionImplementation.processBatch, this really does not need to be synchronized here.

        Show
        Lars Hofhansl added a comment - Trivial patch. I looked through the code in HConnectionImplementation.processBatch, this really does not need to be synchronized here.
        Lars Hofhansl made changes -
        Attachment 7069.txt [ 12551304 ]
        Hide
        Ted Yu added a comment -

        +1 on patch.

        Show
        Ted Yu added a comment - +1 on patch.
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94

        Show
        Lars Hofhansl added a comment - Committed to 0.94
        Lars Hofhansl made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #560 (See https://builds.apache.org/job/HBase-0.94/560/)
        HBASE-7069 (Revision 1403808)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #560 (See https://builds.apache.org/job/HBase-0.94/560/ ) HBASE-7069 (Revision 1403808) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/)
        HBASE-7069 (Revision 1403808)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/ ) HBASE-7069 (Revision 1403808) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
        Lars Hofhansl made changes -
        Summary HTable.batch does not have to synchronized HTable.batch does not have to be synchronized
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development