[HBASE-7061] region balance algorithm should do "contiue" instead of "break" when calculating the underloaded server

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.92.3
• Assignee: Tianying Chang
• Reporter: Tianying Chang
• Created: 29/Oct/12 18:35
• Updated: 07/Nov/12 18:40
• Resolved: 07/Nov/12 18:40

Description

I found this issue when investigating HBASE-7060. Basically, I think the intention of this code below is to find all the underloaded server. By using break, it will exit earlier, depending on where the non-overloaded server show up in the list. "break" should be changed to "continue".

Map<ServerName, Integer> underloadedServers = new HashMap<ServerName, Integer>();
for (Map.Entry<ServerAndLoad, List<HRegionInfo>> server:
serversByLoad.entrySet()) {
int regionCount = server.getKey().getLoad();
if (regionCount >= min)

{ break; }

underloadedServers.put(server.getKey().getServerName(), min - regionCount);
}