[HBASE-7035] Thrift 2 server closes HTable of open Scanners

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 0.94.4
• Component/s: Thrift
• Labels: thrift2
• Assignee: Unassigned
• Reporter: Devin Bayer
• Created: 23/Oct/12 09:26
• Updated: 14/Jun/22 22:10
• Resolved: 17/Jul/13 08:01

Description

ThriftHBaseServiceHandler.openScanner() does this:
1. table = pool.getTable()
2. scanner = table.getScanner()
3. table.close()
4. return scanner

While back porting the thrift server to 0.92.6, I found that table.close() calls connection.close(). Further calls to scanner.next() raise a ConnectionClosed exception. The unit tests do not catch this since they reuse an open HConnection instance.

This might work on trunk, but depends on the implementations of HTablePool, HTable and HConnectionManager. Even with the pool wrapper, if the pool is full, table.close() may be called, which may invalidate the table. Also, HTable is not thread-safe, but they are being reused since they go back in the pool.

I suggest storing the table handle along with the scanner.

Issue Links

• relates to: HBASE-3852 ThriftServer leaks scanners
• relates to: HBASE-8825 Ensure HBASE-7035 is covered by Thrift 2