Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6916

HBA logs at info level errors that won't show in the shell

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.90.6, 0.92.1, 0.94.1, 0.95.2
    • 0.94.2
    • shell
    • None
    • Reviewed
    • The close_region shell command won't fail silently anymore, code relying on this behavior will now get UnknownRegionException

    Description

      There is a weird interaction between the shell and HBA. When you try to close a region that doesn't exist, it doesn't throw any error:

      hbase(main):029:0> close_region 'thisisaninvalidregion'
      0 row(s) in 0.0580 seconds
      

      Normally one should get UnknownRegionException. Starting the shell with "-d" I see what a non-shell user would see along with a ton of logging from ZK (skipped here):

      INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; pair=null
      

      But again this is not the right message, it should have shown

      INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; pair=null
      

      And this is because that part of the code treats both UnknownRegionException and NoServerForRegionException like if it was the same thing.

      There is also some ugliness in flush, compact, and split but it normally doesn't show since the code treats everything like it's a table and sends a TableNotFoundException.

      This jira is about making sure that the exceptions are correctly coming out.

      Attachments

        1. HBASE-6916.patch
          3 kB
          Jean-Daniel Cryans
        2. HBASE-6916-0.94.patch
          4 kB
          Jean-Daniel Cryans
        3. HBASE-6916-v2.patch
          4 kB
          Jean-Daniel Cryans

        Activity

          People

            jdcryans Jean-Daniel Cryans
            jdcryans Jean-Daniel Cryans
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: