HBase
  1. HBase
  2. HBASE-6915

String and ConcurrentHashMap sizes change on jdk7; makes TestHeapSize fail

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Issue Links

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #13 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/13/)
        HBASE-8014 Backport HBASE-6915 to 0.94 (Jean-Marc) (Revision 1457994)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #13 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/13/ ) HBASE-8014 Backport HBASE-6915 to 0.94 (Jean-Marc) (Revision 1457994) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Hide
        stack added a comment -

        Hack was committed to 0.95 and trunk. Resolving.

        Show
        stack added a comment - Hack was committed to 0.95 and trunk. Resolving.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #127 (See https://builds.apache.org/job/HBase-0.94-security/127/)
        HBASE-8014 Backport HBASE-6915 to 0.94 (Jean-Marc) (Revision 1457994)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #127 (See https://builds.apache.org/job/HBase-0.94-security/127/ ) HBASE-8014 Backport HBASE-6915 to 0.94 (Jean-Marc) (Revision 1457994) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #910 (See https://builds.apache.org/job/HBase-0.94/910/)
        HBASE-8014 Backport HBASE-6915 to 0.94 (Jean-Marc) (Revision 1457994)

        Result = ABORTED
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #910 (See https://builds.apache.org/job/HBase-0.94/910/ ) HBASE-8014 Backport HBASE-6915 to 0.94 (Jean-Marc) (Revision 1457994) Result = ABORTED tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Hide
        Lars Hofhansl added a comment -

        +1 for 0.94 as well.

        Show
        Lars Hofhansl added a comment - +1 for 0.94 as well.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #203 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/203/)
        HBASE-6915 String and ConcurrentHashMap sizes change on jdk7; makes TestHeapSize fail (Revision 1392731)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #203 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/203/ ) HBASE-6915 String and ConcurrentHashMap sizes change on jdk7; makes TestHeapSize fail (Revision 1392731) Result = FAILURE stack : Files : /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Hide
        stack added a comment -

        Ted, don't you have anything better to do than echo jenkins? If you need something to do, let me know.

        Show
        stack added a comment - Ted, don't you have anything better to do than echo jenkins? If you need something to do, let me know.
        Hide
        Ted Yu added a comment -

        Trunk build 3402 still has one failure.

        Show
        Ted Yu added a comment - Trunk build 3402 still has one failure.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3402 (See https://builds.apache.org/job/HBase-TRUNK/3402/)
        HBASE-6915 String and ConcurrentHashMap sizes change on jdk7; makes TestHeapSize fail (Revision 1392731)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3402 (See https://builds.apache.org/job/HBase-TRUNK/3402/ ) HBASE-6915 String and ConcurrentHashMap sizes change on jdk7; makes TestHeapSize fail (Revision 1392731) Result = FAILURE stack : Files : /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
        Hide
        stack added a comment -

        Committed small patch that helps failing tests to trunk

        Show
        stack added a comment - Committed small patch that helps failing tests to trunk
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12547316/jdk7.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 149 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547316/jdk7.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 149 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2980//console This message is automatically generated.
        Hide
        stack added a comment -

        Where we calculate the system String and ConcurrentHashMap size, check if jdk7 and if so, size appropriately.

        This sizing is brittle. Need to do something else. This fixes things for the moment.

        Show
        stack added a comment - Where we calculate the system String and ConcurrentHashMap size, check if jdk7 and if so, size appropriately. This sizing is brittle. Need to do something else. This fixes things for the moment.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development