Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work.

      1. hbase-16_v1.patch
        10 kB
        Enis Soztutar
      2. hbase-6816_v1.patch
        10 kB
        Enis Soztutar

        Issue Links

          Activity

          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #369 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/369/)
          HBASE-6816. [WINDOWS] line endings on checkout for .sh files (Revision 1437642)

          Result = FAILURE
          enis :
          Files :

          • /hbase/trunk/.gitattributes
          • /hbase/trunk/src/site/resources/images/hbase_logo.svg
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #369 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/369/ ) HBASE-6816 . [WINDOWS] line endings on checkout for .sh files (Revision 1437642) Result = FAILURE enis : Files : /hbase/trunk/.gitattributes /hbase/trunk/src/site/resources/images/hbase_logo.svg
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3785 (See https://builds.apache.org/job/HBase-TRUNK/3785/)
          HBASE-6816. [WINDOWS] line endings on checkout for .sh files (Revision 1437642)

          Result = FAILURE
          enis :
          Files :

          • /hbase/trunk/.gitattributes
          • /hbase/trunk/src/site/resources/images/hbase_logo.svg
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3785 (See https://builds.apache.org/job/HBase-TRUNK/3785/ ) HBASE-6816 . [WINDOWS] line endings on checkout for .sh files (Revision 1437642) Result = FAILURE enis : Files : /hbase/trunk/.gitattributes /hbase/trunk/src/site/resources/images/hbase_logo.svg
          Hide
          Enis Soztutar added a comment -

          Committed this. Thanks for the review Nicolas.

          Show
          Enis Soztutar added a comment - Committed this. Thanks for the review Nicolas.
          Hide
          Nicolas Liochon added a comment -

          Installed the patch on unix & windows, seems ok.

          I was surprised because the example in the git documentation explicitly states binary for png & jpg. So does https://github.com/Countly/countly-sdk-android/blob/master/.gitattributes for example. So I changed architecture.gif on windows, committed, then read it from Linux. I found my changes. So I'm +1 .

          Show
          Nicolas Liochon added a comment - Installed the patch on unix & windows, seems ok. I was surprised because the example in the git documentation explicitly states binary for png & jpg. So does https://github.com/Countly/countly-sdk-android/blob/master/.gitattributes for example. So I changed architecture.gif on windows, committed, then read it from Linux. I found my changes. So I'm +1 .
          Hide
          Enis Soztutar added a comment -

          Oh the change is to the line endings for that file. It was in CRLF endings, since it was saved from windows. But git repo should contain the canonical line endings(LF).

          Show
          Enis Soztutar added a comment - Oh the change is to the line endings for that file. It was in CRLF endings, since it was saved from windows. But git repo should contain the canonical line endings(LF).
          Hide
          Ted Yu added a comment -

          w.r.t. the changes for hbase_logo.svg, I put the patch on review board but review board didn't include this file in the diff.
          Can you tell me what changes were made ?

          Thanks

          Show
          Ted Yu added a comment - w.r.t. the changes for hbase_logo.svg, I put the patch on review board but review board didn't include this file in the diff. Can you tell me what changes were made ? Thanks
          Hide
          Enis Soztutar added a comment -

          Good catch

          Show
          Enis Soztutar added a comment - Good catch
          Hide
          stack added a comment -

          You added wrong patch here I think.

          Show
          stack added a comment - You added wrong patch here I think.
          Hide
          Enis Soztutar added a comment -

          Attaching a simple patch which applies to trunk and 0.94.

          • Changes the .svg file to have LF endings.
          • Adds a .gitattributes so that .sh files always check out with LF eol's.

          Here is a good guide on git line endings: https://help.github.com/articles/dealing-with-line-endings

          Show
          Enis Soztutar added a comment - Attaching a simple patch which applies to trunk and 0.94. Changes the .svg file to have LF endings. Adds a .gitattributes so that .sh files always check out with LF eol's. Here is a good guide on git line endings: https://help.github.com/articles/dealing-with-line-endings

            People

            • Assignee:
              Enis Soztutar
              Reporter:
              Enis Soztutar
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development