Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: Coprocessors
    • Labels:
      None

      Description

      With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services.

      AccessControllerProtocol was converted as part of HBASE-5448, but the authentication token provider still needs to be changed.

      1. HBASE-6788_2.patch
        190 kB
        Gary Helmling
      2. HBASE-6788_3.patch
        190 kB
        Gary Helmling
      3. HBASE-6788_4.patch
        190 kB
        Gary Helmling
      4. HBASE-6788_5.patch
        188 kB
        Gary Helmling
      5. HBASE-6788.patch
        175 kB
        Gary Helmling

        Issue Links

          Activity

          Hide
          stack added a comment -

          This should be made a blocker, huh, Gary?

          Show
          stack added a comment - This should be made a blocker, huh, Gary?
          Hide
          Gary Helmling added a comment -

          Yes, this one definitely. The other conversion sub-tasks would be blockers as well if we're actually going to drop the CoprocessorProtocol implementations from 0.96 instead of deprecate.

          Show
          Gary Helmling added a comment - Yes, this one definitely. The other conversion sub-tasks would be blockers as well if we're actually going to drop the CoprocessorProtocol implementations from 0.96 instead of deprecate.
          Hide
          Gary Helmling added a comment -

          Looking at this, we also need to convert the serialization of AuthenticationKey to be PB-based. AuthenticationKeys are serialized into ZK znodes to coordinate secret key rolling for authentication token signing and validation.

          Show
          Gary Helmling added a comment - Looking at this, we also need to convert the serialization of AuthenticationKey to be PB-based. AuthenticationKeys are serialized into ZK znodes to coordinate secret key rolling for authentication token signing and validation.
          Hide
          Andrew Purtell added a comment - - edited

          I'd be +1 with dropping CoprocessorProtocol from 0.96 and up, given all of the other (deliberate) incompatibilities posed with RPC going from 0.94 to 0.96 and up.

          Edit: Removed accidental markup.

          Show
          Andrew Purtell added a comment - - edited I'd be +1 with dropping CoprocessorProtocol from 0.96 and up, given all of the other (deliberate) incompatibilities posed with RPC going from 0.94 to 0.96 and up. Edit: Removed accidental markup.
          Hide
          Gary Helmling added a comment -

          Here's an initial patch dropping AuthenticationProtocol and converting TokenProvider to a PB service.

          I've tested this on a local secure Hadoop + HBase setup and had token authentication working for a simple RowCounter MR job. I'm still looking to see if there's a clean way to extend TestTokenAuthentication to better test this in the absence of Kerberos.

          Show
          Gary Helmling added a comment - Here's an initial patch dropping AuthenticationProtocol and converting TokenProvider to a PB service. I've tested this on a local secure Hadoop + HBase setup and had token authentication working for a simple RowCounter MR job. I'm still looking to see if there's a clean way to extend TestTokenAuthentication to better test this in the absence of Kerberos.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12559778/HBASE-6788.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 109 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestHCM

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12559778/HBASE-6788.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 109 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestHCM Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3517//console This message is automatically generated.
          Hide
          stack added a comment -

          AuthenticationTokenIdentifier is still a Writable? Is that because Exec needs to go over still Gary?

          Otherwise, I'm not whats going on but patch looks good.

          Thanks Gary.

          Show
          stack added a comment - AuthenticationTokenIdentifier is still a Writable? Is that because Exec needs to go over still Gary? Otherwise, I'm not whats going on but patch looks good. Thanks Gary.
          Hide
          stack added a comment -

          I went over the patch again. I think I follow what is going on. This AuthenticationTokenIdentifier implements the Hadoop TokenIdentifier. Its a Writable and nought you can do about it, not at moment, so you are outputting pb when write and expecting pb when you readFrom. That seems to make sense given the constraint.

          Is this needed anymore?

          public static final long VERSION = 0L;

          Why do this Gary?

          + return AuthenticationProtos.AuthenticationService.newReflectiveService(this);

          Why can't we just return 'this'?

          Else patch looks good (again)

          Show
          stack added a comment - I went over the patch again. I think I follow what is going on. This AuthenticationTokenIdentifier implements the Hadoop TokenIdentifier. Its a Writable and nought you can do about it, not at moment, so you are outputting pb when write and expecting pb when you readFrom. That seems to make sense given the constraint. Is this needed anymore? public static final long VERSION = 0L; Why do this Gary? + return AuthenticationProtos.AuthenticationService.newReflectiveService(this); Why can't we just return 'this'? Else patch looks good (again)
          Hide
          Gary Helmling added a comment -

          Stack Thanks for the review. Sorry to update it again just after you've taken a look.

          This AuthenticationTokenIdentifier implements the Hadoop TokenIdentifier.

          Yes, AuthenticationTokenIdentifier still needs to retain the Writable interface since Token (Hadoop class) uses this internally, and we rely on Token to tie in transparently to the Hadoop UGI credentials.

          public static final long VERSION = 0L;

          Nice catch, no longer needed.

          + return AuthenticationProtos.AuthenticationService.newReflectiveService(this);

          Since TokenProvider implements AuthenticationService.Interface, this translates that back into a Service instance.

          Show
          Gary Helmling added a comment - Stack Thanks for the review. Sorry to update it again just after you've taken a look. This AuthenticationTokenIdentifier implements the Hadoop TokenIdentifier. Yes, AuthenticationTokenIdentifier still needs to retain the Writable interface since Token (Hadoop class) uses this internally, and we rely on Token to tie in transparently to the Hadoop UGI credentials. public static final long VERSION = 0L; Nice catch, no longer needed. + return AuthenticationProtos.AuthenticationService.newReflectiveService(this); Since TokenProvider implements AuthenticationService.Interface, this translates that back into a Service instance.
          Hide
          Gary Helmling added a comment -

          Updated patch addressing Nick's comment on required PB fields, Stack's comment on VERSION and adding a real test of token auth to TestTokenAuthentication.

          Show
          Gary Helmling added a comment - Updated patch addressing Nick's comment on required PB fields, Stack's comment on VERSION and adding a real test of token auth to TestTokenAuthentication.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12560924/HBASE-6788_2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool generates 5 additional warning messages with this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.token.TestTokenAuthentication
          org.apache.hadoop.hbase.replication.TestReplication

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560924/HBASE-6788_2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool generates 5 additional warning messages with this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.token.TestTokenAuthentication org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3543//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          I added the following line to start TokenServer:

              serverThread.run();
              // wait for startup
              Thread.sleep(1000);
          

          But this call:

                this.rpcServer.start();
          

          resulted in:

          java.lang.IllegalThreadStateException
            at java.lang.Thread.start(Thread.java:656)
            at org.apache.hadoop.hbase.ipc.HBaseServer.startThreads(HBaseServer.java:2004)
            at org.apache.hadoop.hbase.ipc.ProtobufRpcEngine$Server.startThreads(ProtobufRpcEngine.java:293)
            at org.apache.hadoop.hbase.ipc.HBaseServer.start(HBaseServer.java:1986)
            at org.apache.hadoop.hbase.security.token.TestTokenAuthentication$TokenServer.initialize(TestTokenAuthentication.java:167)
          

          Will dig some more.

          Show
          Ted Yu added a comment - I added the following line to start TokenServer: serverThread.run(); // wait for startup Thread .sleep(1000); But this call: this .rpcServer.start(); resulted in: java.lang.IllegalThreadStateException at java.lang. Thread .start( Thread .java:656) at org.apache.hadoop.hbase.ipc.HBaseServer.startThreads(HBaseServer.java:2004) at org.apache.hadoop.hbase.ipc.ProtobufRpcEngine$Server.startThreads(ProtobufRpcEngine.java:293) at org.apache.hadoop.hbase.ipc.HBaseServer.start(HBaseServer.java:1986) at org.apache.hadoop.hbase.security.token.TestTokenAuthentication$TokenServer.initialize(TestTokenAuthentication.java:167) Will dig some more.
          Hide
          Gary Helmling added a comment -

          Thanks for taking a look, Ted. I don't think the serverThread.run() should be needed, as Threads.setDaemonRunning() does call .start() on the passed in thread.

          TestTokenAuthentication is passing repeatedly for me locally, but obviously something is wrong. I'll take a look at the QA bot output and see what's going on.

          Show
          Gary Helmling added a comment - Thanks for taking a look, Ted. I don't think the serverThread.run() should be needed, as Threads.setDaemonRunning() does call .start() on the passed in thread. TestTokenAuthentication is passing repeatedly for me locally, but obviously something is wrong. I'll take a look at the QA bot output and see what's going on.
          Hide
          Gary Helmling added a comment -

          Hadoop QA output is reporting a NPE in setupBeforeClass() – the secretManager reference is null. This shows up in the following lines of TestTokenAuthentication:

          secretManager = (AuthenticationTokenSecretManager)server.getSecretManager();
          while(secretManager.getCurrentKey() == null) {
          

          In the while loop test, it seems that secretManger is null.

          I'm thinking this is a timing issue, with the TokenServer's RpcServer not yet fully started up. I'll put in a better wait busy loop until TokenServer is up, and see if that fixes it.

          Show
          Gary Helmling added a comment - Hadoop QA output is reporting a NPE in setupBeforeClass() – the secretManager reference is null. This shows up in the following lines of TestTokenAuthentication: secretManager = (AuthenticationTokenSecretManager)server.getSecretManager(); while (secretManager.getCurrentKey() == null ) { In the while loop test, it seems that secretManger is null. I'm thinking this is a timing issue, with the TokenServer's RpcServer not yet fully started up. I'll put in a better wait busy loop until TokenServer is up, and see if that fixes it.
          Hide
          Gary Helmling added a comment -

          New patch that waits for TokenServer startup in TestTokenAuthentication.

          Show
          Gary Helmling added a comment - New patch that waits for TokenServer startup in TestTokenAuthentication.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12561007/HBASE-6788_3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool generates 5 additional warning messages with this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestRollingRestart
          org.apache.hadoop.hbase.security.token.TestTokenAuthentication

          -1 core zombie tests. There are zombie tests. See build logs for details.

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561007/HBASE-6788_3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool generates 5 additional warning messages with this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRollingRestart org.apache.hadoop.hbase.security.token.TestTokenAuthentication -1 core zombie tests . There are zombie tests. See build logs for details. Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3547//console This message is automatically generated.
          Hide
          Gary Helmling added a comment -

          Hmm, the NPE still seems to be thrown in effectively the same place. Is there any way to see the test logging output from Hadoop QA? I've been unable to reproduce this locally at all.

          Show
          Gary Helmling added a comment - Hmm, the NPE still seems to be thrown in effectively the same place. Is there any way to see the test logging output from Hadoop QA? I've been unable to reproduce this locally at all.
          Hide
          stack added a comment -

          The testBasicRollingRestart failure has output but your test failure doesn't which is way unjust... https://builds.apache.org/job/PreCommit-HBASE-Build/3547//testReport/org.apache.hadoop.hbase.master/TestRollingRestart/testBasicRollingRestart/

          Show
          stack added a comment - The testBasicRollingRestart failure has output but your test failure doesn't which is way unjust... https://builds.apache.org/job/PreCommit-HBASE-Build/3547//testReport/org.apache.hadoop.hbase.master/TestRollingRestart/testBasicRollingRestart/
          Hide
          Gary Helmling added a comment -

          I think what's failing in Hadoop QA is the SecureTestUtil.forceInitializeSecurity() call (which I had reservations was ugly to add anyway).

          This patch removes the need for that by having HBaseClient and HBaseServer use User.isHBaseSecurityEnabled(), which looks for the hbase.security.authentication config value. I think this is ultimately the more correct approach for HBaseClient/HBaseServer anyway, but I think it merits an entirely separate JIRA for discussing the change. I'm just including those changes here to verify that it does actually resolve the Hadoop QA test failure.

          Show
          Gary Helmling added a comment - I think what's failing in Hadoop QA is the SecureTestUtil.forceInitializeSecurity() call (which I had reservations was ugly to add anyway). This patch removes the need for that by having HBaseClient and HBaseServer use User.isHBaseSecurityEnabled(), which looks for the hbase.security.authentication config value. I think this is ultimately the more correct approach for HBaseClient/HBaseServer anyway, but I think it merits an entirely separate JIRA for discussing the change. I'm just including those changes here to verify that it does actually resolve the Hadoop QA test failure.
          Hide
          Ted Yu added a comment -

          Here is test output when I use patch v3:

          2012-12-14 12:58:02,640 INFO  [main] log.Slf4jLog(67): Logging to org.slf4j.impl.Log4jLoggerAdapter(org.mortbay.log) via org.mortbay.log.Slf4jLog
          2012-12-14 12:58:02,949 DEBUG [main] log.Slf4jLog(49): Security enabled = false
          2012-12-14 12:58:03,121 INFO  [main] hbase.HBaseTestingUtility(343): Created new mini-cluster data directory: /Users/zhihyu/trunk-hbase/hbase-server/target/test-data/e8346a90-1a41-4862-9d85-1aa325694f6e/dfscluster_3e981e0e-898b-4c8d-aa9c-c5caf69a8095
          2012-12-14 12:58:03,270 INFO  [main] zookeeper.MiniZooKeeperCluster(197): Started MiniZK Cluster and connect 1 ZK server on client port: 63609
          2012-12-14 12:58:03,379 WARN  [main] impl.MetricsSystemImpl(137): Metrics system not started: Cannot locate configuration: tried hadoop-metrics2-hbase.properties, hadoop-metrics2.properties
          2012-12-14 12:58:03,402 DEBUG [TokenServer:10.246.204.205,58917,1355518683274] zookeeper.ZKConfig(84): Skipped reading ZK properties file 'zoo.cfg' since 'hbase.config.read.zookeeper.config' was not set to true
          2012-12-14 12:58:03,406 DEBUG [TokenServer:10.246.204.205,58917,1355518683274] zookeeper.ZKUtil(102): TokenServer opening connection to ZooKeeper with ensemble (localhost:63609)
          2012-12-14 12:58:03,426 INFO  [TokenServer:10.246.204.205,58917,1355518683274] zookeeper.RecoverableZooKeeper(104): The identifier of this process is 81456@LM-SJC-00713032
          2012-12-14 12:58:03,452 DEBUG [TokenServer:10.246.204.205,58917,1355518683274-EventThread] zookeeper.ZooKeeperWatcher(265): TokenServer Received ZooKeeper Event, type=None, state=SyncConnected, path=null
          2012-12-14 12:58:03,454 DEBUG [TokenServer:10.246.204.205,58917,1355518683274-EventThread] zookeeper.ZooKeeperWatcher(342): TokenServer-0x13b9b35a83c0000 connected
          2012-12-14 12:58:03,472 DEBUG [TokenServer:10.246.204.205,58917,1355518683274] log.Slf4jLog(49): Security enabled = false
          2012-12-14 12:58:03,570 INFO  [main] log.Slf4jLog(67): Stopping due to: Test complete
          2012-12-14 12:58:03,573 INFO  [main] zookeeper.MiniZooKeeperCluster(246): Shutdown MiniZK cluster with all ZK servers
          

          Note: security was shown as disabled.

          Show
          Ted Yu added a comment - Here is test output when I use patch v3: 2012-12-14 12:58:02,640 INFO [main] log.Slf4jLog(67): Logging to org.slf4j.impl.Log4jLoggerAdapter(org.mortbay.log) via org.mortbay.log.Slf4jLog 2012-12-14 12:58:02,949 DEBUG [main] log.Slf4jLog(49): Security enabled = false 2012-12-14 12:58:03,121 INFO [main] hbase.HBaseTestingUtility(343): Created new mini-cluster data directory: /Users/zhihyu/trunk-hbase/hbase-server/target/test-data/e8346a90-1a41-4862-9d85-1aa325694f6e/dfscluster_3e981e0e-898b-4c8d-aa9c-c5caf69a8095 2012-12-14 12:58:03,270 INFO [main] zookeeper.MiniZooKeeperCluster(197): Started MiniZK Cluster and connect 1 ZK server on client port: 63609 2012-12-14 12:58:03,379 WARN [main] impl.MetricsSystemImpl(137): Metrics system not started: Cannot locate configuration: tried hadoop-metrics2-hbase.properties, hadoop-metrics2.properties 2012-12-14 12:58:03,402 DEBUG [TokenServer:10.246.204.205,58917,1355518683274] zookeeper.ZKConfig(84): Skipped reading ZK properties file 'zoo.cfg' since 'hbase.config.read.zookeeper.config' was not set to true 2012-12-14 12:58:03,406 DEBUG [TokenServer:10.246.204.205,58917,1355518683274] zookeeper.ZKUtil(102): TokenServer opening connection to ZooKeeper with ensemble (localhost:63609) 2012-12-14 12:58:03,426 INFO [TokenServer:10.246.204.205,58917,1355518683274] zookeeper.RecoverableZooKeeper(104): The identifier of this process is 81456@LM-SJC-00713032 2012-12-14 12:58:03,452 DEBUG [TokenServer:10.246.204.205,58917,1355518683274-EventThread] zookeeper.ZooKeeperWatcher(265): TokenServer Received ZooKeeper Event, type=None, state=SyncConnected, path= null 2012-12-14 12:58:03,454 DEBUG [TokenServer:10.246.204.205,58917,1355518683274-EventThread] zookeeper.ZooKeeperWatcher(342): TokenServer-0x13b9b35a83c0000 connected 2012-12-14 12:58:03,472 DEBUG [TokenServer:10.246.204.205,58917,1355518683274] log.Slf4jLog(49): Security enabled = false 2012-12-14 12:58:03,570 INFO [main] log.Slf4jLog(67): Stopping due to: Test complete 2012-12-14 12:58:03,573 INFO [main] zookeeper.MiniZooKeeperCluster(246): Shutdown MiniZK cluster with all ZK servers Note: security was shown as disabled.
          Hide
          Gary Helmling added a comment -

          Thanks, Ted. That would verify that the SecureTestUtil.forceInitializeSecurity() call is failing. The HBASE-6788_4.patch should fix that.

          Show
          Gary Helmling added a comment - Thanks, Ted. That would verify that the SecureTestUtil.forceInitializeSecurity() call is failing. The HBASE-6788 _4.patch should fix that.
          Hide
          Ted Yu added a comment -
          Running org.apache.hadoop.hbase.security.token.TestTokenAuthentication
          2012-12-14 13:10:12.964 java[81660:1903] Unable to load realm mapping info from SCDynamicStore
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.726 sec
          

          Now that TestTokenAuthentication passes so quickly, I wonder if it should be a large test:

           @Category(LargeTests.class)
           public class TestTokenAuthentication {
          
          Show
          Ted Yu added a comment - Running org.apache.hadoop.hbase.security.token.TestTokenAuthentication 2012-12-14 13:10:12.964 java[81660:1903] Unable to load realm mapping info from SCDynamicStore Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.726 sec Now that TestTokenAuthentication passes so quickly, I wonder if it should be a large test: @Category(LargeTests.class) public class TestTokenAuthentication {
          Hide
          Ted Yu added a comment -

          Nice test.

          +  public static interface BlockingAuthenticationService
          ...
          +  public static class TokenServer extends TokenProvider
          

          BlockingAuthenticationService and TokenServer are only used in TestTokenAuthentication. I think they can be private.

          +      // Creation of a HSA will force a resolve.
          +      InetSocketAddress initialIsa = new InetSocketAddress(hostname, port);
          

          'HSA' -> InetSocketAddress or simply ISA.

          +      // ignore passed in controller -- it's always null
          +      ServerRpcController serverController = new ServerRpcController();
          

          Does the above mean similar logic needs to be used in non-test code ?

          Show
          Ted Yu added a comment - Nice test. + public static interface BlockingAuthenticationService ... + public static class TokenServer extends TokenProvider BlockingAuthenticationService and TokenServer are only used in TestTokenAuthentication. I think they can be private. + // Creation of a HSA will force a resolve. + InetSocketAddress initialIsa = new InetSocketAddress(hostname, port); 'HSA' -> InetSocketAddress or simply ISA. + // ignore passed in controller -- it's always null + ServerRpcController serverController = new ServerRpcController(); Does the above mean similar logic needs to be used in non-test code ?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12561026/HBASE-6788_4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool generates 5 additional warning messages with this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          -1 core zombie tests. There are zombie tests. See build logs for details.

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561026/HBASE-6788_4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool generates 5 additional warning messages with this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are zombie tests. See build logs for details. Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3550//console This message is automatically generated.
          Hide
          Gary Helmling added a comment -

          BlockingAuthenticationService and TokenServer are only used in TestTokenAuthentication. I think they can be private.

          Sure, I'll change.

          'HSA' -> InetSocketAddress or simply ISA.

          Good catch, was a copy-n-pasted comment. I'll fix.

          Does the above mean similar logic needs to be used in non-test code ?

          This is only required in the test code because we are exposing the TokenProvider coprocessor endpoint as a full fledged RPC server. In the non-test endpoint implementation, this is already provided in HRegionServer.execService() and HRegion.execService().

          Show
          Gary Helmling added a comment - BlockingAuthenticationService and TokenServer are only used in TestTokenAuthentication. I think they can be private. Sure, I'll change. 'HSA' -> InetSocketAddress or simply ISA. Good catch, was a copy-n-pasted comment. I'll fix. Does the above mean similar logic needs to be used in non-test code ? This is only required in the test code because we are exposing the TokenProvider coprocessor endpoint as a full fledged RPC server. In the non-test endpoint implementation, this is already provided in HRegionServer.execService() and HRegion.execService().
          Hide
          Gary Helmling added a comment -

          Now that TestTokenAuthentication passes so quickly, I wonder if it should be a large test:

          I could change to medium, but it does still stand up a MiniZooKeeperCluster, so in my mind it's still bigger than the small tests.

          Show
          Gary Helmling added a comment - Now that TestTokenAuthentication passes so quickly, I wonder if it should be a large test: I could change to medium, but it does still stand up a MiniZooKeeperCluster, so in my mind it's still bigger than the small tests.
          Hide
          Gary Helmling added a comment -

          Updated patch rebased against current trunk. This pulls in the HBASE-7357 changes and makes TestTokenAuthentication work around the ZK SASL setup from HBASE-4791.

          Show
          Gary Helmling added a comment - Updated patch rebased against current trunk. This pulls in the HBASE-7357 changes and makes TestTokenAuthentication work around the ZK SASL setup from HBASE-4791 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12561623/HBASE-6788_5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 28 new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 232 release audit warnings (more than the trunk's current 84 warnings).

          +1 core tests. The patch passed unit tests in .

          -1 core zombie tests. There are zombie tests. See build logs for details.

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561623/HBASE-6788_5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 28 new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 232 release audit warnings (more than the trunk's current 84 warnings). +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are zombie tests. See build logs for details. Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3603//console This message is automatically generated.
          Hide
          stack added a comment -

          +1 on commit.

          Show
          stack added a comment - +1 on commit.
          Hide
          Gary Helmling added a comment -

          Patch HBASE-6788_5.patch committed to trunk. Thanks all for the review.

          Show
          Gary Helmling added a comment - Patch HBASE-6788 _5.patch committed to trunk. Thanks all for the review.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3640 (See https://builds.apache.org/job/HBase-TRUNK/3640/)
          HBASE-6788 Convert AuthenticationProtocol to protocol buffer service; ADDENDUM (Revision 1424146)
          HBASE-6788 Convert AuthenticationProtocol to protocol buffer service (Revision 1424122)

          Result = FAILURE
          garyh :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationProtocol.java

          garyh :
          Files :

          • /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java
          • /hbase/trunk/hbase-protocol/src/main/protobuf/Authentication.proto
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3640 (See https://builds.apache.org/job/HBase-TRUNK/3640/ ) HBASE-6788 Convert AuthenticationProtocol to protocol buffer service; ADDENDUM (Revision 1424146) HBASE-6788 Convert AuthenticationProtocol to protocol buffer service (Revision 1424122) Result = FAILURE garyh : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationProtocol.java garyh : Files : /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java /hbase/trunk/hbase-protocol/src/main/protobuf/Authentication.proto /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #304 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/304/)
          HBASE-6788 Convert AuthenticationProtocol to protocol buffer service; ADDENDUM (Revision 1424146)
          HBASE-6788 Convert AuthenticationProtocol to protocol buffer service (Revision 1424122)

          Result = FAILURE
          garyh :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationProtocol.java

          garyh :
          Files :

          • /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java
          • /hbase/trunk/hbase-protocol/src/main/protobuf/Authentication.proto
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #304 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/304/ ) HBASE-6788 Convert AuthenticationProtocol to protocol buffer service; ADDENDUM (Revision 1424146) HBASE-6788 Convert AuthenticationProtocol to protocol buffer service (Revision 1424122) Result = FAILURE garyh : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationProtocol.java garyh : Files : /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java /hbase/trunk/hbase-protocol/src/main/protobuf/Authentication.proto /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.

            People

            • Assignee:
              Gary Helmling
              Reporter:
              Gary Helmling
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development